mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-14 06:35:12 +00:00
fd9b8547bc
Currently uring CMD operation relies on having large SQEs, but future
operations might want to use normal SQE.
The io_uring_cmd currently only saves the payload (cmd) part of the SQE,
but, for commands that use normal SQE size, it might be necessary to
access the initial SQE fields outside of the payload/cmd block. So,
saves the whole SQE other than just the pdu.
This changes slightly how the io_uring_cmd works, since the cmd
structures and callbacks are not opaque to io_uring anymore. I.e, the
callbacks can look at the SQE entries, not only, in the cmd structure.
The main advantage is that we don't need to create custom structures for
simple commands.
Creates io_uring_sqe_cmd() that returns the cmd private data as a null
pointer and avoids casting in the callee side.
Also, make most of ublk_drv's sqe->cmd priv structure into const, and use
io_uring_sqe_cmd() to get the private structure, removing the unwanted
cast. (There is one case where the cast is still needed since the
header->{len,addr} is updated in the private structure)
Suggested-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/20230504121856.904491-3-leitao@debian.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
107 lines
2.7 KiB
C
107 lines
2.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
#ifndef _LINUX_IO_URING_H
|
|
#define _LINUX_IO_URING_H
|
|
|
|
#include <linux/sched.h>
|
|
#include <linux/xarray.h>
|
|
#include <uapi/linux/io_uring.h>
|
|
|
|
enum io_uring_cmd_flags {
|
|
IO_URING_F_COMPLETE_DEFER = 1,
|
|
IO_URING_F_UNLOCKED = 2,
|
|
/* the request is executed from poll, it should not be freed */
|
|
IO_URING_F_MULTISHOT = 4,
|
|
/* executed by io-wq */
|
|
IO_URING_F_IOWQ = 8,
|
|
/* int's last bit, sign checks are usually faster than a bit test */
|
|
IO_URING_F_NONBLOCK = INT_MIN,
|
|
|
|
/* ctx state flags, for URING_CMD */
|
|
IO_URING_F_SQE128 = (1 << 8),
|
|
IO_URING_F_CQE32 = (1 << 9),
|
|
IO_URING_F_IOPOLL = (1 << 10),
|
|
};
|
|
|
|
struct io_uring_cmd {
|
|
struct file *file;
|
|
const struct io_uring_sqe *sqe;
|
|
union {
|
|
/* callback to defer completions to task context */
|
|
void (*task_work_cb)(struct io_uring_cmd *cmd, unsigned);
|
|
/* used for polled completion */
|
|
void *cookie;
|
|
};
|
|
u32 cmd_op;
|
|
u32 flags;
|
|
u8 pdu[32]; /* available inline for free use */
|
|
};
|
|
|
|
#if defined(CONFIG_IO_URING)
|
|
int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
|
|
struct iov_iter *iter, void *ioucmd);
|
|
void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret, ssize_t res2,
|
|
unsigned issue_flags);
|
|
void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
|
|
void (*task_work_cb)(struct io_uring_cmd *, unsigned));
|
|
struct sock *io_uring_get_socket(struct file *file);
|
|
void __io_uring_cancel(bool cancel_all);
|
|
void __io_uring_free(struct task_struct *tsk);
|
|
void io_uring_unreg_ringfd(void);
|
|
const char *io_uring_get_opcode(u8 opcode);
|
|
|
|
static inline void io_uring_files_cancel(void)
|
|
{
|
|
if (current->io_uring) {
|
|
io_uring_unreg_ringfd();
|
|
__io_uring_cancel(false);
|
|
}
|
|
}
|
|
static inline void io_uring_task_cancel(void)
|
|
{
|
|
if (current->io_uring)
|
|
__io_uring_cancel(true);
|
|
}
|
|
static inline void io_uring_free(struct task_struct *tsk)
|
|
{
|
|
if (tsk->io_uring)
|
|
__io_uring_free(tsk);
|
|
}
|
|
|
|
static inline const void *io_uring_sqe_cmd(const struct io_uring_sqe *sqe)
|
|
{
|
|
return sqe->cmd;
|
|
}
|
|
#else
|
|
static inline int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
|
|
struct iov_iter *iter, void *ioucmd)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret,
|
|
ssize_t ret2, unsigned issue_flags)
|
|
{
|
|
}
|
|
static inline void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
|
|
void (*task_work_cb)(struct io_uring_cmd *, unsigned))
|
|
{
|
|
}
|
|
static inline struct sock *io_uring_get_socket(struct file *file)
|
|
{
|
|
return NULL;
|
|
}
|
|
static inline void io_uring_task_cancel(void)
|
|
{
|
|
}
|
|
static inline void io_uring_files_cancel(void)
|
|
{
|
|
}
|
|
static inline void io_uring_free(struct task_struct *tsk)
|
|
{
|
|
}
|
|
static inline const char *io_uring_get_opcode(u8 opcode)
|
|
{
|
|
return "";
|
|
}
|
|
#endif
|
|
|
|
#endif
|