Dave Chinner fe4c224aa1 xfs: inode log reservations are still too small ... Back in commit 23956703 ("xfs: inode log reservations are too small"), the reservation size was increased to take into account the difference in size between the in-memory BMBT block headers and the on-disk BMDR headers. This solved a transaction overrun when logging the inode size. Recently, however, we've seen a number of these same overruns on kernels with the above fix in it. All of them have been by 4 bytes, so we must still not be accounting for something correctly. Through inspection it turns out the above commit didn't take into account everything it should have. That is, it only accounts for a single log op_hdr structure, when it can actually require up to four op_hdrs - one for each region (log iovec) that is formatted. These regions are the inode log format header, the inode core, and the two forks that can be held in the literal area of the inode. This means we are not accounting for 36 bytes of log space that the transaction can use, and hence when we get inodes in certain formats with particular fragmentation patterns we can overrun the transaction. Fix this by adding the correct accounting for log op_headers in the transaction. Tested-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>		2014-03-07 16:19:14 +11:00
..
Kconfig	xfs: introduce CONFIG_XFS_WARN	2013-05-07 18:45:36 -05:00
kmem.c	xfs: use NOIO contexts for vm_map_ram	2014-03-07 16:19:14 +11:00
kmem.h	xfs: simplify kmem_{zone_}zalloc	2013-11-06 16:31:27 -06:00
Makefile	xfs: abstract the differences in dir2/dir3 via an ops vector	2013-10-30 13:37:38 -05:00
mrlock.h	xfs: introduce CONFIG_XFS_WARN	2013-05-07 18:45:36 -05:00
time.h
uuid.c
uuid.h	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
xfs.h	xfs: introduce CONFIG_XFS_WARN	2013-05-07 18:45:36 -05:00
xfs_acl.c	xfs: use generic posix ACL infrastructure	2014-01-25 23:58:21 -05:00
xfs_acl.h	xfs: use generic posix ACL infrastructure	2014-01-25 23:58:21 -05:00
xfs_ag.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_alloc.c	xfs: add tracepoints to AGF/AGI read operations	2013-11-06 12:42:52 -06:00
xfs_alloc.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_alloc_btree.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_alloc_btree.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_aops.c	xfs: xfs_check_page_type buffer checks need help	2014-03-07 16:19:14 +11:00
xfs_aops.h	direct-io: Implement generic deferred AIO completions	2013-09-04 09:23:46 -04:00
xfs_attr.c	xfs: use xfs_ilock_attr_map_shared in xfs_attr_get	2013-12-18 16:07:09 -06:00
xfs_attr.h	xfs: kill xfs_vnodeops.[ch]	2013-08-12 16:53:39 -05:00
xfs_attr_inactive.c	xfs: vectorise encoding/decoding directory headers	2013-10-30 13:47:22 -05:00
xfs_attr_leaf.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_attr_leaf.h	xfs: unify directory/attribute format definitions	2013-10-23 14:21:40 -05:00
xfs_attr_list.c	xfs: use xfs_ilock_attr_map_shared in xfs_attr_list_int	2013-12-18 16:08:04 -06:00
xfs_attr_remote.c	xfs: fix off-by-one error in xfs_attr3_rmt_verify	2014-01-10 12:38:41 -06:00
xfs_attr_remote.h	xfs: unify directory/attribute format definitions	2013-10-23 14:21:40 -05:00
xfs_attr_sf.h
xfs_bit.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_bit.h
xfs_bmap.c	Merge branch 'xfs-extent-list-locking-fixes' into for-next	2014-01-09 16:03:18 -06:00
xfs_bmap.h	xfs: remove __KERNEL__ from debug code	2013-08-12 16:58:37 -05:00
xfs_bmap_btree.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_bmap_btree.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_bmap_util.c	xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK()	2014-01-10 12:39:38 -06:00
xfs_bmap_util.h	xfs: fold xfs_change_file_space into xfs_ioc_space	2013-10-21 16:57:03 -05:00
xfs_btree.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_btree.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_buf.c	xfs: use NOIO contexts for vm_map_ram	2014-03-07 16:19:14 +11:00
xfs_buf.h	xfs: allow logical-sector sized O_DIRECT	2014-01-24 11:55:42 -06:00
xfs_buf_item.c	Merge branch 'xfs-for-linus-v3.13-rc5' into for-next	2013-12-18 10:36:58 -06:00
xfs_buf_item.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_cksum.h	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
xfs_da_btree.c	xfs: convert directory vector functions to constants	2013-10-30 13:49:18 -05:00
xfs_da_btree.h	xfs: abstract the differences in dir2/dir3 via an ops vector	2013-10-30 13:37:38 -05:00
xfs_da_format.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_da_format.h	xfs: convert directory vector functions to constants	2013-10-30 13:48:41 -05:00
xfs_dinode.h	xfs: di_flushiter considered harmful	2013-07-25 10:41:42 -05:00
xfs_dir2.c	xfs: convert directory vector functions to constants	2013-10-30 13:49:18 -05:00
xfs_dir2.h	xfs: convert directory vector functions to constants	2013-10-30 13:49:18 -05:00
xfs_dir2_block.c	xfs: convert directory vector functions to constants	2013-10-30 13:49:18 -05:00
xfs_dir2_data.c	xfs: validity check the directory block leaf entry count	2013-10-30 13:57:14 -05:00
xfs_dir2_leaf.c	xfs: convert directory vector functions to constants	2013-10-30 13:49:18 -05:00
xfs_dir2_node.c	xfs: fix memory leak in xfs_dir2_node_removename	2013-12-17 09:15:12 -06:00
xfs_dir2_priv.h	xfs: vectorise encoding/decoding directory headers	2013-10-30 13:47:22 -05:00
xfs_dir2_readdir.c	xfs: reinstate the ilock in xfs_readdir	2013-12-18 15:52:36 -06:00
xfs_dir2_sf.c	xfs: xfs_dir2_block_to_sf temp buffer allocation fails	2013-12-11 14:59:20 -06:00
xfs_discard.c	xfs: don't perform discard if the given range length is less than block size	2013-12-10 10:00:33 -06:00
xfs_discard.h
xfs_dquot.c	xfs: use xfs_ilock_data_map_shared in xfs_qm_dqtobp	2013-12-18 16:04:18 -06:00
xfs_dquot.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_dquot_buf.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_dquot_item.c	xfs: remove the quotaoff log format from the quotaoff log item	2013-12-13 11:34:08 +11:00
xfs_dquot_item.h	xfs: remove the quotaoff log format from the quotaoff log item	2013-12-13 11:34:08 +11:00
xfs_error.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_error.h
xfs_export.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_export.h
xfs_extent_busy.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_extent_busy.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_extfree_item.c	xfs: format log items write directly into the linear CIL buffer	2013-12-13 11:34:02 +11:00
xfs_extfree_item.h	xfs: split out EFI/EFD log item format definition	2013-08-12 16:07:13 -05:00
xfs_file.c	xfs: allow logical-sector sized O_DIRECT	2014-01-24 11:55:42 -06:00
xfs_filestream.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_filestream.h	xfs: xfs_filestreams.h doesn't need __KERNEL__	2013-08-12 17:00:11 -05:00
xfs_format.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_fs.h	xfs: add the inode directory type support to XFS_IOC_FSGEOM	2013-10-08 14:28:09 -05:00
xfs_fsops.c	xfs: growfs overruns AGFL buffer on V4 filesystems	2013-12-10 10:04:27 -06:00
xfs_fsops.h
xfs_globals.c	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_ialloc.c	xfs: avoid AGI/AGF deadlock scenario for inode chunk allocation	2014-03-07 16:19:14 +11:00
xfs_ialloc.h	xfs: introduce a common helper xfs_icluster_size_fsb	2013-12-13 15:51:48 +11:00
xfs_ialloc_btree.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_ialloc_btree.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_icache.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_icache.h	xfs: update #2 for v3.12-rc1	2013-09-12 16:13:41 -07:00
xfs_icreate_item.c	xfs: format log items write directly into the linear CIL buffer	2013-12-13 11:34:02 +11:00
xfs_icreate_item.h	xfs: separate icreate log format definitions from xfs_icreate_item.h	2013-08-12 16:10:35 -05:00
xfs_inode.c	Merge branch 'xfs-extent-list-locking-fixes' into for-next	2014-01-09 16:03:18 -06:00
xfs_inode.h	xfs: add xfs_ilock_attr_map_shared	2013-12-18 15:48:44 -06:00
xfs_inode_buf.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_inode_buf.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_inode_fork.c	Merge branch 'xfs-extent-list-locking-fixes' into for-next	2014-01-09 16:03:18 -06:00
xfs_inode_fork.h	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_inode_item.c	xfs: remove the inode log format from the inode log item	2013-12-13 11:34:05 +11:00
xfs_inode_item.h	xfs: remove the inode log format from the inode log item	2013-12-13 11:34:05 +11:00
xfs_inum.h	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_ioctl.c	xfs: allow logical-sector sized O_DIRECT	2014-01-24 11:55:42 -06:00
xfs_ioctl.h	xfs: consolidate extent swap code	2013-08-12 16:56:06 -05:00
xfs_ioctl32.c	xfs: underflow bug in xfs_attrlist_by_handle()	2013-12-10 09:59:37 -06:00
xfs_ioctl32.h
xfs_iomap.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_iomap.h	xfs: get rid of count from xfs_iomap_write_allocate()	2013-10-01 15:42:34 -05:00
xfs_iops.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-01-28 08:38:04 -08:00
xfs_iops.h	xfs: use generic posix ACL infrastructure	2014-01-25 23:58:21 -05:00
xfs_itable.c	xfs: use xfs_icluster_size_fsb in xfs_bulkstat	2013-12-13 15:51:48 +11:00
xfs_itable.h
xfs_linux.h	xfs: remove two unused macro definitions in xfs_linux.h	2013-08-20 15:30:23 -05:00
xfs_log.c	xfs: trace AIL manipulations	2013-11-06 12:41:51 -06:00
xfs_log.h	xfs: format log items write directly into the linear CIL buffer	2013-12-13 11:34:02 +11:00
xfs_log_cil.c	xfs: format log items write directly into the linear CIL buffer	2013-12-13 11:34:02 +11:00
xfs_log_format.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_log_priv.h	xfs: decouple log and transaction headers	2013-10-23 16:17:44 -05:00
xfs_log_recover.c	Merge branch 'xfs-for-linus-v3.13-rc5' into for-next	2013-12-18 10:36:58 -06:00
xfs_log_recover.h
xfs_log_rlimit.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_message.c	xfs: decouple log and transaction headers	2013-10-23 16:17:44 -05:00
xfs_message.h	xfs: introduce CONFIG_XFS_WARN	2013-05-07 18:45:36 -05:00
xfs_mount.c	xfs: don't leak EFSBADCRC to userspace	2014-03-07 16:19:14 +11:00
xfs_mount.h	xfs: increase inode cluster size for v5 filesystems	2013-11-18 09:29:36 -06:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_qm.c	xfs: use xfs_ilock_data_map_shared in xfs_qm_dqiterate	2013-12-18 16:06:38 -06:00
xfs_qm.h	xfs: integrate xfs_quota_priv header file to xfs_qm	2013-12-06 14:16:33 -06:00
xfs_qm_bhv.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_qm_syscalls.c	xfs: make quota metadata truncation behavior consistent to user space	2013-12-06 14:06:15 -06:00
xfs_quota.h	xfs: split dquot buffer operations out	2013-10-23 14:28:35 -05:00
xfs_quota_defs.h	xfs: split dquot buffer operations out	2013-10-23 14:28:35 -05:00
xfs_quotaops.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_rtalloc.c	xfs: split xfs_rtalloc.c for userspace sanity	2013-10-23 17:16:32 -05:00
xfs_rtalloc.h	xfs: split xfs_rtalloc.c for userspace sanity	2013-10-23 17:16:32 -05:00
xfs_rtbitmap.c	xfs: fix static and extern sparse warnings	2013-10-30 13:59:56 -05:00
xfs_sb.c	xfs: be more forgiving of a v4 secondary sb w/ junk in v5 fields	2013-10-30 16:38:29 -05:00
xfs_sb.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_shared.h	xfs: create a shared header file for format-related information	2013-10-23 14:11:30 -05:00
xfs_stats.c	xfs: use common code for quota statistics	2012-03-14 11:09:06 -05:00
xfs_stats.h	xfs: use common code for quota statistics	2012-03-14 11:09:06 -05:00
xfs_super.c	xfs: update for v3.13-rc1	2013-11-14 17:16:35 +09:00
xfs_super.h	xfs: xfs_sync_data is redundant.	2012-10-17 12:01:25 -05:00
xfs_symlink.c	xfs: don't leak EFSBADCRC to userspace	2014-03-07 16:19:14 +11:00
xfs_symlink.h	xfs: push down inactive transaction mgmt for remote symlinks	2013-10-08 14:53:02 -05:00
xfs_symlink_remote.c	xfs: decouple log and transaction headers	2013-10-23 16:17:44 -05:00
xfs_sysctl.c	xfs: Convert use of typedef ctl_table to struct ctl_table	2013-06-17 17:42:25 -05:00
xfs_sysctl.h	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_trace.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_trace.h	xfs: add tracepoints to AGF/AGI read operations	2013-11-06 12:42:52 -06:00
xfs_trans.c	xfs: decouple inode and bmap btree header files	2013-10-23 16:28:49 -05:00
xfs_trans.h	xfs: format log items write directly into the linear CIL buffer	2013-12-13 11:34:02 +11:00
xfs_trans_ail.c	xfs: trace AIL manipulations	2013-11-06 12:41:51 -06:00
xfs_trans_buf.c	xfs: don't leak EFSBADCRC to userspace	2014-03-07 16:19:14 +11:00
xfs_trans_dquot.c	xfs: fix the comment explaining xfs_trans_dqlockedjoin	2013-12-04 14:26:57 -06:00
xfs_trans_extfree.c	xfs: decouple log and transaction headers	2013-10-23 16:17:44 -05:00
xfs_trans_inode.c	xfs: open code inc_inode_iversion when logging an inode	2013-11-18 09:42:08 -06:00
xfs_trans_priv.h	xfs: decouple log and transaction headers	2013-10-23 16:17:44 -05:00
xfs_trans_resv.c	xfs: inode log reservations are still too small	2014-03-07 16:19:14 +11:00
xfs_trans_resv.h	xfs: Get rid of all XFS_XXX_LOG_RES() macro	2013-08-12 17:48:08 -05:00
xfs_trans_space.h	xfs: get rid of XFS_IALLOC_BLOCKS macros	2013-12-13 15:51:48 +11:00
xfs_types.h	xfs: Add read-only support for dirent filetype field	2013-08-22 08:40:24 -05:00
xfs_vnode.h	xfs: remove unused FI_ flags	2013-12-04 14:11:05 -06:00
xfs_xattr.c	xfs: use generic posix ACL infrastructure	2014-01-25 23:58:21 -05:00