Yufen Yu 5d4dc30b4c blk-mq: run queue no matter whether the request is the last request ... commit d3b3859687 upstream. We do test on a virtio scsi device (/dev/sda) and the default mq scheduler is 'none'. We found a IO hung as following: blk_finish_plug blk_mq_plug_issue_direct scsi_mq_get_budget //get budget_token fail and sdev->restarts=1 scsi_end_request scsi_run_queue_async //sdev->restart=0 and run queue blk_mq_request_bypass_insert //add request to hctx->dispatch list //continue to dispath plug list blk_mq_dispatch_plug_list blk_mq_try_issue_list_directly //success issue all requests from plug list After .get_budget fail, scsi_mq_get_budget will increase 'restarts'. Normally, it will run hw queue when io complete and set 'restarts' as 0. But if we run queue before adding request to the dispatch list and blk_mq_dispatch_plug_list also success issue all requests, then on one will run queue, and the request will be stall in the dispatch list and cannot complete forever. It is wrong to use last request of plug list to decide if run queue is needed since all the remained requests in plug list may be from other hctxs. To fix the bug, pass run_queue as true always to blk_mq_request_bypass_insert(). Fix-suggested-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Yufen Yu <yuyufen@huawei.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Fixes: dc5fc361d8 ("block: attempt direct issue of plug list") Link: https://lore.kernel.org/r/20220803023355.3687360-1-yuyufen@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-08-25 11:45:36 +02:00
..
partitions	for-5.19/drivers-2022-05-22	2022-05-23 14:04:14 -07:00
badblocks.c	block/badblocks: Remove redundant assignments	2022-04-23 07:15:26 -06:00
bdev.c	Description for this pull request:	2022-05-24 18:30:27 -07:00
bfq-cgroup.c	bfq: Make sure bfqg for which we are queueing requests is online	2022-04-17 19:34:32 -06:00
bfq-iosched.c	block/bfq: Enable I/O statistics	2022-06-16 16:59:28 -06:00
bfq-iosched.h	bfq: Relax waker detection for shared queues	2022-05-19 06:52:33 -06:00
bfq-wf2q.c	block, bfq: cleanup bfq_bfqq_to_bfqg()	2022-02-18 06:13:00 -07:00
bio-integrity.c	for-5.18/block-2022-03-18	2022-03-21 16:48:55 -07:00
bio.c	block: ensure iov_iter advances for added pages	2022-08-17 15:15:43 +02:00
blk-cgroup-fc-appid.c	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
blk-cgroup-rwstat.c	blk-cgroup: Fix the recursive blkg rwstat	2021-03-05 11:32:15 -07:00
blk-cgroup-rwstat.h	block: partition include/linux/blk-cgroup.h	2022-02-11 10:02:41 -07:00
blk-cgroup.c	block: fix bio_clone_blkg_association() to associate with proper blkcg_gq	2022-06-02 02:15:05 -06:00
blk-cgroup.h	blk-cgroup: always terminate io.stat lines	2022-05-17 06:11:17 -06:00
blk-core.c	block: disable the elevator int del_gendisk	2022-06-17 07:31:05 -06:00
blk-crypto-fallback.c	block: remove superfluous calls to blkcg_bio_issue_init	2022-05-04 18:29:52 -06:00
blk-crypto-internal.h	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-crypto-profile.c	blk-crypto: remove blk_crypto_unregister()	2021-11-29 06:38:51 -07:00
blk-crypto-sysfs.c	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-crypto.c	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-flush.c	block: pass a block_device and opf to bio_init	2022-02-02 07:49:59 -07:00
blk-ia-ranges.c	block: remove queue from struct blk_independent_access_range	2022-06-19 18:40:11 -06:00
blk-integrity.c	blk-crypto: remove blk_crypto_unregister()	2021-11-29 06:38:51 -07:00
blk-ioc.c	block: fix default IO priority handling again	2022-08-11 13:22:02 +02:00
blk-iocost.c	block: don't allow the same type rq_qos add more than once	2022-08-17 15:16:10 +02:00
blk-iolatency.c	block: don't allow the same type rq_qos add more than once	2022-08-17 15:16:10 +02:00
blk-ioprio.c	block: partition include/linux/blk-cgroup.h	2022-02-11 10:02:41 -07:00
blk-ioprio.h	block: Introduce the ioprio rq-qos policy	2021-06-21 15:03:40 -06:00
blk-lib.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
blk-map.c	block/blk-map: Remove redundant assignment	2022-04-23 07:15:26 -06:00
blk-merge.c	block: fix missing blkcg_bio_issue_init	2022-07-14 10:54:49 -06:00
blk-mq-cpumap.c	blk-mq: remove the calling of local_memory_node()	2020-10-20 07:08:17 -06:00
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	blk-mq: don't create hctx debugfs dir until q->debugfs_dir is created	2022-08-17 15:14:16 +02:00
blk-mq-debugfs.h	block: remove per-disk debugfs files in blk_unregister_queue	2022-06-17 07:31:05 -06:00
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	block: serialize all debugfs operations using q->debugfs_mutex	2022-06-17 07:31:05 -06:00
blk-mq-sched.h	block: move blk_mq_sched_assign_ioc to blk-ioc.c	2021-11-29 06:41:29 -07:00
blk-mq-sysfs.c	blk-mq: prepare for implementing hctx table via xarray	2022-03-08 17:57:19 -07:00
blk-mq-tag.c	block: remove useless BUG_ON() in blk_mq_put_tag()	2022-06-02 02:05:56 -06:00
blk-mq-tag.h	blk-mq: Delete busy_iter_fn	2021-12-06 13:18:47 -07:00
blk-mq-virtio.c
blk-mq.c	blk-mq: run queue no matter whether the request is the last request	2022-08-25 11:45:36 +02:00
blk-mq.h	blk-mq: manage hctx map via xarray	2022-03-08 19:39:38 -07:00
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2021-12-22 23:38:29 -05:00
blk-pm.h	block: Remove unused blk_pm_*() function definitions	2021-02-22 06:33:48 -07:00
blk-rq-qos.c	block: remove per-disk debugfs files in blk_unregister_queue	2022-06-17 07:31:05 -06:00
blk-rq-qos.h	block: don't allow the same type rq_qos add more than once	2022-08-17 15:16:10 +02:00
blk-settings.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
blk-stat.c	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
blk-stat.h	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
blk-sysfs.c	block: remove per-disk debugfs files in blk_unregister_queue	2022-06-17 07:31:05 -06:00
blk-throttle.c	blk-throttle: Set BIO_THROTTLED when bio has been throttled	2022-05-17 19:32:10 -06:00
blk-throttle.h	block: cancel all throttled bios in del_gendisk()	2022-03-18 09:57:56 -06:00
blk-timeout.c
blk-wbt.c	block: don't allow the same type rq_qos add more than once	2022-08-17 15:16:10 +02:00
blk-wbt.h	blk-wbt: remove wbt_track stub	2022-03-31 12:58:38 -06:00
blk-zoned.c	SCSI misc on 20220324	2022-03-24 19:37:53 -07:00
blk.h	block: refactor discard bio size limiting	2022-04-17 19:49:59 -06:00
bounce.c	block: remove superfluous calls to blkcg_bio_issue_init	2022-05-04 18:29:52 -06:00
bsg-lib.c	block: remove the gendisk argument to blk_execute_rq	2021-11-29 06:41:29 -07:00
bsg.c	scsi: bsg: Fix device unregistration	2021-09-14 00:22:15 -04:00
disk-events.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
elevator.c	for-5.18/block-2022-03-18	2022-03-21 16:48:55 -07:00
elevator.h	block: move elevator.h to block/	2021-10-18 06:17:01 -06:00
fops.c	Page cache changes for 5.19	2022-05-24 19:55:07 -07:00
genhd.c	block: freeze the queue earlier in del_gendisk	2022-06-17 07:31:05 -06:00
holder.c	block: remove WARN_ON() from bd_link_disk_holder	2022-06-23 07:48:05 -06:00
ioctl.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
ioprio.c	block: fix default IO priority handling again	2022-08-11 13:22:02 +02:00
Kconfig	block: add pi for extended integrity	2022-03-07 12:48:35 -07:00
Kconfig.iosched	block: only build the icq tracking code when needed	2021-12-16 10:59:02 -07:00
kyber-iosched.c	blk-mq: avoid to touch q->elevator without any protection	2022-06-16 14:45:15 -06:00
Makefile	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
mq-deadline.c	blk-mq: avoid to touch q->elevator without any protection	2022-06-16 14:45:15 -06:00
opal_proto.h
sed-opal.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
t10-pi.c	block: add pi for extended integrity	2022-03-07 12:48:35 -07:00