mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
![Denis Turischev](/assets/img/avatar_default.png)
Patch "xhci: Switch Intel Lynx Point ports to EHCI on shutdown."
commit c09ec25d36
is not fully correct
It switches both Lynx Point and Lynx Point-LP ports to EHCI on shutdown.
On some Lynx Point machines it causes spurious interrupt,
which wake the system: bugzilla.kernel.org/show_bug.cgi?id=76291
On Lynx Point-LP on the contrary switching ports to EHCI seems to be
necessary to fix these spurious interrupts.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
Reported-by: Wulf Richartz <wulf.richartz@gmail.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
415 lines
12 KiB
C
415 lines
12 KiB
C
/*
|
|
* xHCI host controller driver PCI Bus Glue.
|
|
*
|
|
* Copyright (C) 2008 Intel Corp.
|
|
*
|
|
* Author: Sarah Sharp
|
|
* Some code borrowed from the Linux EHCI driver.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
|
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#include <linux/pci.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "xhci.h"
|
|
#include "xhci-trace.h"
|
|
|
|
/* Device for a quirk */
|
|
#define PCI_VENDOR_ID_FRESCO_LOGIC 0x1b73
|
|
#define PCI_DEVICE_ID_FRESCO_LOGIC_PDK 0x1000
|
|
#define PCI_DEVICE_ID_FRESCO_LOGIC_FL1400 0x1400
|
|
|
|
#define PCI_VENDOR_ID_ETRON 0x1b6f
|
|
#define PCI_DEVICE_ID_ASROCK_P67 0x7023
|
|
|
|
#define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x8c31
|
|
#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI 0x9c31
|
|
|
|
static const char hcd_name[] = "xhci_hcd";
|
|
|
|
/* called after powerup, by probe or system-pm "wakeup" */
|
|
static int xhci_pci_reinit(struct xhci_hcd *xhci, struct pci_dev *pdev)
|
|
{
|
|
/*
|
|
* TODO: Implement finding debug ports later.
|
|
* TODO: see if there are any quirks that need to be added to handle
|
|
* new extended capabilities.
|
|
*/
|
|
|
|
/* PCI Memory-Write-Invalidate cycle support is optional (uncommon) */
|
|
if (!pci_set_mwi(pdev))
|
|
xhci_dbg(xhci, "MWI active\n");
|
|
|
|
xhci_dbg(xhci, "Finished xhci_pci_reinit\n");
|
|
return 0;
|
|
}
|
|
|
|
static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(dev);
|
|
|
|
/* Look for vendor-specific quirks */
|
|
if (pdev->vendor == PCI_VENDOR_ID_FRESCO_LOGIC &&
|
|
(pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK ||
|
|
pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_FL1400)) {
|
|
if (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK &&
|
|
pdev->revision == 0x0) {
|
|
xhci->quirks |= XHCI_RESET_EP_QUIRK;
|
|
xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
|
|
"QUIRK: Fresco Logic xHC needs configure"
|
|
" endpoint cmd after reset endpoint");
|
|
}
|
|
if (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK &&
|
|
pdev->revision == 0x4) {
|
|
xhci->quirks |= XHCI_SLOW_SUSPEND;
|
|
xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
|
|
"QUIRK: Fresco Logic xHC revision %u"
|
|
"must be suspended extra slowly",
|
|
pdev->revision);
|
|
}
|
|
/* Fresco Logic confirms: all revisions of this chip do not
|
|
* support MSI, even though some of them claim to in their PCI
|
|
* capabilities.
|
|
*/
|
|
xhci->quirks |= XHCI_BROKEN_MSI;
|
|
xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
|
|
"QUIRK: Fresco Logic revision %u "
|
|
"has broken MSI implementation",
|
|
pdev->revision);
|
|
xhci->quirks |= XHCI_TRUST_TX_LENGTH;
|
|
}
|
|
|
|
if (pdev->vendor == PCI_VENDOR_ID_NEC)
|
|
xhci->quirks |= XHCI_NEC_HOST;
|
|
|
|
if (pdev->vendor == PCI_VENDOR_ID_AMD && xhci->hci_version == 0x96)
|
|
xhci->quirks |= XHCI_AMD_0x96_HOST;
|
|
|
|
/* AMD PLL quirk */
|
|
if (pdev->vendor == PCI_VENDOR_ID_AMD && usb_amd_find_chipset_info())
|
|
xhci->quirks |= XHCI_AMD_PLL_FIX;
|
|
if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
|
|
xhci->quirks |= XHCI_LPM_SUPPORT;
|
|
xhci->quirks |= XHCI_INTEL_HOST;
|
|
}
|
|
if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
|
|
pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) {
|
|
xhci->quirks |= XHCI_EP_LIMIT_QUIRK;
|
|
xhci->limit_active_eps = 64;
|
|
xhci->quirks |= XHCI_SW_BW_CHECKING;
|
|
/*
|
|
* PPT desktop boards DH77EB and DH77DF will power back on after
|
|
* a few seconds of being shutdown. The fix for this is to
|
|
* switch the ports from xHCI to EHCI on shutdown. We can't use
|
|
* DMI information to find those particular boards (since each
|
|
* vendor will change the board name), so we have to key off all
|
|
* PPT chipsets.
|
|
*/
|
|
xhci->quirks |= XHCI_SPURIOUS_REBOOT;
|
|
xhci->quirks |= XHCI_AVOID_BEI;
|
|
}
|
|
if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
|
|
(pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI ||
|
|
pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI)) {
|
|
/* Workaround for occasional spurious wakeups from S5 (or
|
|
* any other sleep) on Haswell machines with LPT and LPT-LP
|
|
* with the new Intel BIOS
|
|
*/
|
|
/* Limit the quirk to only known vendors, as this triggers
|
|
* yet another BIOS bug on some other machines
|
|
* https://bugzilla.kernel.org/show_bug.cgi?id=66171
|
|
*/
|
|
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
|
|
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
|
|
}
|
|
if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
|
|
pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI) {
|
|
xhci->quirks |= XHCI_SPURIOUS_REBOOT;
|
|
}
|
|
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
|
|
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
|
|
xhci->quirks |= XHCI_RESET_ON_RESUME;
|
|
xhci->quirks |= XHCI_TRUST_TX_LENGTH;
|
|
}
|
|
if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
|
|
pdev->device == 0x0015)
|
|
xhci->quirks |= XHCI_RESET_ON_RESUME;
|
|
if (pdev->vendor == PCI_VENDOR_ID_VIA)
|
|
xhci->quirks |= XHCI_RESET_ON_RESUME;
|
|
|
|
if (xhci->quirks & XHCI_RESET_ON_RESUME)
|
|
xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
|
|
"QUIRK: Resetting on resume");
|
|
}
|
|
|
|
/* called during probe() after chip reset completes */
|
|
static int xhci_pci_setup(struct usb_hcd *hcd)
|
|
{
|
|
struct xhci_hcd *xhci;
|
|
struct pci_dev *pdev = to_pci_dev(hcd->self.controller);
|
|
int retval;
|
|
|
|
retval = xhci_gen_setup(hcd, xhci_pci_quirks);
|
|
if (retval)
|
|
return retval;
|
|
|
|
xhci = hcd_to_xhci(hcd);
|
|
if (!usb_hcd_is_primary_hcd(hcd))
|
|
return 0;
|
|
|
|
pci_read_config_byte(pdev, XHCI_SBRN_OFFSET, &xhci->sbrn);
|
|
xhci_dbg(xhci, "Got SBRN %u\n", (unsigned int) xhci->sbrn);
|
|
|
|
/* Find any debug ports */
|
|
retval = xhci_pci_reinit(xhci, pdev);
|
|
if (!retval)
|
|
return retval;
|
|
|
|
kfree(xhci);
|
|
return retval;
|
|
}
|
|
|
|
/*
|
|
* We need to register our own PCI probe function (instead of the USB core's
|
|
* function) in order to create a second roothub under xHCI.
|
|
*/
|
|
static int xhci_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
|
|
{
|
|
int retval;
|
|
struct xhci_hcd *xhci;
|
|
struct hc_driver *driver;
|
|
struct usb_hcd *hcd;
|
|
|
|
driver = (struct hc_driver *)id->driver_data;
|
|
|
|
/* Prevent runtime suspending between USB-2 and USB-3 initialization */
|
|
pm_runtime_get_noresume(&dev->dev);
|
|
|
|
/* Register the USB 2.0 roothub.
|
|
* FIXME: USB core must know to register the USB 2.0 roothub first.
|
|
* This is sort of silly, because we could just set the HCD driver flags
|
|
* to say USB 2.0, but I'm not sure what the implications would be in
|
|
* the other parts of the HCD code.
|
|
*/
|
|
retval = usb_hcd_pci_probe(dev, id);
|
|
|
|
if (retval)
|
|
goto put_runtime_pm;
|
|
|
|
/* USB 2.0 roothub is stored in the PCI device now. */
|
|
hcd = dev_get_drvdata(&dev->dev);
|
|
xhci = hcd_to_xhci(hcd);
|
|
xhci->shared_hcd = usb_create_shared_hcd(driver, &dev->dev,
|
|
pci_name(dev), hcd);
|
|
if (!xhci->shared_hcd) {
|
|
retval = -ENOMEM;
|
|
goto dealloc_usb2_hcd;
|
|
}
|
|
|
|
/* Set the xHCI pointer before xhci_pci_setup() (aka hcd_driver.reset)
|
|
* is called by usb_add_hcd().
|
|
*/
|
|
*((struct xhci_hcd **) xhci->shared_hcd->hcd_priv) = xhci;
|
|
|
|
retval = usb_add_hcd(xhci->shared_hcd, dev->irq,
|
|
IRQF_SHARED);
|
|
if (retval)
|
|
goto put_usb3_hcd;
|
|
/* Roothub already marked as USB 3.0 speed */
|
|
|
|
if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
|
|
xhci->shared_hcd->can_do_streams = 1;
|
|
|
|
/* USB-2 and USB-3 roothubs initialized, allow runtime pm suspend */
|
|
pm_runtime_put_noidle(&dev->dev);
|
|
|
|
return 0;
|
|
|
|
put_usb3_hcd:
|
|
usb_put_hcd(xhci->shared_hcd);
|
|
dealloc_usb2_hcd:
|
|
usb_hcd_pci_remove(dev);
|
|
put_runtime_pm:
|
|
pm_runtime_put_noidle(&dev->dev);
|
|
return retval;
|
|
}
|
|
|
|
static void xhci_pci_remove(struct pci_dev *dev)
|
|
{
|
|
struct xhci_hcd *xhci;
|
|
|
|
xhci = hcd_to_xhci(pci_get_drvdata(dev));
|
|
if (xhci->shared_hcd) {
|
|
usb_remove_hcd(xhci->shared_hcd);
|
|
usb_put_hcd(xhci->shared_hcd);
|
|
}
|
|
usb_hcd_pci_remove(dev);
|
|
|
|
/* Workaround for spurious wakeups at shutdown with HSW */
|
|
if (xhci->quirks & XHCI_SPURIOUS_WAKEUP)
|
|
pci_set_power_state(dev, PCI_D3hot);
|
|
|
|
kfree(xhci);
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int xhci_pci_suspend(struct usb_hcd *hcd, bool do_wakeup)
|
|
{
|
|
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
|
|
struct pci_dev *pdev = to_pci_dev(hcd->self.controller);
|
|
|
|
/*
|
|
* Systems with the TI redriver that loses port status change events
|
|
* need to have the registers polled during D3, so avoid D3cold.
|
|
*/
|
|
if (xhci_compliance_mode_recovery_timer_quirk_check())
|
|
pdev->no_d3cold = true;
|
|
|
|
return xhci_suspend(xhci);
|
|
}
|
|
|
|
static int xhci_pci_resume(struct usb_hcd *hcd, bool hibernated)
|
|
{
|
|
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
|
|
struct pci_dev *pdev = to_pci_dev(hcd->self.controller);
|
|
int retval = 0;
|
|
|
|
/* The BIOS on systems with the Intel Panther Point chipset may or may
|
|
* not support xHCI natively. That means that during system resume, it
|
|
* may switch the ports back to EHCI so that users can use their
|
|
* keyboard to select a kernel from GRUB after resume from hibernate.
|
|
*
|
|
* The BIOS is supposed to remember whether the OS had xHCI ports
|
|
* enabled before resume, and switch the ports back to xHCI when the
|
|
* BIOS/OS semaphore is written, but we all know we can't trust BIOS
|
|
* writers.
|
|
*
|
|
* Unconditionally switch the ports back to xHCI after a system resume.
|
|
* It should not matter whether the EHCI or xHCI controller is
|
|
* resumed first. It's enough to do the switchover in xHCI because
|
|
* USB core won't notice anything as the hub driver doesn't start
|
|
* running again until after all the devices (including both EHCI and
|
|
* xHCI host controllers) have been resumed.
|
|
*/
|
|
|
|
if (pdev->vendor == PCI_VENDOR_ID_INTEL)
|
|
usb_enable_intel_xhci_ports(pdev);
|
|
|
|
retval = xhci_resume(xhci, hibernated);
|
|
return retval;
|
|
}
|
|
#endif /* CONFIG_PM */
|
|
|
|
static const struct hc_driver xhci_pci_hc_driver = {
|
|
.description = hcd_name,
|
|
.product_desc = "xHCI Host Controller",
|
|
.hcd_priv_size = sizeof(struct xhci_hcd *),
|
|
|
|
/*
|
|
* generic hardware linkage
|
|
*/
|
|
.irq = xhci_irq,
|
|
.flags = HCD_MEMORY | HCD_USB3 | HCD_SHARED,
|
|
|
|
/*
|
|
* basic lifecycle operations
|
|
*/
|
|
.reset = xhci_pci_setup,
|
|
.start = xhci_run,
|
|
#ifdef CONFIG_PM
|
|
.pci_suspend = xhci_pci_suspend,
|
|
.pci_resume = xhci_pci_resume,
|
|
#endif
|
|
.stop = xhci_stop,
|
|
.shutdown = xhci_shutdown,
|
|
|
|
/*
|
|
* managing i/o requests and associated device resources
|
|
*/
|
|
.urb_enqueue = xhci_urb_enqueue,
|
|
.urb_dequeue = xhci_urb_dequeue,
|
|
.alloc_dev = xhci_alloc_dev,
|
|
.free_dev = xhci_free_dev,
|
|
.alloc_streams = xhci_alloc_streams,
|
|
.free_streams = xhci_free_streams,
|
|
.add_endpoint = xhci_add_endpoint,
|
|
.drop_endpoint = xhci_drop_endpoint,
|
|
.endpoint_reset = xhci_endpoint_reset,
|
|
.check_bandwidth = xhci_check_bandwidth,
|
|
.reset_bandwidth = xhci_reset_bandwidth,
|
|
.address_device = xhci_address_device,
|
|
.enable_device = xhci_enable_device,
|
|
.update_hub_device = xhci_update_hub_device,
|
|
.reset_device = xhci_discover_or_reset_device,
|
|
|
|
/*
|
|
* scheduling support
|
|
*/
|
|
.get_frame_number = xhci_get_frame,
|
|
|
|
/* Root hub support */
|
|
.hub_control = xhci_hub_control,
|
|
.hub_status_data = xhci_hub_status_data,
|
|
.bus_suspend = xhci_bus_suspend,
|
|
.bus_resume = xhci_bus_resume,
|
|
/*
|
|
* call back when device connected and addressed
|
|
*/
|
|
.update_device = xhci_update_device,
|
|
.set_usb2_hw_lpm = xhci_set_usb2_hardware_lpm,
|
|
.enable_usb3_lpm_timeout = xhci_enable_usb3_lpm_timeout,
|
|
.disable_usb3_lpm_timeout = xhci_disable_usb3_lpm_timeout,
|
|
.find_raw_port_number = xhci_find_raw_port_number,
|
|
};
|
|
|
|
/*-------------------------------------------------------------------------*/
|
|
|
|
/* PCI driver selection metadata; PCI hotplugging uses this */
|
|
static const struct pci_device_id pci_ids[] = { {
|
|
/* handle any USB 3.0 xHCI controller */
|
|
PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_XHCI, ~0),
|
|
.driver_data = (unsigned long) &xhci_pci_hc_driver,
|
|
},
|
|
{ /* end: all zeroes */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(pci, pci_ids);
|
|
|
|
/* pci driver glue; this is a "new style" PCI driver module */
|
|
static struct pci_driver xhci_pci_driver = {
|
|
.name = (char *) hcd_name,
|
|
.id_table = pci_ids,
|
|
|
|
.probe = xhci_pci_probe,
|
|
.remove = xhci_pci_remove,
|
|
/* suspend and resume implemented later */
|
|
|
|
.shutdown = usb_hcd_pci_shutdown,
|
|
#ifdef CONFIG_PM
|
|
.driver = {
|
|
.pm = &usb_hcd_pci_pm_ops
|
|
},
|
|
#endif
|
|
};
|
|
|
|
int __init xhci_register_pci(void)
|
|
{
|
|
return pci_register_driver(&xhci_pci_driver);
|
|
}
|
|
|
|
void xhci_unregister_pci(void)
|
|
{
|
|
pci_unregister_driver(&xhci_pci_driver);
|
|
}
|