mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Greg Kroah-Hartman](/assets/img/avatar_default.png)
Many source files in the tree are missing licensing information, which makes it harder for compliance tools to determine the correct license. By default all files without license information are under the default license of the kernel, which is GPL version 2. Update the files which contain no license information with the 'GPL-2.0' SPDX license identifier. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. This patch is based on work done by Thomas Gleixner and Kate Stewart and Philippe Ombredanne. How this work was done: Patches were generated and checked against linux-4.14-rc6 for a subset of the use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information, Further patches will be generated in subsequent months to fix up cases where non-standard license headers were used, and references to license had to be inferred by heuristics based on keywords. The analysis to determine which SPDX License Identifier to be applied to a file was done in a spreadsheet of side by side results from of the output of two independent scanners (ScanCode & Windriver) producing SPDX tag:value files created by Philippe Ombredanne. Philippe prepared the base worksheet, and did an initial spot review of a few 1000 files. The 4.13 kernel was the starting point of the analysis with 60,537 files assessed. Kate Stewart did a file by file comparison of the scanner results in the spreadsheet to determine which SPDX license identifier(s) to be applied to the file. She confirmed any determination that was not immediately clear with lawyers working with the Linux Foundation. Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines). All documentation files were explicitly excluded. The following heuristics were used to determine which SPDX license identifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time. In total, over 70 hours of logged manual review was done on the spreadsheet to determine the SPDX license identifiers to apply to the source files by Kate, Philippe, Thomas and, in some cases, confirmation by lawyers working with the Linux Foundation. Kate also obtained a third independent scan of the 4.13 code base from FOSSology, and compared selected files where the other two scanners disagreed against that SPDX file, to see if there was new insights. The Windriver scanner is based on an older version of FOSSology in part, so they are related. Thomas did random spot checks in about 500 files from the spreadsheets for the uapi headers and agreed with SPDX license identifier in the files he inspected. For the non-uapi files Thomas did random spot checks in about 15000 files. In initial set of patches against 4.14-rc6, 3 files were found to have copy/paste license identifier errors, and have been fixed to reflect the correct identifier. Additionally Philippe spent 10 hours this week doing a detailed manual inspection and review of the 12,461 patched files from the initial patch version early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correct This produced a worksheet with 20 files needing minor correction. This worksheet was then exported into 3 different .csv files for the different types of files to be modified. These .csv files were then reviewed by Greg. Thomas wrote a script to parse the csv files and add the proper SPDX tag to the file, in the format that the file expected. This script was further refined by Greg based on the output to detect more types of files automatically and to distinguish between header and source .c files (which need different comment types.) Finally Greg ran the script using the .csv files to generate the patches. Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org> Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com> Reviewed-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
400 lines
9 KiB
Bash
400 lines
9 KiB
Bash
#!/bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
# Uncomment to see generated bytecode
|
|
#VERBOSE=verbose
|
|
|
|
NS1=lwt_ns1
|
|
NS2=lwt_ns2
|
|
VETH0=tst_lwt1a
|
|
VETH1=tst_lwt1b
|
|
VETH2=tst_lwt2a
|
|
VETH3=tst_lwt2b
|
|
IPVETH0="192.168.254.1"
|
|
IPVETH1="192.168.254.2"
|
|
IPVETH1b="192.168.254.3"
|
|
|
|
IPVETH2="192.168.111.1"
|
|
IPVETH3="192.168.111.2"
|
|
|
|
IP_LOCAL="192.168.99.1"
|
|
|
|
TRACE_ROOT=/sys/kernel/debug/tracing
|
|
|
|
function lookup_mac()
|
|
{
|
|
set +x
|
|
if [ ! -z "$2" ]; then
|
|
MAC=$(ip netns exec $2 ip link show $1 | grep ether | awk '{print $2}')
|
|
else
|
|
MAC=$(ip link show $1 | grep ether | awk '{print $2}')
|
|
fi
|
|
MAC="${MAC//:/}"
|
|
echo "0x${MAC:10:2}${MAC:8:2}${MAC:6:2}${MAC:4:2}${MAC:2:2}${MAC:0:2}"
|
|
set -x
|
|
}
|
|
|
|
function cleanup {
|
|
set +ex
|
|
rm test_lwt_bpf.o 2> /dev/null
|
|
ip link del $VETH0 2> /dev/null
|
|
ip link del $VETH1 2> /dev/null
|
|
ip link del $VETH2 2> /dev/null
|
|
ip link del $VETH3 2> /dev/null
|
|
ip netns exec $NS1 killall netserver
|
|
ip netns delete $NS1 2> /dev/null
|
|
ip netns delete $NS2 2> /dev/null
|
|
set -ex
|
|
}
|
|
|
|
function setup_one_veth {
|
|
ip netns add $1
|
|
ip link add $2 type veth peer name $3
|
|
ip link set dev $2 up
|
|
ip addr add $4/24 dev $2
|
|
ip link set $3 netns $1
|
|
ip netns exec $1 ip link set dev $3 up
|
|
ip netns exec $1 ip addr add $5/24 dev $3
|
|
|
|
if [ "$6" ]; then
|
|
ip netns exec $1 ip addr add $6/32 dev $3
|
|
fi
|
|
}
|
|
|
|
function get_trace {
|
|
set +x
|
|
cat ${TRACE_ROOT}/trace | grep -v '^#'
|
|
set -x
|
|
}
|
|
|
|
function cleanup_routes {
|
|
ip route del ${IPVETH1}/32 dev $VETH0 2> /dev/null || true
|
|
ip route del table local local ${IP_LOCAL}/32 dev lo 2> /dev/null || true
|
|
}
|
|
|
|
function install_test {
|
|
cleanup_routes
|
|
cp /dev/null ${TRACE_ROOT}/trace
|
|
|
|
OPTS="encap bpf headroom 14 $1 obj test_lwt_bpf.o section $2 $VERBOSE"
|
|
|
|
if [ "$1" == "in" ]; then
|
|
ip route add table local local ${IP_LOCAL}/32 $OPTS dev lo
|
|
else
|
|
ip route add ${IPVETH1}/32 $OPTS dev $VETH0
|
|
fi
|
|
}
|
|
|
|
function remove_prog {
|
|
if [ "$1" == "in" ]; then
|
|
ip route del table local local ${IP_LOCAL}/32 dev lo
|
|
else
|
|
ip route del ${IPVETH1}/32 dev $VETH0
|
|
fi
|
|
}
|
|
|
|
function filter_trace {
|
|
# Add newline to allow starting EXPECT= variables on newline
|
|
NL=$'\n'
|
|
echo "${NL}$*" | sed -e 's/^.*: : //g'
|
|
}
|
|
|
|
function expect_fail {
|
|
set +x
|
|
echo "FAIL:"
|
|
echo "Expected: $1"
|
|
echo "Got: $2"
|
|
set -x
|
|
exit 1
|
|
}
|
|
|
|
function match_trace {
|
|
set +x
|
|
RET=0
|
|
TRACE=$1
|
|
EXPECT=$2
|
|
GOT="$(filter_trace "$TRACE")"
|
|
|
|
[ "$GOT" != "$EXPECT" ] && {
|
|
expect_fail "$EXPECT" "$GOT"
|
|
RET=1
|
|
}
|
|
set -x
|
|
return $RET
|
|
}
|
|
|
|
function test_start {
|
|
set +x
|
|
echo "----------------------------------------------------------------"
|
|
echo "Starting test: $*"
|
|
echo "----------------------------------------------------------------"
|
|
set -x
|
|
}
|
|
|
|
function failure {
|
|
get_trace
|
|
echo "FAIL: $*"
|
|
exit 1
|
|
}
|
|
|
|
function test_ctx_xmit {
|
|
test_start "test_ctx on lwt xmit"
|
|
install_test xmit test_ctx
|
|
ping -c 3 $IPVETH1 || {
|
|
failure "test_ctx xmit: packets are dropped"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 0 ifindex $DST_IFINDEX
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 0 ifindex $DST_IFINDEX
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 0 ifindex $DST_IFINDEX" || exit 1
|
|
remove_prog xmit
|
|
}
|
|
|
|
function test_ctx_out {
|
|
test_start "test_ctx on lwt out"
|
|
install_test out test_ctx
|
|
ping -c 3 $IPVETH1 || {
|
|
failure "test_ctx out: packets are dropped"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
len 84 hash 0 protocol 0
|
|
cb 1234 ingress_ifindex 0 ifindex 0
|
|
len 84 hash 0 protocol 0
|
|
cb 1234 ingress_ifindex 0 ifindex 0
|
|
len 84 hash 0 protocol 0
|
|
cb 1234 ingress_ifindex 0 ifindex 0" || exit 1
|
|
remove_prog out
|
|
}
|
|
|
|
function test_ctx_in {
|
|
test_start "test_ctx on lwt in"
|
|
install_test in test_ctx
|
|
ping -c 3 $IP_LOCAL || {
|
|
failure "test_ctx out: packets are dropped"
|
|
}
|
|
# We will both request & reply packets as the packets will
|
|
# be from $IP_LOCAL => $IP_LOCAL
|
|
match_trace "$(get_trace)" "
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 1 ifindex 1
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 1 ifindex 1
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 1 ifindex 1
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 1 ifindex 1
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 1 ifindex 1
|
|
len 84 hash 0 protocol 8
|
|
cb 1234 ingress_ifindex 1 ifindex 1" || exit 1
|
|
remove_prog in
|
|
}
|
|
|
|
function test_data {
|
|
test_start "test_data on lwt $1"
|
|
install_test $1 test_data
|
|
ping -c 3 $IPVETH1 || {
|
|
failure "test_data ${1}: packets are dropped"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
src: 1fea8c0 dst: 2fea8c0
|
|
src: 1fea8c0 dst: 2fea8c0
|
|
src: 1fea8c0 dst: 2fea8c0" || exit 1
|
|
remove_prog $1
|
|
}
|
|
|
|
function test_data_in {
|
|
test_start "test_data on lwt in"
|
|
install_test in test_data
|
|
ping -c 3 $IP_LOCAL || {
|
|
failure "test_data in: packets are dropped"
|
|
}
|
|
# We will both request & reply packets as the packets will
|
|
# be from $IP_LOCAL => $IP_LOCAL
|
|
match_trace "$(get_trace)" "
|
|
src: 163a8c0 dst: 163a8c0
|
|
src: 163a8c0 dst: 163a8c0
|
|
src: 163a8c0 dst: 163a8c0
|
|
src: 163a8c0 dst: 163a8c0
|
|
src: 163a8c0 dst: 163a8c0
|
|
src: 163a8c0 dst: 163a8c0" || exit 1
|
|
remove_prog in
|
|
}
|
|
|
|
function test_cb {
|
|
test_start "test_cb on lwt $1"
|
|
install_test $1 test_cb
|
|
ping -c 3 $IPVETH1 || {
|
|
failure "test_cb ${1}: packets are dropped"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0" || exit 1
|
|
remove_prog $1
|
|
}
|
|
|
|
function test_cb_in {
|
|
test_start "test_cb on lwt in"
|
|
install_test in test_cb
|
|
ping -c 3 $IP_LOCAL || {
|
|
failure "test_cb in: packets are dropped"
|
|
}
|
|
# We will both request & reply packets as the packets will
|
|
# be from $IP_LOCAL => $IP_LOCAL
|
|
match_trace "$(get_trace)" "
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0
|
|
cb0: 0 cb1: 0 cb2: 0
|
|
cb3: 0 cb4: 0" || exit 1
|
|
remove_prog in
|
|
}
|
|
|
|
function test_drop_all {
|
|
test_start "test_drop_all on lwt $1"
|
|
install_test $1 drop_all
|
|
ping -c 3 $IPVETH1 && {
|
|
failure "test_drop_all ${1}: Unexpected success of ping"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
dropping with: 2
|
|
dropping with: 2
|
|
dropping with: 2" || exit 1
|
|
remove_prog $1
|
|
}
|
|
|
|
function test_drop_all_in {
|
|
test_start "test_drop_all on lwt in"
|
|
install_test in drop_all
|
|
ping -c 3 $IP_LOCAL && {
|
|
failure "test_drop_all in: Unexpected success of ping"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
dropping with: 2
|
|
dropping with: 2
|
|
dropping with: 2" || exit 1
|
|
remove_prog in
|
|
}
|
|
|
|
function test_push_ll_and_redirect {
|
|
test_start "test_push_ll_and_redirect on lwt xmit"
|
|
install_test xmit push_ll_and_redirect
|
|
ping -c 3 $IPVETH1 || {
|
|
failure "Redirected packets appear to be dropped"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
redirected to $DST_IFINDEX
|
|
redirected to $DST_IFINDEX
|
|
redirected to $DST_IFINDEX" || exit 1
|
|
remove_prog xmit
|
|
}
|
|
|
|
function test_no_l2_and_redirect {
|
|
test_start "test_no_l2_and_redirect on lwt xmit"
|
|
install_test xmit fill_garbage_and_redirect
|
|
ping -c 3 $IPVETH1 && {
|
|
failure "Unexpected success despite lack of L2 header"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
redirected to $DST_IFINDEX
|
|
redirected to $DST_IFINDEX
|
|
redirected to $DST_IFINDEX" || exit 1
|
|
remove_prog xmit
|
|
}
|
|
|
|
function test_rewrite {
|
|
test_start "test_rewrite on lwt xmit"
|
|
install_test xmit test_rewrite
|
|
ping -c 3 $IPVETH1 || {
|
|
failure "Rewritten packets appear to be dropped"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
out: rewriting from 2fea8c0 to 3fea8c0
|
|
out: rewriting from 2fea8c0 to 3fea8c0
|
|
out: rewriting from 2fea8c0 to 3fea8c0" || exit 1
|
|
remove_prog out
|
|
}
|
|
|
|
function test_fill_garbage {
|
|
test_start "test_fill_garbage on lwt xmit"
|
|
install_test xmit fill_garbage
|
|
ping -c 3 $IPVETH1 && {
|
|
failure "test_drop_all ${1}: Unexpected success of ping"
|
|
}
|
|
match_trace "$(get_trace)" "
|
|
Set initial 96 bytes of header to FF
|
|
Set initial 96 bytes of header to FF
|
|
Set initial 96 bytes of header to FF" || exit 1
|
|
remove_prog xmit
|
|
}
|
|
|
|
function test_netperf_nop {
|
|
test_start "test_netperf_nop on lwt xmit"
|
|
install_test xmit nop
|
|
netperf -H $IPVETH1 -t TCP_STREAM || {
|
|
failure "packets appear to be dropped"
|
|
}
|
|
match_trace "$(get_trace)" ""|| exit 1
|
|
remove_prog xmit
|
|
}
|
|
|
|
function test_netperf_redirect {
|
|
test_start "test_netperf_redirect on lwt xmit"
|
|
install_test xmit push_ll_and_redirect_silent
|
|
netperf -H $IPVETH1 -t TCP_STREAM || {
|
|
failure "Rewritten packets appear to be dropped"
|
|
}
|
|
match_trace "$(get_trace)" ""|| exit 1
|
|
remove_prog xmit
|
|
}
|
|
|
|
cleanup
|
|
setup_one_veth $NS1 $VETH0 $VETH1 $IPVETH0 $IPVETH1 $IPVETH1b
|
|
setup_one_veth $NS2 $VETH2 $VETH3 $IPVETH2 $IPVETH3
|
|
ip netns exec $NS1 netserver
|
|
echo 1 > ${TRACE_ROOT}/tracing_on
|
|
|
|
DST_MAC=$(lookup_mac $VETH1 $NS1)
|
|
SRC_MAC=$(lookup_mac $VETH0)
|
|
DST_IFINDEX=$(cat /sys/class/net/$VETH0/ifindex)
|
|
|
|
CLANG_OPTS="-O2 -target bpf -I ../include/"
|
|
CLANG_OPTS+=" -DSRC_MAC=$SRC_MAC -DDST_MAC=$DST_MAC -DDST_IFINDEX=$DST_IFINDEX"
|
|
clang $CLANG_OPTS -c test_lwt_bpf.c -o test_lwt_bpf.o
|
|
|
|
test_ctx_xmit
|
|
test_ctx_out
|
|
test_ctx_in
|
|
test_data "xmit"
|
|
test_data "out"
|
|
test_data_in
|
|
test_cb "xmit"
|
|
test_cb "out"
|
|
test_cb_in
|
|
test_drop_all "xmit"
|
|
test_drop_all "out"
|
|
test_drop_all_in
|
|
test_rewrite
|
|
test_push_ll_and_redirect
|
|
test_no_l2_and_redirect
|
|
test_fill_garbage
|
|
test_netperf_nop
|
|
test_netperf_redirect
|
|
|
|
cleanup
|
|
echo 0 > ${TRACE_ROOT}/tracing_on
|
|
exit 0
|