Xiao Ni 00e3d58f50 md: Move alloc/free acct bioset in to personality ... commit 0c031fd37f upstream. bioset acct is only needed for raid0 and raid5. Therefore, md_run only allocates it for raid0 and raid5. However, this does not cover personality takeover, which may cause uninitialized bioset. For example, the following repro steps: mdadm -CR /dev/md0 -l1 -n2 /dev/loop0 /dev/loop1 mdadm --wait /dev/md0 mkfs.xfs /dev/md0 mdadm /dev/md0 --grow -l5 mount /dev/md0 /mnt causes panic like: [ 225.933939] BUG: kernel NULL pointer dereference, address: 0000000000000000 [ 225.934903] #PF: supervisor instruction fetch in kernel mode [ 225.935639] #PF: error_code(0x0010) - not-present page [ 225.936361] PGD 0 P4D 0 [ 225.936677] Oops: 0010 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN PTI [ 225.937525] CPU: 27 PID: 1133 Comm: mount Not tainted 5.16.0-rc3+ #706 [ 225.938416] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-2.module_el8.4.0+547+a85d02ba 04/01/2014 [ 225.939922] RIP: 0010:0x0 [ 225.940289] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. [ 225.941196] RSP: 0018:ffff88815897eff0 EFLAGS: 00010246 [ 225.941897] RAX: 0000000000000000 RBX: 0000000000092800 RCX: ffffffff81370a39 [ 225.942813] RDX: dffffc0000000000 RSI: 0000000000000000 RDI: 0000000000092800 [ 225.943772] RBP: 1ffff1102b12fe04 R08: fffffbfff0b43c01 R09: fffffbfff0b43c01 [ 225.944807] R10: ffffffff85a1e007 R11: fffffbfff0b43c00 R12: ffff88810eaaaf58 [ 225.945757] R13: 0000000000000000 R14: ffff88810eaaafb8 R15: ffff88815897f040 [ 225.946709] FS: 00007ff3f2505080(0000) GS:ffff888fb5e00000(0000) knlGS:0000000000000000 [ 225.947814] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 225.948556] CR2: ffffffffffffffd6 CR3: 000000015aa5a006 CR4: 0000000000370ee0 [ 225.949537] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 225.950455] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 225.951414] Call Trace: [ 225.951787] <TASK> [ 225.952120] mempool_alloc+0xe5/0x250 [ 225.952625] ? mempool_resize+0x370/0x370 [ 225.953187] ? rcu_read_lock_sched_held+0xa1/0xd0 [ 225.953862] ? rcu_read_lock_bh_held+0xb0/0xb0 [ 225.954464] ? sched_clock_cpu+0x15/0x120 [ 225.955019] ? find_held_lock+0xac/0xd0 [ 225.955564] bio_alloc_bioset+0x1ed/0x2a0 [ 225.956080] ? lock_downgrade+0x3a0/0x3a0 [ 225.956644] ? bvec_alloc+0xc0/0xc0 [ 225.957135] bio_clone_fast+0x19/0x80 [ 225.957651] raid5_make_request+0x1370/0x1b70 [ 225.958286] ? sched_clock_cpu+0x15/0x120 [ 225.958797] ? __lock_acquire+0x8b2/0x3510 [ 225.959339] ? raid5_get_active_stripe+0xce0/0xce0 [ 225.959986] ? lock_is_held_type+0xd8/0x130 [ 225.960528] ? rcu_read_lock_sched_held+0xa1/0xd0 [ 225.961135] ? rcu_read_lock_bh_held+0xb0/0xb0 [ 225.961703] ? sched_clock_cpu+0x15/0x120 [ 225.962232] ? lock_release+0x27a/0x6c0 [ 225.962746] ? do_wait_intr_irq+0x130/0x130 [ 225.963302] ? lock_downgrade+0x3a0/0x3a0 [ 225.963815] ? lock_release+0x6c0/0x6c0 [ 225.964348] md_handle_request+0x342/0x530 [ 225.964888] ? set_in_sync+0x170/0x170 [ 225.965397] ? blk_queue_split+0x133/0x150 [ 225.965988] ? __blk_queue_split+0x8b0/0x8b0 [ 225.966524] ? submit_bio_checks+0x3b2/0x9d0 [ 225.967069] md_submit_bio+0x127/0x1c0 [...] Fix this by moving alloc/free of acct bioset to pers->run and pers->free. While we are on this, properly handle md_integrity_register() error in raid0_run(). Fixes: daee202471 (md: check level before create and exit io_acct_set) Cc: stable@vger.kernel.org Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev> Signed-off-by: Xiao Ni <xni@redhat.com> Signed-off-by: Song Liu <song@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-01-27 11:05:08 +01:00
..
bcache	bcache: Revert "bcache: use bvec_virt"	2021-11-18 19:17:17 +01:00
persistent-data	dm space map common: add bounds check to sm_ll_lookup_bitmap()	2022-01-27 11:04:53 +01:00
dm-bio-prison-v1.c
dm-bio-prison-v1.h
dm-bio-prison-v2.c
dm-bio-prison-v2.h
dm-bio-record.h	block: store a block_device pointer in struct bio	2021-01-24 18:17:20 -07:00
dm-bufio.c	dm bufio: subtract the number of initial sectors in dm_bufio_get_device_size	2021-03-04 14:53:54 -05:00
dm-builtin.c
dm-cache-background-tracker.c
dm-cache-background-tracker.h
dm-cache-block-types.h
dm-cache-metadata.c	dm: use bdev_read_only to check if a device is read-only	2021-01-24 18:15:57 -07:00
dm-cache-metadata.h
dm-cache-policy-internal.h
dm-cache-policy-smq.c
dm-cache-policy.c
dm-cache-policy.h
dm-cache-target.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-clone-metadata.c	dm clone metadata: remove unused function	2021-04-19 13:20:31 -04:00
dm-clone-metadata.h
dm-clone-target.c	dm clone: make array 'descs' static	2021-10-12 13:54:10 -04:00
dm-core.h	dm ima: measure data on table load	2021-08-10 13:32:40 -04:00
dm-crypt.c	dm crypt: use in_hardirq() instead of deprecated in_irq()	2021-08-20 16:25:07 -04:00
dm-delay.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-dust.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ebs-target.c	- Add DM infrastructure for IMA-based remote attestion. These changes	2021-08-31 14:55:09 -07:00
dm-era-target.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-exception-store.c
dm-exception-store.h
dm-flakey.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ima.c	integrity-v5.15	2021-09-02 12:51:41 -07:00
dm-ima.h	dm ima: add version info to dm related events in ima log	2021-08-20 15:59:47 -04:00
dm-init.c
dm-integrity.c	- Add DM infrastructure for IMA-based remote attestion. These changes	2021-08-31 14:55:09 -07:00
dm-io-tracker.h	dm writecache: make writeback pause configurable	2021-06-28 16:30:13 -04:00
dm-io.c	block: Add bio_max_segs	2021-02-26 15:49:51 -07:00
dm-ioctl.c	dm ima: measure data on device rename	2021-08-10 13:34:23 -04:00
dm-kcopyd.c	dm writecache: have ssd writeback wait if the kcopyd workqueue is busy	2021-06-15 15:42:03 -04:00
dm-linear.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-log-userspace-base.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log-writes.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-log.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-mpath.c	dm ima: update dm target attributes for ima measurements	2021-08-20 16:07:36 -04:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-ps-historical-service-time.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-io-affinity.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-queue-length.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-round-robin.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-service-time.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-raid.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-raid1.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-region-hash.c
dm-rq.c	dm rq: don't queue request to blk-mq during DM suspend	2021-10-12 13:54:10 -04:00
dm-rq.h
dm-snap-persistent.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-snap-transient.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-snap.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-stats.c
dm-stats.h
dm-stripe.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-switch.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-sysfs.c
dm-table.c	libnvdimm for v5.15	2021-09-09 11:39:57 -07:00
dm-target.c
dm-thin-metadata.c	dm space maps: improve performance with inc/dec on ranges of blocks	2021-06-04 12:07:22 -04:00
dm-thin-metadata.h
dm-thin.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-uevent.c
dm-uevent.h
dm-unstripe.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-verity-fec.c	dm verity fec: fix misaligned RS roots IO	2021-04-14 14:28:29 -04:00
dm-verity-fec.h	dm verity fec: fix misaligned RS roots IO	2021-04-14 14:28:29 -04:00
dm-verity-target.c	dm verity: skip redundant verity_handle_err() on I/O errors	2021-10-12 13:54:09 -04:00
dm-verity-verify-sig.c	dm verity: fix require_signatures module_param permissions	2021-05-25 16:14:05 -04:00
dm-verity-verify-sig.h
dm-verity.h
dm-writecache.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-zero.c	dm: add support for REQ_NOWAIT to various targets	2020-12-04 18:04:35 -05:00
dm-zone.c	dm zone: fix dm_revalidate_zones() memory allocation	2021-06-25 15:25:23 -04:00
dm-zoned-metadata.c	dm zoned: check zone capacity	2021-06-04 12:07:28 -04:00
dm-zoned-reclaim.c	dm kcopyd: avoid useless atomic operations	2021-06-04 12:07:24 -04:00
dm-zoned-target.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-zoned.h
dm.c	dm: fix alloc_dax error handling in alloc_dev	2022-01-27 11:04:59 +01:00
dm.h	dm: introduce zone append emulation	2021-06-04 12:07:37 -04:00
Kconfig	dm: make EBS depend on !HIGHMEM	2021-08-16 10:50:32 -06:00
Makefile	dm ima: measure data on table load	2021-08-10 13:32:40 -04:00
md-autodetect.c
md-bitmap.c	md: Constify attribute_group structs	2021-06-14 22:32:07 -07:00
md-bitmap.h
md-cluster.c	for-5.11/drivers-2020-12-14	2020-12-16 13:09:32 -08:00
md-cluster.h
md-faulty.c	md: mark some personalities as deprecated	2021-06-14 22:32:07 -07:00
md-linear.c	md: mark some personalities as deprecated	2021-06-14 22:32:07 -07:00
md-linear.h
md-multipath.c	md: mark some personalities as deprecated	2021-06-14 22:32:07 -07:00
md-multipath.h
md.c	md: Move alloc/free acct bioset in to personality	2022-01-27 11:05:08 +01:00
md.h	md: Move alloc/free acct bioset in to personality	2022-01-27 11:05:08 +01:00
raid0.c	md: Move alloc/free acct bioset in to personality	2022-01-27 11:05:08 +01:00
raid0.h
raid1-10.c
raid1.c	md/raid1: fix missing bitmap update w/o WriteMostly devices	2022-01-11 15:35:15 +01:00
raid1.h	md/raid1: enable io accounting	2021-06-14 22:32:07 -07:00
raid5-cache.c	block: rename BIO_MAX_PAGES to BIO_MAX_VECS	2021-03-11 07:47:48 -07:00
raid5-log.h
raid5-ppl.c	block: rename BIO_MAX_PAGES to BIO_MAX_VECS	2021-03-11 07:47:48 -07:00
raid5.c	md: Move alloc/free acct bioset in to personality	2022-01-27 11:05:08 +01:00
raid5.h
raid10.c	for-5.15/drivers-2021-08-30	2021-08-30 19:01:46 -07:00
raid10.h	md/raid10: enable io accounting	2021-06-14 22:32:07 -07:00