From e4450847fbc5e48f02bd0a3b9f42304b0337bb25 Mon Sep 17 00:00:00 2001 From: Vincent Batts Date: Sat, 25 Mar 2023 21:24:32 -0400 Subject: [PATCH] tar/storage: remove TODO's on sailed shipped for changing the encoding this function is used widely and it's JSON. And it was not written in such a way as to have exchangable codec.. per se So, maybe I'll just kick out the idea of using https://github.com/ugorji/go Signed-off-by: Vincent Batts --- tar/storage/packer.go | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/tar/storage/packer.go b/tar/storage/packer.go index aba6948..4ba62d9 100644 --- a/tar/storage/packer.go +++ b/tar/storage/packer.go @@ -24,13 +24,6 @@ type Unpacker interface { Next() (*Entry, error) } -/* TODO(vbatts) figure out a good model for this -type PackUnpacker interface { - Packer - Unpacker -} -*/ - type jsonUnpacker struct { seen seenNames dec *json.Decoder @@ -115,13 +108,3 @@ func NewJSONPacker(w io.Writer) Packer { seen: seenNames{}, } } - -/* -TODO(vbatts) perhaps have a more compact packer/unpacker, maybe using msgapck -(https://github.com/ugorji/go) - - -Even though, since our jsonUnpacker and jsonPacker just take -io.Reader/io.Writer, then we can get away with passing them a -gzip.Reader/gzip.Writer -*/