mirrors
/
tar-split
mirror of https://github.com/vbatts/tar-split.git
1
0
Fork 1
Code Releases Activity
212 Commits 9 Branches 27 Tags 4.8 MiB
Commit Graph

7 Commits

Author SHA1 Message Date
Miloslav Trmač 8d76363085 Avoid a 32 kB file allocation on every bitBucketFilePutter.Put 
io.Copy usually allocates a 32kB buffer, and due to the large
number of files processed by tar-split, this shows up in Go profiles
as a very large alloc_space total.

It doesn't seem to actually be a measurable problem in any way,
but we can allocate the buffer only once per tar-split creation,
at no additional cost to existing allocations, so let's do so,
and remove the distraction.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2021-08-21 03:24:39 +02:00
Alexander Morozov 45399711c2 tar/storage: Replace TeeReader with MultiWriter 
It uses slightly less memory and more understandable.
Benchmar results:

benchmark             old ns/op     new ns/op     delta
BenchmarkPutter-4     57272         52375         -8.55%

benchmark             old allocs     new allocs     delta
BenchmarkPutter-4     21             19             -9.52%
benchmark             old bytes     new bytes     delta
BenchmarkPutter-4     19416         13336         -31.31%

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
 2015-08-13 11:43:31 -07:00
Alexander Morozov e6df23162e Remove redundant TeeReader 
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
 2015-08-12 16:46:04 -07:00
Jonathan Boulle 002d19f0b0 *: clean up assorted spelling/grammar issues 
Various minor fixes noticed on walking through
 2015-07-22 15:32:49 -04:00
Vincent Batts c2c2dde4cb tar/storage: use `filepath` instead of `path` 2015-07-22 10:27:53 -04:00
Vincent Batts 46840c585a *: golint and docs 2015-03-09 14:11:11 -04:00
Vincent Batts d8ebf3c0a7 tar: mv the Getter to tar/storage 2015-03-09 13:20:26 -04:00