From 85889fe37827fe015d27e4629775b0c4e5fda444 Mon Sep 17 00:00:00 2001 From: Adnan Hajdarevic Date: Thu, 21 Dec 2017 13:14:07 +0100 Subject: [PATCH] Fix nilpointer dereference when file cannot be created --- webhook.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/webhook.go b/webhook.go index fd3ce1d..79c2c7a 100644 --- a/webhook.go +++ b/webhook.go @@ -23,7 +23,7 @@ import ( ) const ( - version = "2.6.7" + version = "2.6.8" ) var ( @@ -368,13 +368,16 @@ func handleHook(h *hook.Hook, rid string, headers, query, payload *map[string]in tmpfile, err := ioutil.TempFile(h.CommandWorkingDirectory, files[i].EnvName) if err != nil { log.Printf("[%s] error creating temp file [%s]", rid, err) + continue } log.Printf("[%s] writing env %s file %s", rid, files[i].EnvName, tmpfile.Name()) if _, err := tmpfile.Write(files[i].Data); err != nil { log.Printf("[%s] error writing file %s [%s]", rid, tmpfile.Name(), err) + continue } if err := tmpfile.Close(); err != nil { log.Printf("[%s] error closing file %s [%s]", rid, tmpfile.Name(), err) + continue } files[i].File = tmpfile