From 753d12e479888a8e3d4c798b78e3d72d361e5372 Mon Sep 17 00:00:00 2001 From: Jacob Weinstock Date: Fri, 9 Jun 2023 13:57:09 -0600 Subject: [PATCH] Remove redundant length check: The range body will not execute if the len of r.Parameter.SignaturePayloadHeaders is 0. Signed-off-by: Jacob Weinstock --- internal/hook/hook.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/internal/hook/hook.go b/internal/hook/hook.go index a766291..9620bc2 100644 --- a/internal/hook/hook.go +++ b/internal/hook/hook.go @@ -951,13 +951,11 @@ func (r MatchRule) Evaluate(req *Request) (bool, error) { // signaturePayload will concatenate the request body with header values from headers specified in r.Parameter.SignaturePayloadHeaders. func (r MatchRule) signaturePayload(body []byte, headers map[string]interface{}) []byte { - if len(r.Parameter.SignaturePayloadHeaders) > 0 { - for _, elem := range r.Parameter.SignaturePayloadHeaders { - h, found := headers[elem] - header := fmt.Sprintf("%s", h) - if found && header != "" { - body = append(body, []byte(header)...) - } + for _, elem := range r.Parameter.SignaturePayloadHeaders { + h, found := headers[elem] + header := fmt.Sprintf("%s", h) + if found && header != "" { + body = append(body, []byte(header)...) } }