mirrors/webhook
1
0
Fork 0
mirror of https://github.com/adnanh/webhook.git synced 2025-06-28 07:18:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix #718

Browse source
This commit is contained in:
Adnan Hajdarevic 2025-01-12 00:33:40 +01:00
parent 7bb680821d
commit c2da943240
3 changed files with 21 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/hook/hook.go
View file

@ -824,7 +824,7 @@ func (r Rules) Evaluate(req *Request) (bool, error) {
return r.Match.Evaluate(req)
}
return false, nil
return true, nil
}
// AndRule will evaluate to true if and only if all of the ChildRules evaluate to true

31
internal/hook/hook_test.go
View file

@ -351,20 +351,21 @@ func TestHookExtractCommandArguments(t *testing.T) {
// we test both cases where the name of the data is used as the name of the
// env key & the case where the hook definition sets the env var name to a
// fixed value using the envname construct like so::
// [
// {
// "id": "push",
// "execute-command": "bb2mm",
// "command-working-directory": "/tmp",
// "pass-environment-to-command":
// [
// {
// "source": "entire-payload",
// "envname": "PAYLOAD"
// },
// ]
// }
// ]
//
// [
// {
// "id": "push",
// "execute-command": "bb2mm",
// "command-working-directory": "/tmp",
// "pass-environment-to-command":
// [
// {
// "source": "entire-payload",
// "envname": "PAYLOAD"
// },
// ]
// }
// ]
var hookExtractCommandArgumentsForEnvTests = []struct {
exec string
args []Argument
@ -596,7 +597,7 @@ var andRuleTests = []struct {
[]byte{},
true, false,
},
{"empty rule", AndRule{{}}, nil, nil, nil, nil, false, false},
{"empty rule", AndRule{{}}, nil, nil, nil, nil, true, false},
// failures
{
"invalid rule",