From 3b59539a3364d2c677ea8032b12f72f4f0985a8a Mon Sep 17 00:00:00 2001 From: Adnan Hajdarevic Date: Thu, 29 Sep 2016 19:15:51 +0200 Subject: [PATCH 1/2] do not prefix specified environment variable name with HOOK_ (fixes #98) --- hook/hook.go | 2 +- hook/hook_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hook/hook.go b/hook/hook.go index 9699f39..4b59ce9 100644 --- a/hook/hook.go +++ b/hook/hook.go @@ -367,7 +367,7 @@ func (h *Hook) ExtractCommandArgumentsForEnv(headers, query, payload *map[string if arg, ok := h.PassEnvironmentToCommand[i].Get(headers, query, payload); ok { if h.PassEnvironmentToCommand[i].EnvName != "" { // first try to use the EnvName if specified - args = append(args, EnvNamespace+h.PassEnvironmentToCommand[i].EnvName+"="+arg) + args = append(args, h.PassEnvironmentToCommand[i].EnvName+"="+arg) } else { // then fallback on the name args = append(args, EnvNamespace+h.PassEnvironmentToCommand[i].Name+"="+arg) diff --git a/hook/hook_test.go b/hook/hook_test.go index f9ae1f7..1fc9a88 100644 --- a/hook/hook_test.go +++ b/hook/hook_test.go @@ -179,7 +179,7 @@ var hookExtractCommandArgumentsForEnvTests = []struct { "test", []Argument{Argument{"header", "a", "MYKEY"}}, &map[string]interface{}{"a": "z"}, nil, nil, - []string{"HOOK_MYKEY=z"}, + []string{"MYKEY=z"}, true, }, // failures From 1943c5311f939080f8dcb9b66d6cf832a9904867 Mon Sep 17 00:00:00 2001 From: Adnan Hajdarevic Date: Thu, 29 Sep 2016 19:16:47 +0200 Subject: [PATCH 2/2] bump version to 2.5.0 --- webhook.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webhook.go b/webhook.go index e762026..3827db8 100644 --- a/webhook.go +++ b/webhook.go @@ -21,7 +21,7 @@ import ( ) const ( - version = "2.4.0" + version = "2.5.0" ) var (