From 2a2a20dcb8156b2a8925f5e22b9d8ded1a651940 Mon Sep 17 00:00:00 2001 From: Cameron Moore Date: Thu, 19 Mar 2015 11:32:10 -0500 Subject: [PATCH 1/2] Add tests for ExtractParameter --- helpers/helpers_test.go | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 helpers/helpers_test.go diff --git a/helpers/helpers_test.go b/helpers/helpers_test.go new file mode 100644 index 0000000..af25530 --- /dev/null +++ b/helpers/helpers_test.go @@ -0,0 +1,28 @@ +package helpers + +import "testing" + +var extractParameterTests = []struct { + s string + params map[string]interface{} + value string + ok bool +}{ + {"a", map[string]interface{}{"a": "z"}, "z", true}, + {"a.b", map[string]interface{}{"a": map[string]interface{}{"b": "z"}}, "z", true}, + {"a.b.c", map[string]interface{}{"a": map[string]interface{}{"b": map[string]interface{}{"c": "z"}}}, "z", true}, + {"a.1.b", map[string]interface{}{"a": []interface{}{map[string]interface{}{"b": "y"}, map[string]interface{}{"b": "z"}}}, "z", true}, + // failures + {"a.X", map[string]interface{}{"a": map[string]interface{}{"b": "z"}}, "", false}, + {"a.500.b", map[string]interface{}{"a": map[string]interface{}{"b": "z"}}, "", false}, + {"a.501.b", map[string]interface{}{"a": []interface{}{map[string]interface{}{"b": "y"}, map[string]interface{}{"b": "z"}}}, "", false}, +} + +func TestExtractParameter(t *testing.T) { + for _, tt := range extractParameterTests { + s, ok := ExtractParameter(tt.s, tt.params) + if ok != tt.ok || s != tt.value { + t.Errorf("failed to extract parameter %q:\nexpected {value:%#v, ok:%#v},\ngot {value:%#v, ok:%#v}", tt.s, tt.value, tt.ok, s, ok) + } + } +} From 7635cfde33e11b469c05cfeb2baf62e604e75223 Mon Sep 17 00:00:00 2001 From: Cameron Moore Date: Thu, 19 Mar 2015 11:55:24 -0500 Subject: [PATCH 2/2] Add another slice test to ExtractParameter tests --- helpers/helpers_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/helpers/helpers_test.go b/helpers/helpers_test.go index af25530..61a54bb 100644 --- a/helpers/helpers_test.go +++ b/helpers/helpers_test.go @@ -12,6 +12,7 @@ var extractParameterTests = []struct { {"a.b", map[string]interface{}{"a": map[string]interface{}{"b": "z"}}, "z", true}, {"a.b.c", map[string]interface{}{"a": map[string]interface{}{"b": map[string]interface{}{"c": "z"}}}, "z", true}, {"a.1.b", map[string]interface{}{"a": []interface{}{map[string]interface{}{"b": "y"}, map[string]interface{}{"b": "z"}}}, "z", true}, + {"a.1.b.c", map[string]interface{}{"a": []interface{}{map[string]interface{}{"b": map[string]interface{}{"c": "y"}}, map[string]interface{}{"b": map[string]interface{}{"c": "z"}}}}, "z", true}, // failures {"a.X", map[string]interface{}{"a": map[string]interface{}{"b": "z"}}, "", false}, {"a.500.b", map[string]interface{}{"a": map[string]interface{}{"b": "z"}}, "", false},