mirror of
https://github.com/adnanh/webhook.git
synced 2025-07-20 01:20:33 +00:00
eddeb82032
* feat: add ability to listen on unix socket/named pipe Add a -socket option that configures the server to listen on a Unix-domain socket or Windows named pipe instead of a TCP port. This allows webhook to be used behind a reverse proxy on multi-tenant shared hosting without the need to choose (and the permission to bind to) a free port number. On Windows, -socket is expected to be a named pipe such as \\.\pipe\webhook, and the code uses https://github.com/microsoft/go-winio to bind the listening socket. On other platforms, -socket is the path to a Unix domain socket such as /tmp/webhook.sock, or an abstract socket name starting with @, bound using the regular net.Listen function with the "network" parameter set to "unix". Note: this pushes our minimum Go version up to 1.21 as that is what go-winio requires, but that is already the minimum version against which we are testing in the CI matrix. * tests: add test for the -socket option Refactored webhook_test so that the test HTTP requests are made using an explicitly-provided http.Client, so we can run at least one test with the server bound to a socket instead of a port number, using an http.Client whose transport has been configured with a suitable Unix-domain or Windows named pipe dialer function. * tests: use GOROOT to find go command This should ensure that, even if a developer or CI server has multiple versions of go installed, the version used to build the tools under test will be the same version that is running the test harness. * fix: clean up Unix socket file before exit If webhook is restarted with the same settings but the socket file has not been deleted, webhook will be unable to bind and will exit with an error. * docs: add -socket option to documentation * docs: add a note about reverse proxies - README mentions the idea of using webhook behind a reverse proxy, including with the -socket flag - added a note in Hook-Rules that the ip-whitelist rule type does not work as expected behind a reverse proxy, and you should configure IP restrictions at the proxy level instead
147 lines
4.1 KiB
YAML
147 lines
4.1 KiB
YAML
linters:
|
|
enable:
|
|
# style
|
|
- containedctx # struct contains a context
|
|
- dupl # duplicate code
|
|
- errname # erorrs are named correctly
|
|
- nolintlint # "//nolint" directives are properly explained
|
|
- revive # golint replacement
|
|
- unconvert # unnecessary conversions
|
|
- wastedassign
|
|
|
|
# bugs, performance, unused, etc ...
|
|
- contextcheck # function uses a non-inherited context
|
|
- errorlint # errors not wrapped for 1.13
|
|
- exhaustive # check exhaustiveness of enum switch statements
|
|
- gofmt # files are gofmt'ed
|
|
- gosec # security
|
|
- nilerr # returns nil even with non-nil error
|
|
- thelper # test helpers without t.Helper()
|
|
- unparam # unused function params
|
|
|
|
issues:
|
|
exclude-dirs:
|
|
- pkg/etw/sample
|
|
|
|
exclude-rules:
|
|
# err is very often shadowed in nested scopes
|
|
- linters:
|
|
- govet
|
|
text: '^shadow: declaration of "err" shadows declaration'
|
|
|
|
# ignore long lines for skip autogen directives
|
|
- linters:
|
|
- revive
|
|
text: "^line-length-limit: "
|
|
source: "^//(go:generate|sys) "
|
|
|
|
#TODO: remove after upgrading to go1.18
|
|
# ignore comment spacing for nolint and sys directives
|
|
- linters:
|
|
- revive
|
|
text: "^comment-spacings: no space between comment delimiter and comment text"
|
|
source: "//(cspell:|nolint:|sys |todo)"
|
|
|
|
# not on go 1.18 yet, so no any
|
|
- linters:
|
|
- revive
|
|
text: "^use-any: since GO 1.18 'interface{}' can be replaced by 'any'"
|
|
|
|
# allow unjustified ignores of error checks in defer statements
|
|
- linters:
|
|
- nolintlint
|
|
text: "^directive `//nolint:errcheck` should provide explanation"
|
|
source: '^\s*defer '
|
|
|
|
# allow unjustified ignores of error lints for io.EOF
|
|
- linters:
|
|
- nolintlint
|
|
text: "^directive `//nolint:errorlint` should provide explanation"
|
|
source: '[=|!]= io.EOF'
|
|
|
|
|
|
linters-settings:
|
|
exhaustive:
|
|
default-signifies-exhaustive: true
|
|
govet:
|
|
enable-all: true
|
|
disable:
|
|
# struct order is often for Win32 compat
|
|
# also, ignore pointer bytes/GC issues for now until performance becomes an issue
|
|
- fieldalignment
|
|
nolintlint:
|
|
require-explanation: true
|
|
require-specific: true
|
|
revive:
|
|
# revive is more configurable than static check, so likely the preferred alternative to static-check
|
|
# (once the perf issue is solved: https://github.com/golangci/golangci-lint/issues/2997)
|
|
enable-all-rules:
|
|
true
|
|
# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md
|
|
rules:
|
|
# rules with required arguments
|
|
- name: argument-limit
|
|
disabled: true
|
|
- name: banned-characters
|
|
disabled: true
|
|
- name: cognitive-complexity
|
|
disabled: true
|
|
- name: cyclomatic
|
|
disabled: true
|
|
- name: file-header
|
|
disabled: true
|
|
- name: function-length
|
|
disabled: true
|
|
- name: function-result-limit
|
|
disabled: true
|
|
- name: max-public-structs
|
|
disabled: true
|
|
# geneally annoying rules
|
|
- name: add-constant # complains about any and all strings and integers
|
|
disabled: true
|
|
- name: confusing-naming # we frequently use "Foo()" and "foo()" together
|
|
disabled: true
|
|
- name: flag-parameter # excessive, and a common idiom we use
|
|
disabled: true
|
|
- name: unhandled-error # warns over common fmt.Print* and io.Close; rely on errcheck instead
|
|
disabled: true
|
|
# general config
|
|
- name: line-length-limit
|
|
arguments:
|
|
- 140
|
|
- name: var-naming
|
|
arguments:
|
|
- []
|
|
- - CID
|
|
- CRI
|
|
- CTRD
|
|
- DACL
|
|
- DLL
|
|
- DOS
|
|
- ETW
|
|
- FSCTL
|
|
- GCS
|
|
- GMSA
|
|
- HCS
|
|
- HV
|
|
- IO
|
|
- LCOW
|
|
- LDAP
|
|
- LPAC
|
|
- LTSC
|
|
- MMIO
|
|
- NT
|
|
- OCI
|
|
- PMEM
|
|
- PWSH
|
|
- RX
|
|
- SACl
|
|
- SID
|
|
- SMB
|
|
- TX
|
|
- VHD
|
|
- VHDX
|
|
- VMID
|
|
- VPCI
|
|
- WCOW
|
|
- WIM
|