mirror of
https://github.com/adnanh/webhook.git
synced 2025-05-11 08:04:44 +00:00
dd5fa20415
The error returned by exec.LookPath was never surfaced to the user. Without that detail, the user can't tell the difference between a non-existent path and a permissions issue. Additionally, when ExecuteCommand is an absolute path, we were still attempting to prepend the CommandWorkingDirectory if the ExecuteCommand was not found, which made it difficult to know which path the user intended to execute. This commit simplifies the logic to avoid multiple attempts with ExecuteCommand is an absolute path and changes the error message from: error locating command: '/path/to/file' to: error in exec: "/path/to/file": stat /path/to/file: no such file or directory error in exec: "/path/to/file": permission denied Fixes #457
755 lines
20 KiB
Go
755 lines
20 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"log"
|
|
"net"
|
|
"net/http"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
"runtime"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"text/template"
|
|
"time"
|
|
|
|
"github.com/adnanh/webhook/internal/hook"
|
|
)
|
|
|
|
func TestStaticParams(t *testing.T) {
|
|
// FIXME(moorereason): incorporate this test into TestWebhook.
|
|
// Need to be able to execute a binary with a space in the filename.
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("Skipping on Windows")
|
|
}
|
|
|
|
spHeaders := make(map[string]interface{})
|
|
spHeaders["User-Agent"] = "curl/7.54.0"
|
|
spHeaders["Accept"] = "*/*"
|
|
|
|
// case 2: binary with spaces in its name
|
|
err := os.Symlink("/bin/echo", "/tmp/with space")
|
|
if err != nil {
|
|
t.Fatalf("%v", err)
|
|
}
|
|
defer os.Remove("/tmp/with space")
|
|
|
|
spHook := &hook.Hook{
|
|
ID: "static-params-name-space",
|
|
ExecuteCommand: "/tmp/with space",
|
|
CommandWorkingDirectory: "/tmp",
|
|
ResponseMessage: "success",
|
|
CaptureCommandOutput: true,
|
|
PassArgumentsToCommand: []hook.Argument{
|
|
hook.Argument{Source: "string", Name: "passed"},
|
|
},
|
|
}
|
|
|
|
b := &bytes.Buffer{}
|
|
log.SetOutput(b)
|
|
|
|
_, err = handleHook(spHook, "test", &spHeaders, &map[string]interface{}{}, &map[string]interface{}{}, &[]byte{})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
matched, _ := regexp.MatchString("(?s)command output: .*static-params-name-space", b.String())
|
|
if !matched {
|
|
t.Fatalf("Unexpected log output:\n%sn", b)
|
|
}
|
|
}
|
|
|
|
func TestWebhook(t *testing.T) {
|
|
hookecho, cleanupHookecho := buildHookecho(t)
|
|
defer cleanupHookecho()
|
|
|
|
webhook, cleanupWebhookFn := buildWebhook(t)
|
|
defer cleanupWebhookFn()
|
|
|
|
for _, hookTmpl := range []string{"test/hooks.json.tmpl", "test/hooks.yaml.tmpl"} {
|
|
configPath, cleanupConfigFn := genConfig(t, hookecho, hookTmpl)
|
|
defer cleanupConfigFn()
|
|
|
|
for _, tt := range hookHandlerTests {
|
|
t.Run(tt.desc+"@"+hookTmpl, func(t *testing.T) {
|
|
ip, port := serverAddress(t)
|
|
args := []string{fmt.Sprintf("-hooks=%s", configPath), fmt.Sprintf("-ip=%s", ip), fmt.Sprintf("-port=%s", port), "-debug"}
|
|
|
|
if len(tt.cliMethods) != 0 {
|
|
args = append(args, "-http-methods="+strings.Join(tt.cliMethods, ","))
|
|
}
|
|
|
|
// Setup a buffer for capturing webhook logs for later evaluation
|
|
b := &buffer{}
|
|
|
|
cmd := exec.Command(webhook, args...)
|
|
cmd.Stderr = b
|
|
cmd.Env = webhookEnv()
|
|
cmd.Args[0] = "webhook"
|
|
if err := cmd.Start(); err != nil {
|
|
t.Fatalf("failed to start webhook: %s", err)
|
|
}
|
|
defer killAndWait(cmd)
|
|
|
|
waitForServerReady(t, ip, port)
|
|
|
|
url := fmt.Sprintf("http://%s:%s/hooks/%s", ip, port, tt.id)
|
|
|
|
req, err := http.NewRequest(tt.method, url, ioutil.NopCloser(strings.NewReader(tt.body)))
|
|
if err != nil {
|
|
t.Errorf("New request failed: %s", err)
|
|
}
|
|
|
|
for k, v := range tt.headers {
|
|
req.Header.Add(k, v)
|
|
}
|
|
|
|
var res *http.Response
|
|
|
|
req.Header.Add("Content-Type", tt.contentType)
|
|
req.ContentLength = int64(len(tt.body))
|
|
|
|
client := &http.Client{}
|
|
res, err = client.Do(req)
|
|
if err != nil {
|
|
t.Errorf("client.Do failed: %s", err)
|
|
}
|
|
|
|
body, err := ioutil.ReadAll(res.Body)
|
|
res.Body.Close()
|
|
if err != nil {
|
|
t.Errorf("POST %q: failed to ready body: %s", tt.desc, err)
|
|
}
|
|
|
|
if res.StatusCode != tt.respStatus || string(body) != tt.respBody {
|
|
t.Errorf("failed %q (id: %s):\nexpected status: %#v, response: %s\ngot status: %#v, response: %s\ncommand output:\n%s\n", tt.desc, tt.id, tt.respStatus, tt.respBody, res.StatusCode, body, b)
|
|
}
|
|
|
|
if tt.logMatch == "" {
|
|
return
|
|
}
|
|
|
|
// There's the potential for a race condition below where we
|
|
// try to read the logs buffer b before the logs have been
|
|
// flushed by the webhook process. Kill the process to flush
|
|
// the logs.
|
|
killAndWait(cmd)
|
|
|
|
matched, _ := regexp.MatchString(tt.logMatch, b.String())
|
|
if !matched {
|
|
t.Errorf("failed log match for %q (id: %s):\nmatch pattern: %q\ngot:\n%s", tt.desc, tt.id, tt.logMatch, b)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
func buildHookecho(t *testing.T) (binPath string, cleanupFn func()) {
|
|
tmp, err := ioutil.TempDir("", "hookecho-test-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() {
|
|
if cleanupFn == nil {
|
|
os.RemoveAll(tmp)
|
|
}
|
|
}()
|
|
|
|
binPath = filepath.Join(tmp, "hookecho")
|
|
if runtime.GOOS == "windows" {
|
|
binPath += ".exe"
|
|
}
|
|
|
|
cmd := exec.Command("go", "build", "-o", binPath, "test/hookecho.go")
|
|
if err := cmd.Run(); err != nil {
|
|
t.Fatalf("Building hookecho: %v", err)
|
|
}
|
|
|
|
return binPath, func() { os.RemoveAll(tmp) }
|
|
}
|
|
|
|
func genConfig(t *testing.T, bin, hookTemplate string) (configPath string, cleanupFn func()) {
|
|
tmpl := template.Must(template.ParseFiles(hookTemplate))
|
|
|
|
tmp, err := ioutil.TempDir("", "webhook-config-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() {
|
|
if cleanupFn == nil {
|
|
os.RemoveAll(tmp)
|
|
}
|
|
}()
|
|
|
|
outputBaseName := filepath.Ext(filepath.Ext(hookTemplate))
|
|
|
|
path := filepath.Join(tmp, outputBaseName)
|
|
file, err := os.Create(path)
|
|
if err != nil {
|
|
t.Fatalf("Creating config template: %v", err)
|
|
}
|
|
defer file.Close()
|
|
|
|
data := struct{ Hookecho string }{filepath.FromSlash(bin)}
|
|
if runtime.GOOS == "windows" {
|
|
// Simulate escaped backslashes on Windows.
|
|
data.Hookecho = strings.Replace(data.Hookecho, `\`, `\\`, -1)
|
|
}
|
|
if err := tmpl.Execute(file, data); err != nil {
|
|
t.Fatalf("Executing template: %v", err)
|
|
}
|
|
|
|
return path, func() { os.RemoveAll(tmp) }
|
|
}
|
|
|
|
func buildWebhook(t *testing.T) (binPath string, cleanupFn func()) {
|
|
tmp, err := ioutil.TempDir("", "webhook-test-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() {
|
|
if cleanupFn == nil {
|
|
os.RemoveAll(tmp)
|
|
}
|
|
}()
|
|
|
|
binPath = filepath.Join(tmp, "webhook")
|
|
if runtime.GOOS == "windows" {
|
|
binPath += ".exe"
|
|
}
|
|
|
|
cmd := exec.Command("go", "build", "-o", binPath)
|
|
if err := cmd.Run(); err != nil {
|
|
t.Fatalf("Building webhook: %v", err)
|
|
}
|
|
|
|
return binPath, func() { os.RemoveAll(tmp) }
|
|
}
|
|
|
|
func serverAddress(t *testing.T) (string, string) {
|
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
ln, err = net.Listen("tcp6", "[::1]:0")
|
|
}
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer ln.Close()
|
|
host, port, err := net.SplitHostPort(ln.Addr().String())
|
|
if err != nil {
|
|
t.Fatalf("Failed to split network address: %v", err)
|
|
}
|
|
return host, port
|
|
}
|
|
|
|
func waitForServerReady(t *testing.T, ip, port string) {
|
|
waitForServer(t,
|
|
fmt.Sprintf("http://%v:%v/", ip, port),
|
|
http.StatusOK,
|
|
5*time.Second)
|
|
}
|
|
|
|
const pollInterval = 200 * time.Millisecond
|
|
|
|
func waitForServer(t *testing.T, url string, status int, timeout time.Duration) {
|
|
deadline := time.Now().Add(timeout)
|
|
for time.Now().Before(deadline) {
|
|
time.Sleep(pollInterval)
|
|
res, err := http.Get(url)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
if res.StatusCode == status {
|
|
return
|
|
}
|
|
}
|
|
t.Fatalf("Server failed to respond in %v", timeout)
|
|
}
|
|
|
|
func killAndWait(cmd *exec.Cmd) {
|
|
if cmd == nil || cmd.ProcessState != nil && cmd.ProcessState.Exited() {
|
|
return
|
|
}
|
|
|
|
cmd.Process.Kill()
|
|
cmd.Wait()
|
|
}
|
|
|
|
// webhookEnv returns the process environment without any existing hook
|
|
// namespace variables.
|
|
func webhookEnv() (env []string) {
|
|
for _, v := range os.Environ() {
|
|
if strings.HasPrefix(v, hook.EnvNamespace) {
|
|
continue
|
|
}
|
|
env = append(env, v)
|
|
}
|
|
return
|
|
}
|
|
|
|
var hookHandlerTests = []struct {
|
|
desc string
|
|
id string
|
|
cliMethods []string
|
|
method string
|
|
headers map[string]string
|
|
contentType string
|
|
body string
|
|
|
|
respStatus int
|
|
respBody string
|
|
logMatch string
|
|
}{
|
|
{
|
|
"github",
|
|
"github",
|
|
nil,
|
|
"POST",
|
|
map[string]string{"X-Hub-Signature": "f68df0375d7b03e3eb29b4cf9f9ec12e08f42ff8"},
|
|
"application/json",
|
|
`{
|
|
"after":"1481a2de7b2a7d02428ad93446ab166be7793fbb",
|
|
"before":"17c497ccc7cca9c2f735aa07e9e3813060ce9a6a",
|
|
"commits":[
|
|
{
|
|
"added":[
|
|
|
|
],
|
|
"author":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"committer":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"distinct":true,
|
|
"id":"c441029cf673f84c8b7db52d0a5944ee5c52ff89",
|
|
"message":"Test",
|
|
"modified":[
|
|
"README.md"
|
|
],
|
|
"removed":[
|
|
|
|
],
|
|
"timestamp":"2013-02-22T13:50:07-08:00",
|
|
"url":"https://github.com/octokitty/testing/commit/c441029cf673f84c8b7db52d0a5944ee5c52ff89"
|
|
},
|
|
{
|
|
"added":[
|
|
|
|
],
|
|
"author":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"committer":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"distinct":true,
|
|
"id":"36c5f2243ed24de58284a96f2a643bed8c028658",
|
|
"message":"This is me testing the windows client.",
|
|
"modified":[
|
|
"README.md"
|
|
],
|
|
"removed":[
|
|
|
|
],
|
|
"timestamp":"2013-02-22T14:07:13-08:00",
|
|
"url":"https://github.com/octokitty/testing/commit/36c5f2243ed24de58284a96f2a643bed8c028658"
|
|
},
|
|
{
|
|
"added":[
|
|
"words/madame-bovary.txt"
|
|
],
|
|
"author":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"committer":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"distinct":true,
|
|
"id":"1481a2de7b2a7d02428ad93446ab166be7793fbb",
|
|
"message":"Rename madame-bovary.txt to words/madame-bovary.txt",
|
|
"modified":[
|
|
|
|
],
|
|
"removed":[
|
|
"madame-bovary.txt"
|
|
],
|
|
"timestamp":"2013-03-12T08:14:29-07:00",
|
|
"url":"https://github.com/octokitty/testing/commit/1481a2de7b2a7d02428ad93446ab166be7793fbb"
|
|
}
|
|
],
|
|
"compare":"https://github.com/octokitty/testing/compare/17c497ccc7cc...1481a2de7b2a",
|
|
"created":false,
|
|
"deleted":false,
|
|
"forced":false,
|
|
"head_commit":{
|
|
"added":[
|
|
"words/madame-bovary.txt"
|
|
],
|
|
"author":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"committer":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"distinct":true,
|
|
"id":"1481a2de7b2a7d02428ad93446ab166be7793fbb",
|
|
"message":"Rename madame-bovary.txt to words/madame-bovary.txt",
|
|
"modified":[
|
|
|
|
],
|
|
"removed":[
|
|
"madame-bovary.txt"
|
|
],
|
|
"timestamp":"2013-03-12T08:14:29-07:00",
|
|
"url":"https://github.com/octokitty/testing/commit/1481a2de7b2a7d02428ad93446ab166be7793fbb"
|
|
},
|
|
"pusher":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian"
|
|
},
|
|
"ref":"refs/heads/master",
|
|
"repository":{
|
|
"created_at":1332977768,
|
|
"description":"",
|
|
"fork":false,
|
|
"forks":0,
|
|
"has_downloads":true,
|
|
"has_issues":true,
|
|
"has_wiki":true,
|
|
"homepage":"",
|
|
"id":3860742,
|
|
"language":"Ruby",
|
|
"master_branch":"master",
|
|
"name":"testing",
|
|
"open_issues":2,
|
|
"owner":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"octokitty"
|
|
},
|
|
"private":false,
|
|
"pushed_at":1363295520,
|
|
"size":2156,
|
|
"stargazers":1,
|
|
"url":"https://github.com/octokitty/testing",
|
|
"watchers":1
|
|
}
|
|
}`,
|
|
http.StatusOK,
|
|
`arg: 1481a2de7b2a7d02428ad93446ab166be7793fbb lolwut@noway.biz
|
|
env: HOOK_head_commit.timestamp=2013-03-12T08:14:29-07:00
|
|
`,
|
|
``,
|
|
},
|
|
{
|
|
"bitbucket", // bitbucket sends their payload using uriencoded params.
|
|
"bitbucket",
|
|
nil,
|
|
"POST",
|
|
nil,
|
|
"application/x-www-form-urlencoded",
|
|
`payload={"canon_url": "https://bitbucket.org","commits": [{"author": "marcus","branch": "master","files": [{"file": "somefile.py","type": "modified"}],"message": "Added some more things to somefile.py\n","node": "620ade18607a","parents": ["702c70160afc"],"raw_author": "Marcus Bertrand <marcus@somedomain.com>","raw_node": "620ade18607ac42d872b568bb92acaa9a28620e9","revision": null,"size": -1,"timestamp": "2012-05-30 05:58:56","utctimestamp": "2014-11-07 15:19:02+00:00"}],"repository": {"absolute_url": "/webhook/testing/","fork": false,"is_private": true,"name": "Project X","owner": "marcus","scm": "git","slug": "project-x","website": "https://atlassian.com/"},"user": "marcus"}`,
|
|
http.StatusOK,
|
|
`success`,
|
|
``,
|
|
},
|
|
{
|
|
"gitlab",
|
|
"gitlab",
|
|
nil,
|
|
"POST",
|
|
map[string]string{"X-Gitlab-Event": "Push Hook"},
|
|
"application/json",
|
|
`{
|
|
"object_kind": "push",
|
|
"before": "95790bf891e76fee5e1747ab589903a6a1f80f22",
|
|
"after": "da1560886d4f094c3e6c9ef40349f7d38b5d27d7",
|
|
"ref": "refs/heads/master",
|
|
"user_id": 4,
|
|
"user_name": "John Smith",
|
|
"user_email": "john@example.com",
|
|
"project_id": 15,
|
|
"repository": {
|
|
"name": "Diaspora",
|
|
"url": "git@example.com:mike/diasporadiaspora.git",
|
|
"description": "",
|
|
"homepage": "http://example.com/mike/diaspora",
|
|
"git_http_url":"http://example.com/mike/diaspora.git",
|
|
"git_ssh_url":"git@example.com:mike/diaspora.git",
|
|
"visibility_level":0
|
|
},
|
|
"commits": [
|
|
{
|
|
"id": "b6568db1bc1dcd7f8b4d5a946b0b91f9dacd7327",
|
|
"message": "Update Catalan translation to e38cb41.",
|
|
"timestamp": "2011-12-12T14:27:31+02:00",
|
|
"url": "http://example.com/mike/diaspora/commit/b6568db1bc1dcd7f8b4d5a946b0b91f9dacd7327",
|
|
"author": {
|
|
"name": "Jordi Mallach",
|
|
"email": "jordi@softcatala.org"
|
|
}
|
|
},
|
|
{
|
|
"id": "da1560886d4f094c3e6c9ef40349f7d38b5d27d7",
|
|
"message": "fixed readme",
|
|
"timestamp": "2012-01-03T23:36:29+02:00",
|
|
"url": "http://example.com/mike/diaspora/commit/da1560886d4f094c3e6c9ef40349f7d38b5d27d7",
|
|
"author": {
|
|
"name": "GitLab dev user",
|
|
"email": "gitlabdev@dv6700.(none)"
|
|
}
|
|
}
|
|
],
|
|
"total_commits_count": 4
|
|
}`,
|
|
http.StatusOK,
|
|
`arg: b6568db1bc1dcd7f8b4d5a946b0b91f9dacd7327 John Smith john@example.com
|
|
`,
|
|
``,
|
|
},
|
|
{
|
|
"xml",
|
|
"xml",
|
|
nil,
|
|
"POST",
|
|
map[string]string{"Content-Type": "application/xml"},
|
|
"application/xml",
|
|
`<app>
|
|
<users>
|
|
<user id="1" name="Jeff" />
|
|
<user id="2" name="Sally" />
|
|
</users>
|
|
<messages>
|
|
<message id="1" from_user="1" to_user="2">Hello!!</message>
|
|
</messages>
|
|
</app>`,
|
|
http.StatusOK,
|
|
`success`,
|
|
``,
|
|
},
|
|
{
|
|
"payload-json-array",
|
|
"sendgrid",
|
|
nil,
|
|
"POST",
|
|
nil,
|
|
"application/json",
|
|
`[
|
|
{
|
|
"email": "example@test.com",
|
|
"timestamp": 1513299569,
|
|
"smtp-id": "<14c5d75ce93.dfd.64b469@ismtpd-555>",
|
|
"event": "processed",
|
|
"category": "cat facts",
|
|
"sg_event_id": "sg_event_id",
|
|
"sg_message_id": "sg_message_id"
|
|
}
|
|
]`,
|
|
http.StatusOK,
|
|
`success`,
|
|
``,
|
|
},
|
|
{
|
|
"multipart",
|
|
"plex",
|
|
nil,
|
|
"POST",
|
|
nil,
|
|
"multipart/form-data; boundary=xxx",
|
|
`--xxx
|
|
Content-Disposition: form-data; name="payload"
|
|
|
|
{
|
|
"event": "media.play",
|
|
"user": true,
|
|
"owner": true,
|
|
"Account": {
|
|
"id": 1,
|
|
"thumb": "https://plex.tv/users/1022b120ffbaa/avatar?c=1465525047",
|
|
"title": "elan"
|
|
}
|
|
}
|
|
|
|
--xxx
|
|
Content-Disposition: form-data; name="thumb"; filename="thumb.jpg"
|
|
Content-Type: application/octet-stream
|
|
Content-Transfer-Encoding: binary
|
|
|
|
binary data
|
|
--xxx--`,
|
|
http.StatusOK,
|
|
`success`,
|
|
``,
|
|
},
|
|
|
|
{
|
|
"missing-cmd-arg", // missing head_commit.author.email
|
|
"github",
|
|
nil,
|
|
"POST",
|
|
map[string]string{"X-Hub-Signature": "ab03955b9377f530aa298b1b6d273ae9a47e1e40"},
|
|
"application/json",
|
|
`{
|
|
"head_commit":{
|
|
"added":[
|
|
"words/madame-bovary.txt"
|
|
],
|
|
"author":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"committer":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"distinct":true,
|
|
"id":"1481a2de7b2a7d02428ad93446ab166be7793fbb",
|
|
"message":"Rename madame-bovary.txt to words/madame-bovary.txt",
|
|
"modified":[
|
|
|
|
],
|
|
"removed":[
|
|
"madame-bovary.txt"
|
|
],
|
|
"timestamp":"2013-03-12T08:14:29-07:00",
|
|
"url":"https://github.com/octokitty/testing/commit/1481a2de7b2a7d02428ad93446ab166be7793fbb"
|
|
},
|
|
"ref":"refs/heads/master"
|
|
}`,
|
|
http.StatusOK,
|
|
`arg: 1481a2de7b2a7d02428ad93446ab166be7793fbb lolwut@noway.biz
|
|
env: HOOK_head_commit.timestamp=2013-03-12T08:14:29-07:00
|
|
`,
|
|
``,
|
|
},
|
|
|
|
{
|
|
"missing-env-arg", // missing head_commit.timestamp
|
|
"github",
|
|
nil,
|
|
"POST",
|
|
map[string]string{"X-Hub-Signature": "2cf8b878cb6b74a25090a140fa4a474be04b97fa"},
|
|
"application/json",
|
|
`{
|
|
"head_commit":{
|
|
"added":[
|
|
"words/madame-bovary.txt"
|
|
],
|
|
"author":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"committer":{
|
|
"email":"lolwut@noway.biz",
|
|
"name":"Garen Torikian",
|
|
"username":"octokitty"
|
|
},
|
|
"distinct":true,
|
|
"id":"1481a2de7b2a7d02428ad93446ab166be7793fbb",
|
|
"message":"Rename madame-bovary.txt to words/madame-bovary.txt",
|
|
"modified":[
|
|
|
|
],
|
|
"removed":[
|
|
"madame-bovary.txt"
|
|
],
|
|
"url":"https://github.com/octokitty/testing/commit/1481a2de7b2a7d02428ad93446ab166be7793fbb"
|
|
},
|
|
"ref":"refs/heads/master"
|
|
}`,
|
|
http.StatusOK,
|
|
`arg: 1481a2de7b2a7d02428ad93446ab166be7793fbb lolwut@noway.biz
|
|
`,
|
|
``,
|
|
},
|
|
|
|
{
|
|
"empty-payload-signature", // allow empty payload signature validation
|
|
"empty-payload-signature",
|
|
nil,
|
|
"POST",
|
|
map[string]string{"X-Hub-Signature": "33f9d709782f62b8b4a0178586c65ab098a39fe2"},
|
|
"application/json",
|
|
``,
|
|
http.StatusOK,
|
|
``,
|
|
``,
|
|
},
|
|
|
|
// test with disallowed global HTTP method
|
|
{"global disallowed method", "bitbucket", []string{"Post "}, "GET", nil, `{}`, "application/json", http.StatusMethodNotAllowed, ``, ``},
|
|
// test with disallowed HTTP method
|
|
{"disallowed method", "github", nil, "Get", nil, `{}`, "application/json", http.StatusMethodNotAllowed, ``, ``},
|
|
// test with custom return code
|
|
{"empty payload", "github", nil, "POST", nil, "application/json", `{}`, http.StatusBadRequest, `Hook rules were not satisfied.`, ``},
|
|
// test with custom invalid http code, should default to 200 OK
|
|
{"empty payload", "bitbucket", nil, "POST", nil, "application/json", `{}`, http.StatusOK, `Hook rules were not satisfied.`, ``},
|
|
// test with no configured http return code, should default to 200 OK
|
|
{"empty payload", "gitlab", nil, "POST", nil, "application/json", `{}`, http.StatusOK, `Hook rules were not satisfied.`, ``},
|
|
|
|
// test capturing command output
|
|
{"don't capture output on success by default", "capture-command-output-on-success-not-by-default", nil, "POST", nil, "application/json", `{}`, http.StatusOK, ``, ``},
|
|
{"capture output on success with flag set", "capture-command-output-on-success-yes-with-flag", nil, "POST", nil, "application/json", `{}`, http.StatusOK, `arg: exit=0
|
|
`, ``},
|
|
{"don't capture output on error by default", "capture-command-output-on-error-not-by-default", nil, "POST", nil, "application/json", `{}`, http.StatusInternalServerError, `Error occurred while executing the hook's command. Please check your logs for more details.`, ``},
|
|
{"capture output on error with extra flag set", "capture-command-output-on-error-yes-with-extra-flag", nil, "POST", nil, "application/json", `{}`, http.StatusInternalServerError, `arg: exit=1
|
|
`, ``},
|
|
|
|
// Check logs
|
|
{"static params should pass", "static-params-ok", nil, "POST", nil, "application/json", `{}`, http.StatusOK, "arg: passed\n", `(?s)command output: arg: passed`},
|
|
{"command with space logs warning", "warn-on-space", nil, "POST", nil, "application/json", `{}`, http.StatusInternalServerError, "Error occurred while executing the hook's command. Please check your logs for more details.", `(?s)error in exec:.*use 'pass[-]arguments[-]to[-]command' to specify args`},
|
|
{"unsupported content type error", "github", nil, "POST", map[string]string{"Content-Type": "nonexistent/format"}, "application/json", `{}`, http.StatusBadRequest, `Hook rules were not satisfied.`, `(?s)error parsing body payload due to unsupported content type header:`},
|
|
}
|
|
|
|
// buffer provides a concurrency-safe bytes.Buffer to tests above.
|
|
type buffer struct {
|
|
b bytes.Buffer
|
|
m sync.Mutex
|
|
}
|
|
|
|
func (b *buffer) Read(p []byte) (n int, err error) {
|
|
b.m.Lock()
|
|
defer b.m.Unlock()
|
|
return b.b.Read(p)
|
|
}
|
|
|
|
func (b *buffer) Write(p []byte) (n int, err error) {
|
|
b.m.Lock()
|
|
defer b.m.Unlock()
|
|
return b.b.Write(p)
|
|
}
|
|
|
|
func (b *buffer) String() string {
|
|
b.m.Lock()
|
|
defer b.m.Unlock()
|
|
return b.b.String()
|
|
}
|
|
|
|
func (b *buffer) Reset() {
|
|
b.m.Lock()
|
|
defer b.m.Unlock()
|
|
b.b.Reset()
|
|
}
|