thdltools/Jskad
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes bug 624133, "Input freezes after impossible character". Try 'shsM' in

Browse source 
ACIP or 'ShSm' in Extended Wylie to see the new behavior.

We use a trie to store valid input sequences.  In the future, we could use
the same trie as a replacement for the more inefficient HashSets we use to
store characters, vowels, and punctuation.  For example, we'd use
'validInputSequences.put("K", new Pair("consonant", "k"))' when reading
in the ACIP keyboard's description of the first consonant of the Tibetan
alphabet in 'TibetanKeyboard.java'.

Note that the current trie implementation is only useful for 7- or 8-bit
transcription systems, and works best for tries with low average depth, which
describes a transcription system's trie very well.  If you used arbitrary
Unicode in your keyboard, you'd need a different trie implementation.

Improved the optional keyboard input mode status messages.
This commit is contained in:
dchandler 2002-11-02 18:44:24 +00:00
parent 92fd1bf0b6
commit de6ae79959
4 changed files with 183 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

31
source/org/thdl/tib/text/TibetanKeyboard.java
View file

@ -23,6 +23,8 @@ import java.io.*;
import java.lang.*;
import java.net.URL;
import org.thdl.util.Trie;
/**
* An alternate (non-Extended Wylie) keyboard input
* method. A keyboard URL is passed to its constructor. This URL
@ -43,6 +45,11 @@ import java.net.URL;
* @version 1.0
*/
public class TibetanKeyboard {
/** This addresses bug 624133, "Input freezes after impossible
character". We store all valid input sequences here. */
private Trie validInputSequences;
private boolean hasDisambiguatingKey;
private char disambiguatingKey;
private boolean hasSanskritStackingKey;
@ -68,6 +75,9 @@ public class TibetanKeyboard {
public class InvalidKeyboardException extends Exception {
}
/** Do not call this. */
private TibetanKeyboard() { }
/**
* Opens the URL specified by the parameter,
* and tries to construct a keyboard from it. If the file is
@ -89,6 +99,7 @@ public class TibetanKeyboard {
charMap = new HashMap();
vowelMap = new HashMap();
puncMap = new HashMap();
validInputSequences = new Trie();
command = NO_COMMAND;
@ -176,6 +187,7 @@ public class TibetanKeyboard {
break;
charMap.put(right, left);
validInputSequences.put(right, left);
break;
case VOWELS:
@ -186,6 +198,7 @@ public class TibetanKeyboard {
break;
vowelMap.put(right, left);
validInputSequences.put(right, left);
break;
case PUNCTUATION:
@ -196,6 +209,7 @@ public class TibetanKeyboard {
break;
puncMap.put(right, left);
validInputSequences.put(right, left);
break;
}
}
@ -298,14 +312,14 @@ public class TibetanKeyboard {
}
/**
* Decides whether or not a string is a character in this keyboard.
* Decides whether or not a string is a character (as opposed to a
* vowel or punctuation) in this keyboard.
* @return true if the parameter is a character
* in this keyboard. This method checks to see
* if the passed string has been mapped to a
* Wylie character - if not, then it returns false.
*
* @param s the possible character
*/
* @param s the possible character */
public boolean isChar(String s) {
if (charMap.containsKey(s))
return true;
@ -388,4 +402,15 @@ public class TibetanKeyboard {
return (String)vowelMap.get(s);
}
/** This addresses bug 624133, "Input freezes after impossible
* character". Returns true iff s is a proper prefix of some
* legal input for this keyboard. In the extended Wylie
* keyboard, hasInputPrefix("S") is true because "Sh" is legal
* input. hasInputPrefix("Sh") is false because though "Sh" is
* legal input, ("Sh" + y) is not valid input for any non-empty
* String y. */
public boolean hasInputPrefix(String s) {
return validInputSequences.hasPrefix(s);
}
}