From 050ac0134cc7d79f875bd54504324f2c6444bbc5 Mon Sep 17 00:00:00 2001 From: dubtraxis Date: Sat, 18 Oct 2003 15:16:40 +0000 Subject: [PATCH] Fixed broken SQL statement in ThdlUserRepository to select a single user role per user/application --- src/java/org/thdl/users/ThdlUserRepository.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/java/org/thdl/users/ThdlUserRepository.java b/src/java/org/thdl/users/ThdlUserRepository.java index 6fb58b6..a5a047b 100644 --- a/src/java/org/thdl/users/ThdlUserRepository.java +++ b/src/java/org/thdl/users/ThdlUserRepository.java @@ -118,12 +118,11 @@ public class ThdlUserRepository { ThdlUser thdlUser = validate( user ); - String sql = "SELECT UserRolesForApplication.roles " - + "FROM UserRolesForApplication, Applications " - + "LEFT JOIN UserRolesForApplication AS urfa ON urfa.applicationId = Applications.id " - + "WHERE Applications.application = '" + application + "'" + String sql = "SELECT urfa.roles " + + "FROM UserRolesForApplication AS urfa, Applications AS apps " + + "WHERE urfa.applicationId = apps.id " + + "AND apps.application = '" + application + "' " + "AND urfa.userId = " + thdlUser.getId() + " "; - try { Statement stmt = getConnection().createStatement();