Merge pull request #586 from stevvooe/dist-grpc-connect

cmd/dist: add global connect-timeout for GRPC

cmd/dist/common.go

@@ -24,7 +24,9 @@ func resolveContentStore(context *cli.Context) (*content.Store, error) {
 
 func connectGRPC(context *cli.Context) (*grpc.ClientConn, error) {
 	socket := context.GlobalString("socket")
+	timeout := context.GlobalDuration("connect-timeout")
 	return grpc.Dial(socket,
+		grpc.WithTimeout(timeout),
 		grpc.WithBlock(),
 		grpc.WithInsecure(),
 		grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) {

cmd/dist/fetch.go

@@ -39,7 +39,7 @@ var fetchCommand = cli.Command{
 	},
 	Action: func(context *cli.Context) error {
 		var (
-			ctx     = contextpkg.Background()
+			ctx     = background
 			timeout = context.Duration("timeout")
 			locator = context.Args().First()
 			args    = context.Args().Tail()

cmd/dist/main.go

@@ -40,9 +40,12 @@ distribution tool
 			Usage: "enable debug output in logs",
 		},
 		cli.DurationFlag{
-			Name:   "timeout",
+			Name:  "timeout",
-			Usage:  "total timeout for fetch",
+			Usage: "total timeout for dist commands",
-			EnvVar: "CONTAINERD_FETCH_TIMEOUT",
+		},
+		cli.DurationFlag{
+			Name:  "connect-timeout",
+			Usage: "timeout for connecting to containerd",
 		},
 		cli.StringFlag{
 			// TODO(stevvooe): for now, we allow circumventing the GRPC. Once