From e55ebadb090fac00a701842ff53efad31b63ae7f Mon Sep 17 00:00:00 2001 From: Alexander Morozov Date: Tue, 5 Jan 2016 13:07:36 -0800 Subject: [PATCH] Revert "Use protoversion for containerd version" This reverts commit d2e319523d15bab57432969688b5f419ec76bc54. Signed-off-by: Alexander Morozov --- containerd/main.go | 13 +------------ ctr/container.go | 6 +----- ctr/main.go | 3 +-- ctr/version.go | 22 ---------------------- version.go | 8 +------- 5 files changed, 4 insertions(+), 48 deletions(-) delete mode 100644 ctr/version.go diff --git a/containerd/main.go b/containerd/main.go index d09a406..6b2d640 100644 --- a/containerd/main.go +++ b/containerd/main.go @@ -9,8 +9,6 @@ import ( "syscall" "time" - "go.pedge.io/proto/version" - "google.golang.org/grpc" "github.com/Sirupsen/logrus" @@ -80,7 +78,7 @@ var daemonFlags = []cli.Flag{ func main() { app := cli.NewApp() app.Name = "containerd" - app.Version = containerd.Version.VersionString() + app.Version = containerd.Version app.Usage = Usage app.Authors = authors app.Flags = daemonFlags @@ -217,15 +215,6 @@ func daemon(id, address, stateDir string, concurrency int, oom bool) error { } s := grpc.NewServer() types.RegisterAPIServer(s, server.NewServer(sv)) - protoversion.RegisterAPIServer( - s, - protoversion.NewAPIServer( - containerd.Version, - protoversion.APIServerOptions{ - DisableLogging: true, - }, - ), - ) logrus.Debugf("GRPC API listen on %s", address) return s.Serve(l) } diff --git a/ctr/container.go b/ctr/container.go index ae164a3..8b0758f 100644 --- a/ctr/container.go +++ b/ctr/container.go @@ -23,10 +23,6 @@ import ( // TODO: parse flags and pass opts func getClient(ctx *cli.Context) types.APIClient { - return types.NewAPIClient(getClientConn(ctx)) -} - -func getClientConn(ctx *cli.Context) *grpc.ClientConn { dialOpts := []grpc.DialOption{grpc.WithInsecure()} dialOpts = append(dialOpts, grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) { @@ -37,7 +33,7 @@ func getClientConn(ctx *cli.Context) *grpc.ClientConn { if err != nil { fatal(err.Error(), 1) } - return conn + return types.NewAPIClient(conn) } var ContainersCommand = cli.Command{ diff --git a/ctr/main.go b/ctr/main.go index cf83789..aa0a3e3 100644 --- a/ctr/main.go +++ b/ctr/main.go @@ -14,7 +14,7 @@ const Usage = `High performance container daemon cli` func main() { app := cli.NewApp() app.Name = "ctr" - app.Version = containerd.Version.VersionString() + app.Version = containerd.Version app.Usage = Usage app.Authors = []cli.Author{ { @@ -37,7 +37,6 @@ func main() { CheckpointCommand, ContainersCommand, EventsCommand, - VersionCommand, } app.Before = func(context *cli.Context) error { if context.GlobalBool("debug") { diff --git a/ctr/version.go b/ctr/version.go deleted file mode 100644 index f6f3c3b..0000000 --- a/ctr/version.go +++ /dev/null @@ -1,22 +0,0 @@ -package main - -import ( - "fmt" - - "go.pedge.io/proto/version" - - "github.com/codegangsta/cli" - "github.com/docker/containerd" -) - -var VersionCommand = cli.Command{ - Name: "version", - Usage: "get the containerd version", - Action: func(context *cli.Context) { - serverVersion, err := protoversion.GetServerVersion(getClientConn(context)) - if err != nil { - fatal(err.Error(), 1) - } - fmt.Printf("Client: %s\nServer: %s\n", containerd.Version.VersionString(), serverVersion.VersionString()) - }, -} diff --git a/version.go b/version.go index db894d6..b741b19 100644 --- a/version.go +++ b/version.go @@ -1,9 +1,3 @@ package containerd -import "go.pedge.io/proto/version" - -var Version = &protoversion.Version{ - Major: 0, - Minor: 0, - Micro: 4, -} +const Version = "0.0.4"