621164bc84
After iterating on the GRPC API, the changes required for the actual implementation are now included in the content store. The begin change is the move to a single, atomic `Ingester.Writer` method for locking content ingestion on a key. From this, comes several new interface definitions. The main benefit here is the clarification between `Status` and `Info` that came out of the GPRC API. `Status` tells the status of a write, whereas `Info` is for querying metadata about various blobs. Signed-off-by: Stephen J Day <stephen.day@docker.com>
56 lines
1.1 KiB
Go
56 lines
1.1 KiB
Go
package content
|
|
|
|
import (
|
|
"sync"
|
|
|
|
"github.com/nightlyone/lockfile"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// In addition to providing inter-process locks for content ingest, we also
|
|
// define a global in process lock to prevent two goroutines writing to the
|
|
// same file.
|
|
//
|
|
// This is pretty unsophisticated for now. In the future, we'd probably like to
|
|
// have more information about who is holding which locks, as well as better
|
|
// error reporting.
|
|
|
|
var (
|
|
errLocked = errors.New("key is locked")
|
|
|
|
// locks lets us lock in process, as well as output of process.
|
|
locks = map[lockfile.Lockfile]struct{}{}
|
|
locksMu sync.Mutex
|
|
)
|
|
|
|
func tryLock(lock lockfile.Lockfile) error {
|
|
locksMu.Lock()
|
|
defer locksMu.Unlock()
|
|
|
|
if _, ok := locks[lock]; ok {
|
|
return errLocked
|
|
}
|
|
|
|
if err := lock.TryLock(); err != nil {
|
|
if errors.Cause(err) == lockfile.ErrBusy {
|
|
return errLocked
|
|
}
|
|
|
|
return errors.Wrapf(err, "lock.TryLock() encountered an error")
|
|
}
|
|
|
|
locks[lock] = struct{}{}
|
|
return nil
|
|
}
|
|
|
|
func unlock(lock lockfile.Lockfile) error {
|
|
locksMu.Lock()
|
|
defer locksMu.Unlock()
|
|
|
|
if _, ok := locks[lock]; !ok {
|
|
return nil
|
|
}
|
|
|
|
delete(locks, lock)
|
|
return lock.Unlock()
|
|
}
|