2017-06-15 22:03:43 +00:00
|
|
|
/*
|
|
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package feature
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"sort"
|
|
|
|
"strconv"
|
|
|
|
"strings"
|
2017-09-26 14:23:09 +00:00
|
|
|
"sync"
|
2017-11-13 10:33:25 +00:00
|
|
|
"sync/atomic"
|
2017-06-15 22:03:43 +00:00
|
|
|
|
|
|
|
"github.com/golang/glog"
|
|
|
|
"github.com/spf13/pflag"
|
|
|
|
)
|
|
|
|
|
|
|
|
type Feature string
|
|
|
|
|
|
|
|
const (
|
|
|
|
flagName = "feature-gates"
|
|
|
|
|
|
|
|
// allAlphaGate is a global toggle for alpha features. Per-feature key
|
|
|
|
// values override the default set by allAlphaGate. Examples:
|
|
|
|
// AllAlpha=false,NewFeature=true will result in newFeature=true
|
|
|
|
// AllAlpha=true,NewFeature=false will result in newFeature=false
|
|
|
|
allAlphaGate Feature = "AllAlpha"
|
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
|
|
|
// The generic features.
|
|
|
|
defaultFeatures = map[Feature]FeatureSpec{
|
|
|
|
allAlphaGate: {Default: false, PreRelease: Alpha},
|
|
|
|
}
|
|
|
|
|
|
|
|
// Special handling for a few gates.
|
2017-11-13 10:33:25 +00:00
|
|
|
specialFeatures = map[Feature]func(known map[Feature]FeatureSpec, enabled map[Feature]bool, val bool){
|
2017-06-15 22:03:43 +00:00
|
|
|
allAlphaGate: setUnsetAlphaGates,
|
|
|
|
}
|
|
|
|
|
|
|
|
// DefaultFeatureGate is a shared global FeatureGate.
|
|
|
|
DefaultFeatureGate FeatureGate = NewFeatureGate()
|
|
|
|
)
|
|
|
|
|
|
|
|
type FeatureSpec struct {
|
|
|
|
Default bool
|
|
|
|
PreRelease prerelease
|
|
|
|
}
|
|
|
|
|
|
|
|
type prerelease string
|
|
|
|
|
|
|
|
const (
|
|
|
|
// Values for PreRelease.
|
|
|
|
Alpha = prerelease("ALPHA")
|
|
|
|
Beta = prerelease("BETA")
|
|
|
|
GA = prerelease("")
|
2018-02-12 20:13:07 +00:00
|
|
|
|
|
|
|
// Deprecated
|
|
|
|
Deprecated = prerelease("DEPRECATED")
|
2017-06-15 22:03:43 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
// FeatureGate parses and stores flag gates for known features from
|
|
|
|
// a string like feature1=true,feature2=false,...
|
|
|
|
type FeatureGate interface {
|
2017-09-26 14:23:09 +00:00
|
|
|
// AddFlag adds a flag for setting global feature gates to the specified FlagSet.
|
2017-06-15 22:03:43 +00:00
|
|
|
AddFlag(fs *pflag.FlagSet)
|
2017-09-26 14:23:09 +00:00
|
|
|
// Set parses and stores flag gates for known features
|
|
|
|
// from a string like feature1=true,feature2=false,...
|
2017-06-15 22:03:43 +00:00
|
|
|
Set(value string) error
|
2017-11-13 10:33:25 +00:00
|
|
|
// SetFromMap stores flag gates for known features from a map[string]bool or returns an error
|
|
|
|
SetFromMap(m map[string]bool) error
|
2017-09-26 14:23:09 +00:00
|
|
|
// Enabled returns true if the key is enabled.
|
2017-06-15 22:03:43 +00:00
|
|
|
Enabled(key Feature) bool
|
2017-09-26 14:23:09 +00:00
|
|
|
// Add adds features to the featureGate.
|
2017-06-15 22:03:43 +00:00
|
|
|
Add(features map[Feature]FeatureSpec) error
|
2017-09-26 14:23:09 +00:00
|
|
|
// KnownFeatures returns a slice of strings describing the FeatureGate's known features.
|
2017-06-15 22:03:43 +00:00
|
|
|
KnownFeatures() []string
|
|
|
|
}
|
|
|
|
|
|
|
|
// featureGate implements FeatureGate as well as pflag.Value for flag parsing.
|
|
|
|
type featureGate struct {
|
2017-11-13 10:33:25 +00:00
|
|
|
special map[Feature]func(map[Feature]FeatureSpec, map[Feature]bool, bool)
|
|
|
|
|
|
|
|
// lock guards writes to known, enabled, and reads/writes of closed
|
|
|
|
lock sync.Mutex
|
|
|
|
// known holds a map[Feature]FeatureSpec
|
|
|
|
known *atomic.Value
|
|
|
|
// enabled holds a map[Feature]bool
|
|
|
|
enabled *atomic.Value
|
|
|
|
// closed is set to true when AddFlag is called, and prevents subsequent calls to Add
|
2017-06-15 22:03:43 +00:00
|
|
|
closed bool
|
|
|
|
}
|
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
func setUnsetAlphaGates(known map[Feature]FeatureSpec, enabled map[Feature]bool, val bool) {
|
|
|
|
for k, v := range known {
|
2017-06-15 22:03:43 +00:00
|
|
|
if v.PreRelease == Alpha {
|
2017-11-13 10:33:25 +00:00
|
|
|
if _, found := enabled[k]; !found {
|
|
|
|
enabled[k] = val
|
2017-06-15 22:03:43 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Set, String, and Type implement pflag.Value
|
|
|
|
var _ pflag.Value = &featureGate{}
|
|
|
|
|
|
|
|
func NewFeatureGate() *featureGate {
|
2017-11-13 10:33:25 +00:00
|
|
|
known := map[Feature]FeatureSpec{}
|
|
|
|
for k, v := range defaultFeatures {
|
|
|
|
known[k] = v
|
|
|
|
}
|
|
|
|
|
|
|
|
knownValue := &atomic.Value{}
|
|
|
|
knownValue.Store(known)
|
|
|
|
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
enabledValue := &atomic.Value{}
|
|
|
|
enabledValue.Store(enabled)
|
|
|
|
|
2017-06-15 22:03:43 +00:00
|
|
|
f := &featureGate{
|
2017-11-13 10:33:25 +00:00
|
|
|
known: knownValue,
|
2017-06-15 22:03:43 +00:00
|
|
|
special: specialFeatures,
|
2017-11-13 10:33:25 +00:00
|
|
|
enabled: enabledValue,
|
2017-06-15 22:03:43 +00:00
|
|
|
}
|
|
|
|
return f
|
|
|
|
}
|
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
// Set parses a string of the form "key1=value1,key2=value2,..." into a
|
2017-06-15 22:03:43 +00:00
|
|
|
// map[string]bool of known keys or returns an error.
|
|
|
|
func (f *featureGate) Set(value string) error {
|
2017-09-26 14:23:09 +00:00
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
// Copy existing state
|
|
|
|
known := map[Feature]FeatureSpec{}
|
|
|
|
for k, v := range f.known.Load().(map[Feature]FeatureSpec) {
|
|
|
|
known[k] = v
|
|
|
|
}
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
|
|
|
enabled[k] = v
|
|
|
|
}
|
|
|
|
|
2017-06-15 22:03:43 +00:00
|
|
|
for _, s := range strings.Split(value, ",") {
|
|
|
|
if len(s) == 0 {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
arr := strings.SplitN(s, "=", 2)
|
|
|
|
k := Feature(strings.TrimSpace(arr[0]))
|
2018-02-12 20:13:07 +00:00
|
|
|
featureSpec, ok := known[k]
|
2017-06-15 22:03:43 +00:00
|
|
|
if !ok {
|
|
|
|
return fmt.Errorf("unrecognized key: %s", k)
|
|
|
|
}
|
|
|
|
if len(arr) != 2 {
|
|
|
|
return fmt.Errorf("missing bool value for %s", k)
|
|
|
|
}
|
|
|
|
v := strings.TrimSpace(arr[1])
|
|
|
|
boolValue, err := strconv.ParseBool(v)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("invalid value of %s: %s, err: %v", k, v, err)
|
|
|
|
}
|
2017-11-13 10:33:25 +00:00
|
|
|
enabled[k] = boolValue
|
2018-02-12 20:13:07 +00:00
|
|
|
if boolValue && featureSpec.PreRelease == Deprecated {
|
|
|
|
glog.Warningf("enabling deprecated feature gate %s", k)
|
|
|
|
}
|
2017-11-13 10:33:25 +00:00
|
|
|
|
|
|
|
// Handle "special" features like "all alpha gates"
|
|
|
|
if fn, found := f.special[k]; found {
|
|
|
|
fn(known, enabled, boolValue)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Persist changes
|
|
|
|
f.known.Store(known)
|
|
|
|
f.enabled.Store(enabled)
|
|
|
|
|
|
|
|
glog.Infof("feature gates: %v", enabled)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// SetFromMap stores flag gates for known features from a map[string]bool or returns an error
|
|
|
|
func (f *featureGate) SetFromMap(m map[string]bool) error {
|
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
2017-06-15 22:03:43 +00:00
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
// Copy existing state
|
|
|
|
known := map[Feature]FeatureSpec{}
|
|
|
|
for k, v := range f.known.Load().(map[Feature]FeatureSpec) {
|
|
|
|
known[k] = v
|
|
|
|
}
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
|
|
|
enabled[k] = v
|
|
|
|
}
|
|
|
|
|
|
|
|
for k, v := range m {
|
|
|
|
k := Feature(k)
|
|
|
|
_, ok := known[k]
|
|
|
|
if !ok {
|
|
|
|
return fmt.Errorf("unrecognized key: %s", k)
|
|
|
|
}
|
|
|
|
enabled[k] = v
|
2017-06-15 22:03:43 +00:00
|
|
|
// Handle "special" features like "all alpha gates"
|
|
|
|
if fn, found := f.special[k]; found {
|
2017-11-13 10:33:25 +00:00
|
|
|
fn(known, enabled, v)
|
2017-06-15 22:03:43 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
// Persist changes
|
|
|
|
f.known.Store(known)
|
|
|
|
f.enabled.Store(enabled)
|
|
|
|
|
2017-06-15 22:03:43 +00:00
|
|
|
glog.Infof("feature gates: %v", f.enabled)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2017-09-26 14:23:09 +00:00
|
|
|
// String returns a string containing all enabled feature gates, formatted as "key1=value1,key2=value2,...".
|
2017-06-15 22:03:43 +00:00
|
|
|
func (f *featureGate) String() string {
|
|
|
|
pairs := []string{}
|
2017-11-13 10:33:25 +00:00
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
2017-06-15 22:03:43 +00:00
|
|
|
pairs = append(pairs, fmt.Sprintf("%s=%t", k, v))
|
|
|
|
}
|
|
|
|
sort.Strings(pairs)
|
|
|
|
return strings.Join(pairs, ",")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) Type() string {
|
|
|
|
return "mapStringBool"
|
|
|
|
}
|
|
|
|
|
2017-09-26 14:23:09 +00:00
|
|
|
// Add adds features to the featureGate.
|
2017-06-15 22:03:43 +00:00
|
|
|
func (f *featureGate) Add(features map[Feature]FeatureSpec) error {
|
2017-09-26 14:23:09 +00:00
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
|
|
|
|
2017-06-15 22:03:43 +00:00
|
|
|
if f.closed {
|
|
|
|
return fmt.Errorf("cannot add a feature gate after adding it to the flag set")
|
|
|
|
}
|
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
// Copy existing state
|
|
|
|
known := map[Feature]FeatureSpec{}
|
|
|
|
for k, v := range f.known.Load().(map[Feature]FeatureSpec) {
|
|
|
|
known[k] = v
|
|
|
|
}
|
|
|
|
|
2017-06-15 22:03:43 +00:00
|
|
|
for name, spec := range features {
|
2017-11-13 10:33:25 +00:00
|
|
|
if existingSpec, found := known[name]; found {
|
2017-06-15 22:03:43 +00:00
|
|
|
if existingSpec == spec {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
return fmt.Errorf("feature gate %q with different spec already exists: %v", name, existingSpec)
|
|
|
|
}
|
|
|
|
|
2017-11-13 10:33:25 +00:00
|
|
|
known[name] = spec
|
2017-06-15 22:03:43 +00:00
|
|
|
}
|
2017-11-13 10:33:25 +00:00
|
|
|
|
|
|
|
// Persist updated state
|
|
|
|
f.known.Store(known)
|
|
|
|
|
2017-06-15 22:03:43 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2017-09-26 14:23:09 +00:00
|
|
|
// Enabled returns true if the key is enabled.
|
2017-06-15 22:03:43 +00:00
|
|
|
func (f *featureGate) Enabled(key Feature) bool {
|
2017-11-13 10:33:25 +00:00
|
|
|
if v, ok := f.enabled.Load().(map[Feature]bool)[key]; ok {
|
|
|
|
return v
|
2017-06-15 22:03:43 +00:00
|
|
|
}
|
2017-11-13 10:33:25 +00:00
|
|
|
return f.known.Load().(map[Feature]FeatureSpec)[key].Default
|
2017-06-15 22:03:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// AddFlag adds a flag for setting global feature gates to the specified FlagSet.
|
|
|
|
func (f *featureGate) AddFlag(fs *pflag.FlagSet) {
|
2017-09-26 14:23:09 +00:00
|
|
|
f.lock.Lock()
|
2017-06-15 22:03:43 +00:00
|
|
|
f.closed = true
|
2017-09-26 14:23:09 +00:00
|
|
|
f.lock.Unlock()
|
2017-06-15 22:03:43 +00:00
|
|
|
|
|
|
|
known := f.KnownFeatures()
|
|
|
|
fs.Var(f, flagName, ""+
|
|
|
|
"A set of key=value pairs that describe feature gates for alpha/experimental features. "+
|
|
|
|
"Options are:\n"+strings.Join(known, "\n"))
|
|
|
|
}
|
|
|
|
|
2017-09-26 14:23:09 +00:00
|
|
|
// KnownFeatures returns a slice of strings describing the FeatureGate's known features.
|
2017-06-15 22:03:43 +00:00
|
|
|
func (f *featureGate) KnownFeatures() []string {
|
|
|
|
var known []string
|
2017-11-13 10:33:25 +00:00
|
|
|
for k, v := range f.known.Load().(map[Feature]FeatureSpec) {
|
2017-06-15 22:03:43 +00:00
|
|
|
pre := ""
|
|
|
|
if v.PreRelease != GA {
|
|
|
|
pre = fmt.Sprintf("%s - ", v.PreRelease)
|
|
|
|
}
|
|
|
|
known = append(known, fmt.Sprintf("%s=true|false (%sdefault=%t)", k, pre, v.Default))
|
|
|
|
}
|
|
|
|
sort.Strings(known)
|
|
|
|
return known
|
|
|
|
}
|