From 3611f92ddfe794c486e105923b31cda7ede3ca2c Mon Sep 17 00:00:00 2001
From: baude <bbaude@redhat.com>
Date: Mon, 2 Oct 2017 08:38:55 -0500
Subject: [PATCH] BUGFIX: Invalid return codes in kpod

Set the exitsdir for kpod back to /var/run/crio... so kpod can benefit
from the container exit file.

Because 0 is the int32 blank value, kpod needs its own container state
struct with the omitempty removed so it can actually display 0 in
its default json output.

Signed-off-by: baude <bbaude@redhat.com>
---
 libkpod/config.go         |  2 +-
 libkpod/container_data.go | 36 ++++++++++++++++++++++++++++++++++--
 oci/oci.go                |  2 ++
 server/server.go          |  2 +-
 4 files changed, 38 insertions(+), 4 deletions(-)

diff --git a/libkpod/config.go b/libkpod/config.go
index ddc58a70..123bece8 100644
--- a/libkpod/config.go
+++ b/libkpod/config.go
@@ -23,7 +23,7 @@ const (
 	cniBinDir           = "/opt/cni/bin/"
 	cgroupManager       = oci.CgroupfsCgroupsManager
 	lockPath            = "/run/crio.lock"
-	containerExitsDir   = "/var/run/kpod/exits"
+	containerExitsDir   = oci.ContainerExitsDir
 )
 
 // Config represents the entire set of configuration values that can be set for
diff --git a/libkpod/container_data.go b/libkpod/container_data.go
index 21843d40..2ade63ba 100644
--- a/libkpod/container_data.go
+++ b/libkpod/container_data.go
@@ -3,6 +3,7 @@ package libkpod
 import (
 	"encoding/json"
 	"os"
+	"time"
 
 	"k8s.io/apimachinery/pkg/fields"
 	pb "k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime"
@@ -22,7 +23,7 @@ type ContainerData struct {
 	LogPath          string
 	Labels           fields.Set
 	Annotations      fields.Set
-	State            *oci.ContainerState
+	State            *ContainerState
 	Metadata         *pb.ContainerMetadata
 	BundlePath       string
 	StopSignal       string
@@ -49,6 +50,17 @@ type driverData struct {
 	Data map[string]string
 }
 
+// ContainerState represents the status of a container.
+type ContainerState struct {
+	specs.State
+	Created   time.Time `json:"created"`
+	Started   time.Time `json:"started,omitempty"`
+	Finished  time.Time `json:"finished,omitempty"`
+	ExitCode  int32     `json:"exitCode"`
+	OOMKilled bool      `json:"oomKilled,omitempty"`
+	Error     string    `json:"error,omitempty"`
+}
+
 // GetContainerData gets the ContainerData for a container with the given name in the given store.
 // If size is set to true, it will also determine the size of the container
 func (c *ContainerServer) GetContainerData(name string, size bool) (*ContainerData, error) {
@@ -110,7 +122,7 @@ func (c *ContainerServer) GetContainerData(name string, size bool) (*ContainerDa
 		LogPath:          ctr.LogPath(),
 		Labels:           ctr.Labels(),
 		Annotations:      ctr.Annotations(),
-		State:            ctr.State(),
+		State:            c.State(ctr),
 		Metadata:         ctr.Metadata(),
 		BundlePath:       ctr.BundlePath(),
 		StopSignal:       ctr.GetStopSignal(),
@@ -176,3 +188,23 @@ func getBlankSpec() specs.Spec {
 		Windows:     &specs.Windows{},
 	}
 }
+
+// State copies the crio container state to ContainerState type for kpod
+func (c *ContainerServer) State(ctr *oci.Container) *ContainerState {
+	crioState := ctr.State()
+	specState := specs.State{
+		Version:     crioState.Version,
+		ID:          crioState.ID,
+		Status:      crioState.Status,
+		Pid:         crioState.Pid,
+		Bundle:      crioState.Bundle,
+		Annotations: crioState.Annotations,
+	}
+	cState := &ContainerState{
+		Started:  crioState.Started,
+		Created:  crioState.Created,
+		Finished: crioState.Finished,
+	}
+	cState.State = specState
+	return cState
+}
diff --git a/oci/oci.go b/oci/oci.go
index cb20a84d..e9babb7f 100644
--- a/oci/oci.go
+++ b/oci/oci.go
@@ -37,6 +37,8 @@ const (
 	CgroupfsCgroupsManager = "cgroupfs"
 	// SystemdCgroupsManager represents systemd native cgroup manager
 	SystemdCgroupsManager = "systemd"
+	// ContainerExitsDir is the location of container exit dirs
+	ContainerExitsDir = "/var/run/crio/exits"
 )
 
 // New creates a new Runtime with options provided
diff --git a/server/server.go b/server/server.go
index 50621939..5139a398 100644
--- a/server/server.go
+++ b/server/server.go
@@ -184,7 +184,7 @@ func New(config *Config) (*Server, error) {
 		return nil, err
 	}
 
-	config.ContainerExitsDir = "/var/run/crio/exits"
+	config.ContainerExitsDir = oci.ContainerExitsDir
 
 	// This is used to monitor container exits using inotify
 	if err := os.MkdirAll(config.ContainerExitsDir, 0755); err != nil {