From 72442d095703a4e84b41a7410b1b044ab6a02fce Mon Sep 17 00:00:00 2001 From: Nalin Dahyabhai Date: Mon, 4 Dec 2017 11:46:49 -0500 Subject: [PATCH] Don't skip a critest that we now pass We can pass the "listImage should get exactly 2 repoTags in the result image" test now, so we no longer need to skip it. Signed-off-by: Nalin Dahyabhai --- contrib/test/integration/critest.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/contrib/test/integration/critest.yml b/contrib/test/integration/critest.yml index d3a38103..377ab59d 100644 --- a/contrib/test/integration/critest.yml +++ b/contrib/test/integration/critest.yml @@ -16,24 +16,21 @@ - name: Add masquerade for localhost command: iptables -t nat -I POSTROUTING -s 127.0.0.1 ! -d 127.0.0.1 -j MASQUERADE - # TODO(runcom): enable skipped tests once we fix them (image list related) - # https://github.com/kubernetes-incubator/cri-o/issues/1048 - name: run critest validation - shell: "critest -c --runtime-endpoint /var/run/crio/crio.sock --image-endpoint /var/run/crio/crio.sock -s 'listImage should get exactly 2 repoTags in the result image' v" + shell: "critest -c --runtime-endpoint /var/run/crio/crio.sock --image-endpoint /var/run/crio/crio.sock v" args: chdir: "{{ ansible_env.GOPATH }}/src/github.com/kubernetes-incubator/cri-o" async: 5400 poll: 30 when: ansible_distribution not in ['RedHat', 'CentOS'] - # XXX: RHEL has an additional test which fails beacuse of selinux but disabling + # XXX: RHEL has an additional test which fails because of selinux but disabling # it doesn't solve the issue. - # TODO(runcom): enable skipped tests once we fix them (image list related and selinux) - # https://github.com/kubernetes-incubator/cri-o/issues/1048 + # TODO(runcom): enable skipped tests once we fix them (selinux) # https://bugzilla.redhat.com/show_bug.cgi?id=1414236 # https://access.redhat.com/solutions/2897781 - name: run critest validation - shell: "critest -c --runtime-endpoint /var/run/crio/crio.sock --image-endpoint /var/run/crio/crio.sock -s 'listImage should get exactly 2 repoTags in the result image|should not allow privilege escalation when true' v" + shell: "critest -c --runtime-endpoint /var/run/crio/crio.sock --image-endpoint /var/run/crio/crio.sock -s 'should not allow privilege escalation when true' v" args: chdir: "{{ ansible_env.GOPATH }}/src/github.com/kubernetes-incubator/cri-o" async: 5400