From 7b20cd1ccd50852b286f8867ea36e4af5d21e3bd Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Fri, 19 Jan 2018 15:34:58 -0800 Subject: [PATCH] CONTRIBUTING: Link to .github/CODEOWNERS Remove a dead "Becoming a Maintainer" link and that stub section, since CRI-O currently doesn't document that process. By leaving it undocumented, maintainer changes falls back to the usual pull-request review process. Link to CODEOWNERS and associated documentation so that folks can figure out what the usual pull-request processs is. The "most" wiggle is because CRI-O seems to have not required review from code owners [1], based on GitHub's [2]: Review has been requested on this pull request. It is not required to merge. wording. [1]: https://help.github.com/articles/enabling-required-reviews-for-pull-requests/ [2]: https://github.com/kubernetes-incubator/cri-o/pull/1265 Signed-off-by: W. Trevor King --- CONTRIBUTING.md | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cc549116..af41feee 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,7 +8,6 @@ that we follow. * [Reporting Issues](#reporting-issues) * [Submitting Pull Requests](#submitting-pull-requests) * [Communications](#communications) -* [Becoming a Maintainer](#becoming-a-maintainer) ## Reporting Issues @@ -55,9 +54,7 @@ PRs that fix issues should include a reference like `Closes #XXXX` in the commit message so that github will automatically close the referenced issue when the PR is merged. - +Most PRs will be reviewied by at least one [code owner][code-owners] (listed [here](.github/CODEOWNERS)). ### Sign your PRs @@ -125,18 +122,4 @@ and [PRs](https://github.com/kubernetes-incubator/cri-o/pulls) tracking system. - +[code-owners]: https://help.github.com/articles/about-codeowners/