Allow containerserver to match containers by id prefix or name

Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
This commit is contained in:
Ryan Cole 2017-07-31 19:23:20 -04:00
parent fa6e2d81f9
commit 9ada0eb4e5
7 changed files with 81 additions and 29 deletions

View file

@ -1,24 +0,0 @@
package server
import (
"fmt"
"github.com/kubernetes-incubator/cri-o/oci"
)
func (s *Server) getContainerFromRequest(cid string) (*oci.Container, error) {
if cid == "" {
return nil, fmt.Errorf("container ID should not be empty")
}
containerID, err := s.CtrIDIndex().Get(cid)
if err != nil {
return nil, fmt.Errorf("container with ID starting with %s not found: %v", cid, err)
}
c := s.ContainerServer.GetContainer(containerID)
if c == nil {
return nil, fmt.Errorf("specified container not found: %s", containerID)
}
return c, nil
}

View file

@ -12,7 +12,7 @@ import (
// ExecSync runs a command in a container synchronously.
func (s *Server) ExecSync(ctx context.Context, req *pb.ExecSyncRequest) (*pb.ExecSyncResponse, error) {
logrus.Debugf("ExecSyncRequest %+v", req)
c, err := s.getContainerFromRequest(req.ContainerId)
c, err := s.GetContainerFromRequest(req.ContainerId)
if err != nil {
return nil, err
}

View file

@ -13,7 +13,7 @@ import (
// should be force removed.
func (s *Server) RemoveContainer(ctx context.Context, req *pb.RemoveContainerRequest) (*pb.RemoveContainerResponse, error) {
logrus.Debugf("RemoveContainerRequest %+v", req)
c, err := s.getContainerFromRequest(req.ContainerId)
c, err := s.GetContainerFromRequest(req.ContainerId)
if err != nil {
return nil, err
}

View file

@ -12,7 +12,7 @@ import (
// StartContainer starts the container.
func (s *Server) StartContainer(ctx context.Context, req *pb.StartContainerRequest) (*pb.StartContainerResponse, error) {
logrus.Debugf("StartContainerRequest %+v", req)
c, err := s.getContainerFromRequest(req.ContainerId)
c, err := s.GetContainerFromRequest(req.ContainerId)
if err != nil {
return nil, err
}

View file

@ -21,7 +21,7 @@ const (
// ContainerStatus returns status of the container.
func (s *Server) ContainerStatus(ctx context.Context, req *pb.ContainerStatusRequest) (*pb.ContainerStatusResponse, error) {
logrus.Debugf("ContainerStatusRequest %+v", req)
c, err := s.getContainerFromRequest(req.ContainerId)
c, err := s.GetContainerFromRequest(req.ContainerId)
if err != nil {
return nil, err
}

View file

@ -12,7 +12,7 @@ import (
// StopContainer stops a running container with a grace period (i.e., timeout).
func (s *Server) StopContainer(ctx context.Context, req *pb.StopContainerRequest) (*pb.StopContainerResponse, error) {
logrus.Debugf("StopContainerRequest %+v", req)
c, err := s.getContainerFromRequest(req.ContainerId)
c, err := s.GetContainerFromRequest(req.ContainerId)
if err != nil {
return nil, err
}