vbatts/cri-o
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1235 from rhatdan/hooks

Browse source 
Report an warning when no stages are defined for a hook
This commit is contained in:
Mrunal Patel 2018-02-03 09:51:59 -08:00 committed by GitHub
commit b8d2482b26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/hooks.go
View file

@ -54,9 +54,13 @@ func readHook(hookPath string) (HookParams, error) {
return hook, errors.Wrapf(err, "invalid cmd regular expression %q defined in hook config %q", cmd, hookPath)
}
}
for _, stage := range hook.Stage {
if !validStage[stage] {
return hook, errors.Wrapf(err, "unknown stage %q defined in hook config %q", stage, hookPath)
if len(hook.Stage) == 0 {
logrus.Warnf("No stage defined in hook config %q, hook will never run", hookPath)
} else {
for _, stage := range hook.Stage {
if !validStage[stage] {
return hook, errors.Wrapf(err, "unknown stage %q defined in hook config %q", stage, hookPath)
}
}
}
return hook, nil