Add tests for server/config.go

The tests are trying to read an write configuration files and check that the
fields are being set or saved properly.

A folder fixtures/ was created on server/ as well adding an example crio.conf
file to it.

Note: some extra paths about Vagrant and VSCode were added to gitignore.
Signed-off-by: Álex González <agonzalezro@gmail.com>
This commit is contained in:
Álex González 2017-11-12 22:54:34 +01:00
parent edf2300205
commit c3f86cd016
No known key found for this signature in database
GPG key ID: 5B05411474F6172C
3 changed files with 135 additions and 0 deletions

5
.gitignore vendored
View file

@ -11,3 +11,8 @@
/test/bin2img/bin2img /test/bin2img/bin2img
/test/checkseccomp/checkseccomp /test/checkseccomp/checkseccomp
/test/copyimg/copyimg /test/copyimg/copyimg
Vagrantfile
.vagrant/
.vscode/

89
server/config_test.go Normal file
View file

@ -0,0 +1,89 @@
package server
import (
"io/ioutil"
"os"
"testing"
"github.com/kubernetes-incubator/cri-o/libkpod"
)
const fixturePath = "fixtures/crio.conf"
func must(t *testing.T, err error) {
if err != nil {
t.Error(err)
}
}
func assertAllFieldsEquality(t *testing.T, c Config) {
testCases := []struct {
fieldValue, expected interface{}
}{
{c.RootConfig.Root, "/var/lib/containers/storage"},
{c.RootConfig.RunRoot, "/var/run/containers/storage"},
{c.RootConfig.Storage, "overlay"},
{c.RootConfig.StorageOptions[0], "overlay.override_kernel_check=1"},
{c.APIConfig.Listen, "/var/run/crio.sock"},
{c.APIConfig.StreamPort, "10010"},
{c.APIConfig.StreamAddress, "localhost"},
{c.RuntimeConfig.Runtime, "/usr/local/bin/runc"},
{c.RuntimeConfig.RuntimeUntrustedWorkload, "untrusted"},
{c.RuntimeConfig.DefaultWorkloadTrust, "trusted"},
{c.RuntimeConfig.Conmon, "/usr/local/libexec/crio/conmon"},
{c.RuntimeConfig.ConmonEnv[0], "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"},
{c.RuntimeConfig.SELinux, true},
{c.RuntimeConfig.SeccompProfile, "/etc/crio/seccomp.json"},
{c.RuntimeConfig.ApparmorProfile, "crio-default"},
{c.RuntimeConfig.CgroupManager, "cgroupfs"},
{c.RuntimeConfig.PidsLimit, int64(1024)},
{c.ImageConfig.DefaultTransport, "docker://"},
{c.ImageConfig.PauseImage, "kubernetes/pause"},
{c.ImageConfig.PauseCommand, "/pause"},
{c.ImageConfig.SignaturePolicyPath, "/tmp"},
{c.ImageConfig.ImageVolumes, libkpod.ImageVolumesType("mkdir")},
{c.ImageConfig.InsecureRegistries[0], "insecure-registry:1234"},
{c.ImageConfig.Registries[0], "registry:4321"},
{c.NetworkConfig.NetworkDir, "/etc/cni/net.d/"},
{c.NetworkConfig.PluginDir, "/opt/cni/bin/"},
}
for _, tc := range testCases {
if tc.fieldValue != tc.expected {
t.Errorf(`Expecting: "%s", got: "%s"`, tc.expected, tc.fieldValue)
}
}
}
func TestUpdateFromFile(t *testing.T) {
c := Config{}
must(t, c.UpdateFromFile(fixturePath))
assertAllFieldsEquality(t, c)
}
func TestToFile(t *testing.T) {
configFromFixture := Config{}
must(t, configFromFixture.UpdateFromFile(fixturePath))
f, err := ioutil.TempFile("", "crio.conf")
if err != nil {
t.Error(err)
}
defer os.Remove(f.Name())
must(t, configFromFixture.ToFile(f.Name()))
writtenConfig := Config{}
err = writtenConfig.UpdateFromFile(f.Name())
if err != nil {
t.Fatal(err)
}
assertAllFieldsEquality(t, writtenConfig)
}

41
server/fixtures/crio.conf Normal file
View file

@ -0,0 +1,41 @@
[crio]
root = "/var/lib/containers/storage"
runroot = "/var/run/containers/storage"
storage_driver = "overlay"
storage_option = ["overlay.override_kernel_check=1"]
[crio.api]
listen = "/var/run/crio.sock"
stream_address = "localhost"
stream_port = "10010"
[crio.runtime]
runtime = "/usr/local/bin/runc"
runtime_untrusted_workload = "untrusted"
default_workload_trust = "trusted"
conmon = "/usr/local/libexec/crio/conmon"
conmon_env = [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
]
selinux = true
seccomp_profile = "/etc/crio/seccomp.json"
apparmor_profile = "crio-default"
cgroup_manager = "cgroupfs"
pids_limit = 1024
[crio.image]
default_transport = "docker://"
pause_image = "kubernetes/pause"
pause_command = "/pause"
signature_policy = "/tmp"
image_volumes = "mkdir"
insecure_registries = [
"insecure-registry:1234",
]
registries = [
"registry:4321",
]
[crio.network]
network_dir = "/etc/cni/net.d/"
plugin_dir = "/opt/cni/bin/"