diff --git a/test/ctr_seccomp.bats b/test/ctr_seccomp.bats index da7f9fad..79d644aa 100644 --- a/test/ctr_seccomp.bats +++ b/test/ctr_seccomp.bats @@ -15,7 +15,7 @@ function teardown() { skip "skip this test since seccomp is not enabled." fi - sed -e 's/"chmod",//' "$CRIO_ROOT"/cri-o/seccomp.json > "$TESTDIR"/seccomp_profile1.json + sed -e 's/"chmod",//' "$SECCOMP_PROFILE" > "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmod",//' "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmodat",//g' "$TESTDIR"/seccomp_profile1.json @@ -51,7 +51,7 @@ function teardown() { skip "skip this test since seccomp is not enabled." fi - sed -e 's/"chmod",//' "$CRIO_ROOT"/cri-o/seccomp.json > "$TESTDIR"/seccomp_profile1.json + sed -e 's/"chmod",//' "$SECCOMP_PROFILE" > "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmod",//' "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmodat",//g' "$TESTDIR"/seccomp_profile1.json @@ -89,7 +89,7 @@ function teardown() { skip "skip this test since seccomp is not enabled." fi - sed -e 's/"chmod",//' "$CRIO_ROOT"/cri-o/seccomp.json > "$TESTDIR"/seccomp_profile1.json + sed -e 's/"chmod",//' "$SECCOMP_PROFILE" > "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmod",//' "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmodat",//g' "$TESTDIR"/seccomp_profile1.json @@ -124,7 +124,7 @@ function teardown() { skip "skip this test since seccomp is not enabled." fi - sed -e 's/"chmod",//' "$CRIO_ROOT"/cri-o/seccomp.json > "$TESTDIR"/seccomp_profile1.json + sed -e 's/"chmod",//' "$SECCOMP_PROFILE" > "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmod",//' "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmodat",//g' "$TESTDIR"/seccomp_profile1.json @@ -156,7 +156,7 @@ function teardown() { start_crio - sed -e 's/"chmod",//' "$CRIO_ROOT"/cri-o/seccomp.json > "$TESTDIR"/seccomp_profile1.json + sed -e 's/"chmod",//' "$SECCOMP_PROFILE" > "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmod",//' "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmodat",//g' "$TESTDIR"/seccomp_profile1.json @@ -191,7 +191,7 @@ function teardown() { skip "skip this test since seccomp is not enabled." fi - sed -e 's/"chmod",//' "$CRIO_ROOT"/cri-o/seccomp.json > "$TESTDIR"/seccomp_profile1.json + sed -e 's/"chmod",//' "$SECCOMP_PROFILE" > "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmod",//' "$TESTDIR"/seccomp_profile1.json sed -i 's/"fchmodat",//g' "$TESTDIR"/seccomp_profile1.json diff --git a/test/helpers.bash b/test/helpers.bash index c967d248..35607bb3 100644 --- a/test/helpers.bash +++ b/test/helpers.bash @@ -286,8 +286,8 @@ function start_crio() { } function cleanup_ctrs() { - run crictl ps --quiet - if [ "$status" -eq 0 ]; then + output=$(crictl ps --quiet) + if [ $? -eq 0 ]; then if [ "$output" != "" ]; then printf '%s\n' "$output" | while IFS= read -r line do @@ -300,8 +300,8 @@ function cleanup_ctrs() { } function cleanup_images() { - run crictl images --quiet - if [ "$status" -eq 0 ]; then + output=$(crictl images --quiet) + if [ $? -eq 0 ]; then if [ "$output" != "" ]; then printf '%s\n' "$output" | while IFS= read -r line do @@ -312,8 +312,8 @@ function cleanup_images() { } function cleanup_pods() { - run crictl sandboxes --quiet - if [ "$status" -eq 0 ]; then + output=$(crictl sandboxes --quiet) + if [ $? -eq 0 ]; then if [ "$output" != "" ]; then printf '%s\n' "$output" | while IFS= read -r line do diff --git a/test/network.bats b/test/network.bats index dc8143c2..4d40fffa 100644 --- a/test/network.bats +++ b/test/network.bats @@ -127,6 +127,9 @@ function teardown() { } @test "Ensure correct CNI plugin namespace/name/container-id arguments" { + if [[ ! -e "$CRIO_CNI_PLUGIN"/bridge-custom ]]; then + skip "bridge-custom plugin not available" + fi start_crio "" "" "" "prepare_plugin_test_args_network_conf" run crioctl pod run --config "$TESTDATA"/sandbox_config.json [ "$status" -eq 0 ] @@ -168,6 +171,9 @@ function teardown() { } @test "Clean up network if pod sandbox fails" { + if [[ ! -e "$CRIO_CNI_PLUGIN"/bridge-custom ]]; then + skip "bridge-custom plugin not available" + fi start_crio "" "" "" "prepare_plugin_test_args_network_conf" # make conmon non-executable to cause the sandbox setup to fail after