vbatts/cri-o
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

oci: Use error logs for container creation failures

Browse source 
They are more critical than simple debug strings.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Samuel Ortiz 2017-09-27 12:06:13 +02:00
parent a5e5ccb365
commit f9bad6cc32
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
oci/oci.go
View file

@ -271,13 +271,14 @@ func (r *Runtime) CreateContainer(c *Container, cgroupParent string) error {
logrus.Debugf("Received container pid: %d", ss.si.Pid) logrus.Debugf("Received container pid: %d", ss.si.Pid)
if ss.si.Pid == -1 { if ss.si.Pid == -1 {
if ss.si.Message != "" { if ss.si.Message != "" {
logrus.Debugf("Container creation error: %s", ss.si.Message) logrus.Errorf("Container creation error: %s", ss.si.Message)
return fmt.Errorf("container create failed: %s", ss.si.Message) return fmt.Errorf("container create failed: %s", ss.si.Message)
} }
logrus.Debugf("Container creation failed") logrus.Errorf("Container creation failed")
return fmt.Errorf("container create failed") return fmt.Errorf("container create failed")
} }
case <-time.After(ContainerCreateTimeout): case <-time.After(ContainerCreateTimeout):
logrus.Errorf("Container creation timeout (%v)", ContainerCreateTimeout)
return fmt.Errorf("create container timeout") return fmt.Errorf("create container timeout")
} }
return nil return nil