Commit graph

1566 commits

Author SHA1 Message Date
Mrunal Patel
ce17c5214d sandbox: Reduce number of calls to UpdateStatus
Also, we distinguish between container and a pod infra
container in the exit monitor as pod infra containers
aren't stored in the main container index.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Mrunal Patel
ea4b6fa55d container: Reduce number of calls to UpdateStatus
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Mrunal Patel
3f1b42ee9e Return container mounts in status from stored list
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Mrunal Patel
fa317b41fd Add volumes to container object at container create time
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Mrunal Patel
5ab6ec3046 oci: Add volumes field to Container
We add a ContainerVolume struct and store a list of volumes
in the Container object for quick retrieval.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Mrunal Patel
bfcebcdb00 Store imageName and imageRef for containers
We calculate these values at container creation time and store
them in the container object as they are requested during container
status. This avoids re-calculation and speeds up container status.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Mrunal Patel
1cf5f8ee3b container: Don't call OCI runtime status
We get notified of container exits by inotify so we already
have updated status of the container in memory state.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-08-17 09:01:07 -07:00
Matthew Heon
d6eb943075 Move some image functions around
Signed-off-by: Matthew Heon <mheon@redhat.com>
2017-08-17 11:47:10 -04:00
Ryan Cole
ceeed6c32e add kpod stats function
Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-17 11:34:10 -04:00
Ryan Cole
dda5511a2b Add libcontainer dependencies to vendor.conf
Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-17 11:33:51 -04:00
Ryan Cole
65eec38754 Vendor in files for runc/libcontainer
vndr was previously removing .go files in runc/libcontainer since they weren't used anywhere
in cri-o, but kpod stats will use them

Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-17 11:33:51 -04:00
Mrunal Patel
efc29e3dd2 Merge pull request #774 from rhatdan/rbind
CRI-O default bind mounts to "rbind, rprivate" to match docker
2017-08-17 08:30:25 -07:00
Matthew Heon
6be525b9f0 Modify container exec and attach, add image import/export
Signed-off-by: Matthew Heon <mheon@redhat.com>
2017-08-17 10:43:24 -04:00
Matthew Heon
bdddb3d36b Add preliminary libpod image API
Signed-off-by: Matthew Heon <mheon@redhat.com>
2017-08-17 10:43:24 -04:00
Matthew Heon
9d56fd8443 Add skeleton of new libpod API
Signed-off-by: Matthew Heon <mheon@redhat.com>
2017-08-17 10:43:24 -04:00
Mrunal Patel
8c496a101a Merge pull request #773 from 14rcole/kpod-format-table
Kpod format
2017-08-17 07:41:09 -07:00
Ryan Cole
1eb21f8e15 implement kpod rename
rename a container

Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-17 09:00:41 -04:00
Ryan Cole
ba07bfb932 Make kpod images use text/template by default
Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-17 08:32:38 -04:00
Ryan Cole
08c3d241a4 Add format functions
Add functions to go templates such as truncating a field.  Also add
the table keyword, which, if placed at the beginning of a format string,
adds headers to the output

Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-16 15:45:13 -04:00
Mrunal Patel
6ca462a3b6 Merge pull request #718 from 14rcole/kpod-logs
Kpod logs
2017-08-16 11:47:34 -07:00
Mrunal Patel
96735dac2f Merge pull request #775 from TomSweeneyRedHat/dev/tsweeney/docfix1
Number of minor touch ups to Code of Conduct
2017-08-16 11:14:22 -07:00
TomSweeneyRedHat
85f4f09e52 Number of minor touch ups to Code of Conduct
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2017-08-16 11:34:58 -04:00
Daniel J Walsh
50ad19148d CRI-O default bind mounts to "rbind, rprivate" to match docker
Containers running in kubernetes currently do not specify options
for mount propagation and whether to bind or rbind the mount point.
Since docker defaults to bind and rbind, we should match their
behavious, since this is what admins expect

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-08-16 11:16:39 -04:00
Ryan Cole
07572e85f5 Add kpod logs command
Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
2017-08-16 08:55:23 -04:00
Mrunal Patel
85b4aedacb Merge pull request #770 from umohnani8/kpod_load
Fix 'kpod load' nil issue raised by QE
2017-08-15 19:04:15 -07:00
umohnani8
9f349528dc Fix 'kpod load' nil issue raised by QE
When an image is saved using the digest, the repotag saved is null causing load to break
Using the hex form of the image digest to save the image when the repotag is null
This saves the image in containers-storage without a name or tag as "<none>"

Signed-off-by: umohnani8 <umohnani@redhat.com>
2017-08-15 14:23:11 -04:00
Mrunal Patel
a69631c1bd Merge pull request #769 from rhatdan/debug
More cleanups of main man page kpod-1.md and README.md
2017-08-15 10:42:56 -07:00
Mrunal Patel
24476e9afb Merge pull request #761 from mbssaiakhil/patch-3
Fix Typo in cri-o Tutorial
2017-08-15 09:52:24 -07:00
Mrunal Patel
84395bc969 Merge pull request #760 from mbssaiakhil/patch-2
Fix Typo in Events Code of Conduct
2017-08-15 09:52:07 -07:00
Mrunal Patel
c067fbbbe2 Merge pull request #759 from mbssaiakhil/patch-1
Fix Typo in cri-o README
2017-08-15 08:17:07 -07:00
Daniel J Walsh
87b13fd432 More cleanups of main man page kpod-1.md and README.md
Also added new commands to transfer.md

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-08-15 11:08:22 -04:00
Mrunal Patel
43df5b89af Merge pull request #767 from asifdxtreme/patch2
Fix Typo to improve GoReport
2017-08-15 07:29:17 -07:00
Mrunal Patel
6980365d0d Merge pull request #768 from asifdxtreme/patch-3
Fix Typo in Readme
2017-08-15 07:29:00 -07:00
Malepati Bala Siva Sai Akhil
9d52efef23 Update Community Code of Conduct
Update Community Code of Conduct from kubernetes/kubernetes-template-project

Signed-off-by: Malepati Bala Siva Sai Akhil <malepatib.akhil@huawei.com>
2017-08-15 19:55:16 +05:30
Malepati Bala Siva Sai Akhil
59d5f32933 Fix Typo in Events Code of Conduct
Signed-off-by: Malepati Bala Siva Sai Akhil <malepatib.akhil@huawei.com>
2017-08-15 17:25:45 +05:30
Malepati Bala Siva Sai Akhil
01dac86b1c Fix Typo in cri-o Tutorial
Signed-off-by: Malepati Bala Siva Sai Akhil <malepatib.akhil@huawei.com>
2017-08-15 10:00:20 +05:30
asifdxtreme
39722ab5e6 Fix Typo in Readme
Signed-off-by: asifdxtreme <mohammad.asif.siddiqui1@huawei.com>
2017-08-15 10:48:39 +08:00
Malepati Bala Siva Sai Akhil
4e64eedbc5 Fix Typo in cri-o README
Signed-off-by: Malepati Bala Siva Sai Akhil <malepatib.akhil@huawei.com>
2017-08-15 08:15:04 +05:30
asifdxtreme
1442ba988a Fix Typo to improve GoReport
Signed-off-by: asifdxtreme <mohammad.asif.siddiqui1@huawei.com>
2017-08-15 10:15:01 +08:00
Mrunal Patel
36fd0a7208 Merge pull request #744 from rhatdan/debug
Add --debug flag to kpod to turn up logging level to debug
2017-08-14 16:21:22 -07:00
Antonio Murdaca
a8f0b115ad Merge pull request #746 from vbatts/ops-transfer
tranfer: document ops and dev transfer
2017-08-14 16:02:39 +02:00
Antonio Murdaca
ea600408fb Merge pull request #762 from rhatdan/kpod-cp
Add man page for kpod-cp.1
2017-08-14 16:01:01 +02:00
Antonio Murdaca
95165063bd Merge pull request #758 from mrunalp/inotify_exit_watch
Inotify exit watch
2017-08-14 16:00:35 +02:00
Daniel J Walsh
cb01a0a09e Add man page for kpod-cp.1
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-08-14 13:30:37 +00:00
Mrunal Patel
30ded83096 Add inotify watcher for container exits
This allows the container list API to return updated status
for exited container without having to call container status first.

Signed-off-by: Mrunal Patel <mpatel@redhat.com>
2017-08-13 08:01:48 -07:00
Mrunal Patel
4311020c36 Merge pull request #653 from baude/images_json
cmd/kpod/images.go: Add JSON output option
2017-08-13 07:19:04 -07:00
Mrunal Patel
8f735a581d container: Don't call runtime state on every container on list
Signed-off-by: Mrunal Patel <mpatel@redhat.com>
2017-08-12 18:37:06 -07:00
baude
01b71393e3 cmd/kpod/images.go: Add structured format ouput
For kpod images, we need to output in JSON format so that consumers
(programatic) have structured input to work with.

kpod images --format json

Signed-off-by: baude <bbaude@redhat.com>
2017-08-12 19:09:49 -05:00
Mrunal Patel
2bdcd460bb Merge pull request #722 from 14rcole/kpod-diff
Add kpod diff command
2017-08-12 08:17:19 -07:00
Daniel J Walsh
464d6852de Add --debug flag to kpod to turn up logging level to debug
Also set default level of logging to errors,  we should not see
info messages in the kpod command line.

While adding this patch, I found missing options in kpod command line
and bash completions, so I added them in.

Also fixed some sorting issues in the way commands are displayer in help or in
bash completions.

Finally fixed the error message to be output on failure using logrus.Errorf, so
we don't get the stack any longer.

Also updated README.md with missing kpod commands.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-08-11 16:41:25 -04:00