Commit graph

1816 commits

Author SHA1 Message Date
Mrunal Patel
8c83014476 Merge pull request #994 from edsantiago/safe_netcat
nc (netcat): don't block when run interactively
2017-10-10 16:23:07 -07:00
Daniel J Walsh
132dae4094 Merge pull request #989 from umohnani8/flag_change
Changed debug flag to log-level in kpod/main.go
2017-10-10 17:05:29 -04:00
umohnani8
5d48e1aca5 Vendor in latest containers/image
Add support for kpod login/logout

Signed-off-by: umohnani8 <umohnani@redhat.com>
2017-10-10 17:02:57 -04:00
umohnani8
d664a58a6d Add 'kpod login' and 'kpod logout' commands
Signed-off-by: umohnani8 <umohnani@redhat.com>
2017-10-10 17:02:57 -04:00
umohnani8
b21a3e36ac Add docker/config package to containers/image/pkg
This package is used in authenticating a user for kpod login
and can be used for authentication in kpod push, pull etc.

Signed-off-by: umohnani8 <umohnani@redhat.com>
2017-10-10 16:58:40 -04:00
Daniel J Walsh
772f4b1515 Merge pull request #988 from umohnani8/libpod-part2
Continue switching from libkpod to libpod
2017-10-10 16:55:53 -04:00
Daniel J Walsh
680f3a09e1 Merge pull request #953 from edsantiago/parameterize_cni_plugin
Parameterize CRIO_CNI_PLUGIN
2017-10-10 16:55:03 -04:00
Ed Santiago
d54a139f6d nc (netcat): don't block when run interactively
When running the test suite interactively, "Connect to pod
hostport from the host" test hangs because nc thinks it's
got a bidirectional connection. Running with </dev/null
closes the connection after receiving the expected data,
letting the tests proceed.

This is just a suggestion for n00b-friendliness. Running
interactively is rare, but it's exactly where a n00b
will begin, and the hang costs a little time and energy
to track down.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2017-10-10 13:03:08 -06:00
umohnani8
b4d3b560d3 Changed debug flag to log-level in kpod/main.go
The change in flag from debug to log-level was causing cri-o to fail when started
There was a reference to the debug flag in kpod/main.go that had not been changed

Signed-off-by: umohnani8 <umohnani@redhat.com>
2017-10-10 14:55:14 -04:00
umohnani8
356df5d18e Continue switching from libkpod to libpod
Refactored rmi, images, diff, and history.
Made fixes to kpod images in the way it was handing the templates as well as printing the image names

Signed-off-by: umohnani8 <umohnani@redhat.com>
2017-10-10 11:22:09 -04:00
Mrunal Patel
bbd7321a7a Merge pull request #991 from runcom/kube-1.7.8
bump to kube v1.7.8
2017-10-10 07:41:40 -07:00
Daniel J Walsh
cfd7aec1c3 Merge pull request #960 from ashcrow/rebase-895
kpod rmi by ID untagged: %name incorrect
2017-10-10 07:56:43 -04:00
Antonio Murdaca
b6be0f0bd7
bump to kube v1.7.8
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2017-10-10 10:58:44 +02:00
Daniel J Walsh
19df68605b Merge pull request #990 from TomSweeneyRedHat/dev/tsweeney/fixread
Add video for pause/unpause to README.md
2017-10-09 16:31:56 -04:00
Daniel J Walsh
7efeada9df Merge pull request #983 from rhatdan/docs
Add documentation on kpod attach
2017-10-09 16:14:19 -04:00
TomSweeneyRedHat
0f31a61113 Add video for pause/unpause to README.md
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2017-10-09 14:57:37 -04:00
Daniel J Walsh
825f7f290b Merge pull request #949 from mrunalp/test_fix_kube_dns
test: Fix kube dns bring up in cluster
2017-10-07 05:59:01 -04:00
Daniel J Walsh
df5110dfd5 Add documentation on kpod attach
Add a man page on how to achieve the same user experience as using
kpod attach by using either the kpod logs or kpod exec commands.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-10-06 20:56:05 +00:00
Mrunal Patel
8c9fcfce0d Merge pull request #984 from mrunalp/readme_fixes
readme: Fix rc version and specify cgroup driver for k8s
2017-10-06 13:20:37 -07:00
Mrunal Patel
93af568246 readme: Fix rc version and specify cgroup driver for k8s
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-06 11:52:14 -07:00
Mrunal Patel
9c518dc03b test: Fix kube dns bring up in cluster
We have to call hack/local-up-cluster from kubernetes directory
as it makes relative calls to cluster/kubectl.sh. The failure
of these calls led to kube-dns not coming up.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-06 11:50:27 -07:00
Daniel J Walsh
19f37f5c14 Merge pull request #955 from sameo/topic/delete_container
Handle container creation failures gracefully
2017-10-06 11:54:10 -04:00
Daniel J Walsh
974bafe012 Merge pull request #950 from sameo/topic/loglevel
main: Define -log-level option
2017-10-06 09:51:07 -04:00
Daniel J Walsh
e5d2c0af5f Merge pull request #979 from mrunalp/log_size_min
Make sure log-size-max is atleast as big as read buffer
2017-10-06 09:23:48 -04:00
Mrunal Patel
f17f122ef3 Merge pull request #906 from dcbw/net-test
test: add test for network teardown on sandbox error
2017-10-05 21:18:09 -07:00
Mrunal Patel
309a744075 Merge pull request #976 from mrunalp/bump_go_1.8.4
test: Update go to 1.8.4
2017-10-05 18:06:48 -07:00
Mrunal Patel
067cbff207 Make sure log-size-max is atleast as big as read buffer
We need log-size-max to be bigger than the read buffer in conmon
to accurately truncate it.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-05 15:06:38 -07:00
Dan Williams
cc2b27132e test/network: clean up tests
Signed-off-by: Dan Williams <dcbw@redhat.com>
2017-10-05 16:41:54 -05:00
Dan Williams
8392f5f757 test: add test for network teardown on sandbox setup errors
Signed-off-by: Dan Williams <dcbw@redhat.com>
2017-10-05 16:41:54 -05:00
Samuel Ortiz
f9bad6cc32 oci: Use error logs for container creation failures
They are more critical than simple debug strings.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
2017-10-05 22:53:20 +02:00
Samuel Ortiz
a5e5ccb365 main: Replace -debug with -log-level
Running crio with -debug is very verbose. Having more granularity
on the log level can be useful when e.g. only looking for errors.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
2017-10-05 22:53:20 +02:00
Samuel Ortiz
d27451029b oci: Increase the container creation timeout
Under very heavy loads (e.g. 100 pods created at the same time), VM
based runtimes can take more than 10 seconds to create a pod.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
2017-10-05 22:52:33 +02:00
Samuel Ortiz
eae1b7d6bd oci: Delete container resources upon creation failure
When cri-o assumes the container creation failed, we need to let the
runtime know that we're bailing out so that it cancels all ongoing
operation.
In container creation timeout situations for example, failing to
explictly request the runtime for container deletion can lead to large
resource leaks as kubelet re-creates a failing container, while the
runtime finishes creating the previous one(s).

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
2017-10-05 22:52:33 +02:00
Daniel J Walsh
5b2652c3e3 Merge pull request #975 from rhatdan/cleanup
Cleanup READMEs and Man pages
2017-10-05 14:59:19 -04:00
Mrunal Patel
c3630f807e test: Update go to 1.8.4
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-05 11:30:15 -07:00
Daniel J Walsh
61441c1272 Merge pull request #974 from mrunalp/bump_rc3
Release 1.0.0-rc3
2017-10-05 13:47:01 -04:00
Daniel J Walsh
3e7227789b Cleanup READMEs and Man pages
Alphabatize correctly and add missing content.  Also add video.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-10-05 13:39:53 -04:00
Mrunal Patel
18039484ac version: Switch to 1.0.0-rc4-dev
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-05 09:37:41 -07:00
Mrunal Patel
d2c6f64125 version: Release 1.0.0-rc3
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-05 09:37:07 -07:00
Daniel J Walsh
06e8fb9fdf Merge pull request #966 from baude/exit_code
BUGFIX: Invalid return codes in kpod
2017-10-05 08:29:12 -04:00
Daniel J Walsh
30d163900f Merge pull request #895 from baude/kpod_rmi_name
kpod rmi by ID untagged: %name incorrect
2017-10-05 08:28:04 -04:00
Daniel J Walsh
4e4a7c5c1d Merge pull request #959 from rhatdan/validate
validateFlags command line options to make sure the user entered a value
2017-10-04 18:29:57 -04:00
Daniel J Walsh
6657873d9d Merge pull request #967 from TomSweeneyRedHat/dev/tsweeney/ps_fix
Add pause state to ps, touchup kpod man page
2017-10-04 18:27:26 -04:00
baude
e27230bbaf kpod rmi by ID untagged: %name incorrect
As described in https://github.com/kubernetes-incubator/cri-o/issues/888, when
deleting by ID, the name being returned for the untagged message was "".

Signed-off-by: baude <bbaude@redhat.com>
2017-10-04 15:16:10 -05:00
baude
ee2b84167c kpod rmi by ID untagged: %name incorrect
As described in https://github.com/kubernetes-incubator/cri-o/issues/888, when
deleting by ID, the name being returned for the untagged message was "".

Signed-off-by: baude <bbaude@redhat.com>
2017-10-04 15:49:51 -04:00
baude
3611f92ddf BUGFIX: Invalid return codes in kpod
Set the exitsdir for kpod back to /var/run/crio... so kpod can benefit
from the container exit file.

Because 0 is the int32 blank value, kpod needs its own container state
struct with the omitempty removed so it can actually display 0 in
its default json output.

Signed-off-by: baude <bbaude@redhat.com>
2017-10-04 09:34:28 -05:00
TomSweeneyRedHat
f92ed659ab Add pause state to ps, touchup kpod man page
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2017-10-04 07:42:21 -04:00
Daniel J Walsh
04e96d05fc validateFlags command line options to make sure the user entered a value
When a user enters a CLI with a StringFlags or StringSliceFlags and does not add
a value the CLI mistakently takes the next option and uses it as a value.

This usually ends up with an error like not enough options or others.  Some times
it could also succeed, with weird results.  This patch looks for any values that
begin with a "-" and return an error.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-10-04 09:36:29 +00:00
Mrunal Patel
3e2ad8f10a Merge pull request #969 from mrunalp/btrfs_build
Btrfs build
2017-10-03 18:01:14 -07:00
Mrunal Patel
a643e533d8 Skip building btrfs support if library isn't installed
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
2017-10-03 13:18:36 -07:00