8a0b851b88
Found out that during OpenShift testing, node was trying to remove containers (probably in a bad state) and was failing the removal with this kind of error: E0828 13:19:46.082710 1235 kuberuntime_gc.go:127] Failed to remove container "e907f0f46b969e0dc83ca82c03ae7dd072cfe4155341e4521223d9fe3dec5afb": rpc error: code = 2 desc = failed to remove container exit file e907f0f46b969e0dc83ca82c03ae7dd072cfe4155341e4521223d9fe3dec5afb: remove /var/run/crio/exits/e907f0f46b969e0dc83ca82c03ae7dd072cfe4155341e4521223d9fe3dec5afb: no such file or directory I believe it's ok to ignore this error as it may happen conmon will fail early before exit file is written. Signed-off-by: Antonio Murdaca <runcom@redhat.com>
56 lines
1.7 KiB
Go
56 lines
1.7 KiB
Go
package server
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/kubernetes-incubator/cri-o/oci"
|
|
"github.com/sirupsen/logrus"
|
|
"golang.org/x/net/context"
|
|
pb "k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime"
|
|
)
|
|
|
|
// RemoveContainer removes the container. If the container is running, the container
|
|
// should be force removed.
|
|
func (s *Server) RemoveContainer(ctx context.Context, req *pb.RemoveContainerRequest) (*pb.RemoveContainerResponse, error) {
|
|
logrus.Debugf("RemoveContainerRequest %+v", req)
|
|
c, err := s.GetContainerFromRequest(req.ContainerId)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
cState := s.Runtime().ContainerStatus(c)
|
|
if cState.Status == oci.ContainerStateCreated || cState.Status == oci.ContainerStateRunning {
|
|
if err := s.Runtime().StopContainer(c, -1); err != nil {
|
|
return nil, fmt.Errorf("failed to stop container %s: %v", c.ID(), err)
|
|
}
|
|
if err := s.StorageRuntimeServer().StopContainer(c.ID()); err != nil {
|
|
return nil, fmt.Errorf("failed to unmount container %s: %v", c.ID(), err)
|
|
}
|
|
}
|
|
|
|
if err := s.Runtime().DeleteContainer(c); err != nil {
|
|
return nil, fmt.Errorf("failed to delete container %s: %v", c.ID(), err)
|
|
}
|
|
|
|
if err := os.Remove(filepath.Join(s.config.ContainerExitsDir, c.ID())); err != nil && !os.IsNotExist(err) {
|
|
return nil, fmt.Errorf("failed to remove container exit file %s: %v", c.ID(), err)
|
|
}
|
|
|
|
s.removeContainer(c)
|
|
|
|
if err := s.StorageRuntimeServer().DeleteContainer(c.ID()); err != nil {
|
|
return nil, fmt.Errorf("failed to delete storage for container %s: %v", c.ID(), err)
|
|
}
|
|
|
|
s.ReleaseContainerName(c.Name())
|
|
|
|
if err := s.CtrIDIndex().Delete(c.ID()); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
resp := &pb.RemoveContainerResponse{}
|
|
logrus.Debugf("RemoveContainerResponse: %+v", resp)
|
|
return resp, nil
|
|
}
|