8e5b17cf13
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
533 lines
14 KiB
Go
533 lines
14 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cache
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// helper function to reduce stuttering
|
|
func testPop(f *DeltaFIFO) testFifoObject {
|
|
return Pop(f).(Deltas).Newest().Object.(testFifoObject)
|
|
}
|
|
|
|
// keyLookupFunc adapts a raw function to be a KeyLookup.
|
|
type keyLookupFunc func() []testFifoObject
|
|
|
|
// ListKeys just calls kl.
|
|
func (kl keyLookupFunc) ListKeys() []string {
|
|
result := []string{}
|
|
for _, fifoObj := range kl() {
|
|
result = append(result, fifoObj.name)
|
|
}
|
|
return result
|
|
}
|
|
|
|
// GetByKey returns the key if it exists in the list returned by kl.
|
|
func (kl keyLookupFunc) GetByKey(key string) (interface{}, bool, error) {
|
|
for _, v := range kl() {
|
|
if v.name == key {
|
|
return v, true, nil
|
|
}
|
|
}
|
|
return nil, false, nil
|
|
}
|
|
|
|
func TestDeltaFIFO_basic(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
const amount = 500
|
|
go func() {
|
|
for i := 0; i < amount; i++ {
|
|
f.Add(mkFifoObj(string([]rune{'a', rune(i)}), i+1))
|
|
}
|
|
}()
|
|
go func() {
|
|
for u := uint64(0); u < amount; u++ {
|
|
f.Add(mkFifoObj(string([]rune{'b', rune(u)}), u+1))
|
|
}
|
|
}()
|
|
|
|
lastInt := int(0)
|
|
lastUint := uint64(0)
|
|
for i := 0; i < amount*2; i++ {
|
|
switch obj := testPop(f).val.(type) {
|
|
case int:
|
|
if obj <= lastInt {
|
|
t.Errorf("got %v (int) out of order, last was %v", obj, lastInt)
|
|
}
|
|
lastInt = obj
|
|
case uint64:
|
|
if obj <= lastUint {
|
|
t.Errorf("got %v (uint) out of order, last was %v", obj, lastUint)
|
|
} else {
|
|
lastUint = obj
|
|
}
|
|
default:
|
|
t.Fatalf("unexpected type %#v", obj)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_requeueOnPop(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
|
|
f.Add(mkFifoObj("foo", 10))
|
|
_, err := f.Pop(func(obj interface{}) error {
|
|
if obj.(Deltas)[0].Object.(testFifoObject).name != "foo" {
|
|
t.Fatalf("unexpected object: %#v", obj)
|
|
}
|
|
return ErrRequeue{Err: nil}
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if _, ok, err := f.GetByKey("foo"); !ok || err != nil {
|
|
t.Fatalf("object should have been requeued: %t %v", ok, err)
|
|
}
|
|
|
|
_, err = f.Pop(func(obj interface{}) error {
|
|
if obj.(Deltas)[0].Object.(testFifoObject).name != "foo" {
|
|
t.Fatalf("unexpected object: %#v", obj)
|
|
}
|
|
return ErrRequeue{Err: fmt.Errorf("test error")}
|
|
})
|
|
if err == nil || err.Error() != "test error" {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if _, ok, err := f.GetByKey("foo"); !ok || err != nil {
|
|
t.Fatalf("object should have been requeued: %t %v", ok, err)
|
|
}
|
|
|
|
_, err = f.Pop(func(obj interface{}) error {
|
|
if obj.(Deltas)[0].Object.(testFifoObject).name != "foo" {
|
|
t.Fatalf("unexpected object: %#v", obj)
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if _, ok, err := f.GetByKey("foo"); ok || err != nil {
|
|
t.Fatalf("object should have been removed: %t %v", ok, err)
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_compressorWorks(t *testing.T) {
|
|
oldestTypes := []DeltaType{}
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
// This function just keeps the most recent delta
|
|
// and puts deleted ones in the list.
|
|
DeltaCompressorFunc(func(d Deltas) Deltas {
|
|
if n := len(d); n > 1 {
|
|
oldestTypes = append(oldestTypes, d[0].Type)
|
|
d = d[1:]
|
|
}
|
|
return d
|
|
}),
|
|
nil,
|
|
)
|
|
if f.HasSynced() {
|
|
t.Errorf("Expected HasSynced to be false before completion of initial population")
|
|
}
|
|
f.Add(mkFifoObj("foo", 10))
|
|
f.Update(mkFifoObj("foo", 12))
|
|
f.Replace([]interface{}{mkFifoObj("foo", 20)}, "0")
|
|
f.Delete(mkFifoObj("foo", 22))
|
|
f.Add(mkFifoObj("foo", 25)) // flush the last one out
|
|
expect := []DeltaType{Added, Updated, Sync, Deleted}
|
|
if e, a := expect, oldestTypes; !reflect.DeepEqual(e, a) {
|
|
t.Errorf("Expected %#v, got %#v", e, a)
|
|
}
|
|
if e, a := (Deltas{{Added, mkFifoObj("foo", 25)}}), Pop(f).(Deltas); !reflect.DeepEqual(e, a) {
|
|
t.Fatalf("Expected %#v, got %#v", e, a)
|
|
}
|
|
if !f.HasSynced() {
|
|
t.Errorf("Expected HasSynced to be true after completion of initial population")
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_addUpdate(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
f.Add(mkFifoObj("foo", 10))
|
|
f.Update(mkFifoObj("foo", 12))
|
|
f.Delete(mkFifoObj("foo", 15))
|
|
|
|
if e, a := []interface{}{mkFifoObj("foo", 15)}, f.List(); !reflect.DeepEqual(e, a) {
|
|
t.Errorf("Expected %+v, got %+v", e, a)
|
|
}
|
|
if e, a := []string{"foo"}, f.ListKeys(); !reflect.DeepEqual(e, a) {
|
|
t.Errorf("Expected %+v, got %+v", e, a)
|
|
}
|
|
|
|
got := make(chan testFifoObject, 2)
|
|
go func() {
|
|
for {
|
|
obj := testPop(f)
|
|
t.Logf("got a thing %#v", obj)
|
|
t.Logf("D len: %v", len(f.queue))
|
|
got <- obj
|
|
}
|
|
}()
|
|
|
|
first := <-got
|
|
if e, a := 15, first.val; e != a {
|
|
t.Errorf("Didn't get updated value (%v), got %v", e, a)
|
|
}
|
|
select {
|
|
case unexpected := <-got:
|
|
t.Errorf("Got second value %v", unexpected.val)
|
|
case <-time.After(50 * time.Millisecond):
|
|
}
|
|
_, exists, _ := f.Get(mkFifoObj("foo", ""))
|
|
if exists {
|
|
t.Errorf("item did not get removed")
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_enqueueingNoLister(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
f.Add(mkFifoObj("foo", 10))
|
|
f.Update(mkFifoObj("bar", 15))
|
|
f.Add(mkFifoObj("qux", 17))
|
|
f.Delete(mkFifoObj("qux", 18))
|
|
|
|
// This delete does not enqueue anything because baz doesn't exist.
|
|
f.Delete(mkFifoObj("baz", 20))
|
|
|
|
expectList := []int{10, 15, 18}
|
|
for _, expect := range expectList {
|
|
if e, a := expect, testPop(f).val; e != a {
|
|
t.Errorf("Didn't get updated value (%v), got %v", e, a)
|
|
}
|
|
}
|
|
if e, a := 0, len(f.items); e != a {
|
|
t.Errorf("queue unexpectedly not empty: %v != %v\n%#v", e, a, f.items)
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_enqueueingWithLister(t *testing.T) {
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
nil,
|
|
keyLookupFunc(func() []testFifoObject {
|
|
return []testFifoObject{mkFifoObj("foo", 5), mkFifoObj("bar", 6), mkFifoObj("baz", 7)}
|
|
}),
|
|
)
|
|
f.Add(mkFifoObj("foo", 10))
|
|
f.Update(mkFifoObj("bar", 15))
|
|
|
|
// This delete does enqueue the deletion, because "baz" is in the key lister.
|
|
f.Delete(mkFifoObj("baz", 20))
|
|
|
|
expectList := []int{10, 15, 20}
|
|
for _, expect := range expectList {
|
|
if e, a := expect, testPop(f).val; e != a {
|
|
t.Errorf("Didn't get updated value (%v), got %v", e, a)
|
|
}
|
|
}
|
|
if e, a := 0, len(f.items); e != a {
|
|
t.Errorf("queue unexpectedly not empty: %v != %v", e, a)
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_addReplace(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
f.Add(mkFifoObj("foo", 10))
|
|
f.Replace([]interface{}{mkFifoObj("foo", 15)}, "0")
|
|
got := make(chan testFifoObject, 2)
|
|
go func() {
|
|
for {
|
|
got <- testPop(f)
|
|
}
|
|
}()
|
|
|
|
first := <-got
|
|
if e, a := 15, first.val; e != a {
|
|
t.Errorf("Didn't get updated value (%v), got %v", e, a)
|
|
}
|
|
select {
|
|
case unexpected := <-got:
|
|
t.Errorf("Got second value %v", unexpected.val)
|
|
case <-time.After(50 * time.Millisecond):
|
|
}
|
|
_, exists, _ := f.Get(mkFifoObj("foo", ""))
|
|
if exists {
|
|
t.Errorf("item did not get removed")
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_ResyncNonExisting(t *testing.T) {
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
nil,
|
|
keyLookupFunc(func() []testFifoObject {
|
|
return []testFifoObject{mkFifoObj("foo", 5)}
|
|
}),
|
|
)
|
|
f.Delete(mkFifoObj("foo", 10))
|
|
f.Resync()
|
|
|
|
deltas := f.items["foo"]
|
|
if len(deltas) != 1 {
|
|
t.Fatalf("unexpected deltas length: %v", deltas)
|
|
}
|
|
if deltas[0].Type != Deleted {
|
|
t.Errorf("unexpected delta: %v", deltas[0])
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_DeleteExistingNonPropagated(t *testing.T) {
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
nil,
|
|
keyLookupFunc(func() []testFifoObject {
|
|
return []testFifoObject{}
|
|
}),
|
|
)
|
|
f.Add(mkFifoObj("foo", 5))
|
|
f.Delete(mkFifoObj("foo", 6))
|
|
|
|
deltas := f.items["foo"]
|
|
if len(deltas) != 2 {
|
|
t.Fatalf("unexpected deltas length: %v", deltas)
|
|
}
|
|
if deltas[len(deltas)-1].Type != Deleted {
|
|
t.Errorf("unexpected delta: %v", deltas[len(deltas)-1])
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_ReplaceMakesDeletions(t *testing.T) {
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
nil,
|
|
keyLookupFunc(func() []testFifoObject {
|
|
return []testFifoObject{mkFifoObj("foo", 5), mkFifoObj("bar", 6), mkFifoObj("baz", 7)}
|
|
}),
|
|
)
|
|
f.Delete(mkFifoObj("baz", 10))
|
|
f.Replace([]interface{}{mkFifoObj("foo", 5)}, "0")
|
|
|
|
expectedList := []Deltas{
|
|
{{Deleted, mkFifoObj("baz", 10)}},
|
|
{{Sync, mkFifoObj("foo", 5)}},
|
|
// Since "bar" didn't have a delete event and wasn't in the Replace list
|
|
// it should get a tombstone key with the right Obj.
|
|
{{Deleted, DeletedFinalStateUnknown{Key: "bar", Obj: mkFifoObj("bar", 6)}}},
|
|
}
|
|
|
|
for _, expected := range expectedList {
|
|
cur := Pop(f).(Deltas)
|
|
if e, a := expected, cur; !reflect.DeepEqual(e, a) {
|
|
t.Errorf("Expected %#v, got %#v", e, a)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_UpdateResyncRace(t *testing.T) {
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
nil,
|
|
keyLookupFunc(func() []testFifoObject {
|
|
return []testFifoObject{mkFifoObj("foo", 5)}
|
|
}),
|
|
)
|
|
f.Update(mkFifoObj("foo", 6))
|
|
f.Resync()
|
|
|
|
expectedList := []Deltas{
|
|
{{Updated, mkFifoObj("foo", 6)}},
|
|
}
|
|
|
|
for _, expected := range expectedList {
|
|
cur := Pop(f).(Deltas)
|
|
if e, a := expected, cur; !reflect.DeepEqual(e, a) {
|
|
t.Errorf("Expected %#v, got %#v", e, a)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_HasSyncedCorrectOnDeletion(t *testing.T) {
|
|
f := NewDeltaFIFO(
|
|
testFifoObjectKeyFunc,
|
|
nil,
|
|
keyLookupFunc(func() []testFifoObject {
|
|
return []testFifoObject{mkFifoObj("foo", 5), mkFifoObj("bar", 6), mkFifoObj("baz", 7)}
|
|
}),
|
|
)
|
|
f.Replace([]interface{}{mkFifoObj("foo", 5)}, "0")
|
|
|
|
expectedList := []Deltas{
|
|
{{Sync, mkFifoObj("foo", 5)}},
|
|
// Since "bar" didn't have a delete event and wasn't in the Replace list
|
|
// it should get a tombstone key with the right Obj.
|
|
{{Deleted, DeletedFinalStateUnknown{Key: "bar", Obj: mkFifoObj("bar", 6)}}},
|
|
}
|
|
|
|
for _, expected := range expectedList {
|
|
if f.HasSynced() {
|
|
t.Errorf("Expected HasSynced to be false")
|
|
}
|
|
cur := Pop(f).(Deltas)
|
|
if e, a := expected, cur; !reflect.DeepEqual(e, a) {
|
|
t.Errorf("Expected %#v, got %#v", e, a)
|
|
}
|
|
}
|
|
if f.HasSynced() {
|
|
t.Errorf("Expected HasSynced to be true")
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_detectLineJumpers(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
|
|
f.Add(mkFifoObj("foo", 10))
|
|
f.Add(mkFifoObj("bar", 1))
|
|
f.Add(mkFifoObj("foo", 11))
|
|
f.Add(mkFifoObj("foo", 13))
|
|
f.Add(mkFifoObj("zab", 30))
|
|
|
|
if e, a := 13, testPop(f).val; a != e {
|
|
t.Fatalf("expected %d, got %d", e, a)
|
|
}
|
|
|
|
f.Add(mkFifoObj("foo", 14)) // ensure foo doesn't jump back in line
|
|
|
|
if e, a := 1, testPop(f).val; a != e {
|
|
t.Fatalf("expected %d, got %d", e, a)
|
|
}
|
|
|
|
if e, a := 30, testPop(f).val; a != e {
|
|
t.Fatalf("expected %d, got %d", e, a)
|
|
}
|
|
|
|
if e, a := 14, testPop(f).val; a != e {
|
|
t.Fatalf("expected %d, got %d", e, a)
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_addIfNotPresent(t *testing.T) {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
|
|
f.Add(mkFifoObj("b", 3))
|
|
b3 := Pop(f)
|
|
f.Add(mkFifoObj("c", 4))
|
|
c4 := Pop(f)
|
|
if e, a := 0, len(f.items); e != a {
|
|
t.Fatalf("Expected %v, got %v items in queue", e, a)
|
|
}
|
|
|
|
f.Add(mkFifoObj("a", 1))
|
|
f.Add(mkFifoObj("b", 2))
|
|
f.AddIfNotPresent(b3)
|
|
f.AddIfNotPresent(c4)
|
|
|
|
if e, a := 3, len(f.items); a != e {
|
|
t.Fatalf("expected queue length %d, got %d", e, a)
|
|
}
|
|
|
|
expectedValues := []int{1, 2, 4}
|
|
for _, expected := range expectedValues {
|
|
if actual := testPop(f).val; actual != expected {
|
|
t.Fatalf("expected value %d, got %d", expected, actual)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_KeyOf(t *testing.T) {
|
|
f := DeltaFIFO{keyFunc: testFifoObjectKeyFunc}
|
|
|
|
table := []struct {
|
|
obj interface{}
|
|
key string
|
|
}{
|
|
{obj: testFifoObject{name: "A"}, key: "A"},
|
|
{obj: DeletedFinalStateUnknown{Key: "B", Obj: nil}, key: "B"},
|
|
{obj: Deltas{{Object: testFifoObject{name: "C"}}}, key: "C"},
|
|
{obj: Deltas{{Object: DeletedFinalStateUnknown{Key: "D", Obj: nil}}}, key: "D"},
|
|
}
|
|
|
|
for _, item := range table {
|
|
got, err := f.KeyOf(item.obj)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error for %q: %v", item.obj, err)
|
|
continue
|
|
}
|
|
if e, a := item.key, got; e != a {
|
|
t.Errorf("Expected %v, got %v", e, a)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeltaFIFO_HasSynced(t *testing.T) {
|
|
tests := []struct {
|
|
actions []func(f *DeltaFIFO)
|
|
expectedSynced bool
|
|
}{
|
|
{
|
|
actions: []func(f *DeltaFIFO){},
|
|
expectedSynced: false,
|
|
},
|
|
{
|
|
actions: []func(f *DeltaFIFO){
|
|
func(f *DeltaFIFO) { f.Add(mkFifoObj("a", 1)) },
|
|
},
|
|
expectedSynced: true,
|
|
},
|
|
{
|
|
actions: []func(f *DeltaFIFO){
|
|
func(f *DeltaFIFO) { f.Replace([]interface{}{}, "0") },
|
|
},
|
|
expectedSynced: true,
|
|
},
|
|
{
|
|
actions: []func(f *DeltaFIFO){
|
|
func(f *DeltaFIFO) { f.Replace([]interface{}{mkFifoObj("a", 1), mkFifoObj("b", 2)}, "0") },
|
|
},
|
|
expectedSynced: false,
|
|
},
|
|
{
|
|
actions: []func(f *DeltaFIFO){
|
|
func(f *DeltaFIFO) { f.Replace([]interface{}{mkFifoObj("a", 1), mkFifoObj("b", 2)}, "0") },
|
|
func(f *DeltaFIFO) { Pop(f) },
|
|
},
|
|
expectedSynced: false,
|
|
},
|
|
{
|
|
actions: []func(f *DeltaFIFO){
|
|
func(f *DeltaFIFO) { f.Replace([]interface{}{mkFifoObj("a", 1), mkFifoObj("b", 2)}, "0") },
|
|
func(f *DeltaFIFO) { Pop(f) },
|
|
func(f *DeltaFIFO) { Pop(f) },
|
|
},
|
|
expectedSynced: true,
|
|
},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
f := NewDeltaFIFO(testFifoObjectKeyFunc, nil, nil)
|
|
|
|
for _, action := range test.actions {
|
|
action(f)
|
|
}
|
|
if e, a := test.expectedSynced, f.HasSynced(); a != e {
|
|
t.Errorf("test case %v failed, expected: %v , got %v", i, e, a)
|
|
}
|
|
}
|
|
}
|