Vincent Batts
ed464af779
This is a gnarly patchset that has been mashed together. It uncovered that some aspects of Check were never really working correctly for `xattr` keywords, but also the `Update()` had been left undone for a while. This includes some API changes around the `Keyword` and `KeyVal` types. Also I would like to update the signature for the `UpdateKeywordFunc` to just accept a `KeyVal` as an argugment, rather than a keyword AND the value. with this context there would be no need to guess on the value of what's passed to the xattr update function of whether it needs or already is base64 encoded. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
84 lines
1.7 KiB
Go
84 lines
1.7 KiB
Go
// +build linux
|
|
|
|
package mtree
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/vbatts/go-mtree/xattr"
|
|
)
|
|
|
|
func TestXattr(t *testing.T) {
|
|
testDir, present := os.LookupEnv("MTREE_TESTDIR")
|
|
if present == false {
|
|
// a bit dirty to create/destory a directory in cwd,
|
|
// but often /tmp is mounted tmpfs and doesn't support
|
|
// xattrs
|
|
testDir = "."
|
|
}
|
|
dir, err := ioutil.TempDir(testDir, "test.xattrs.")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dir)
|
|
fh, err := os.Create(filepath.Join(dir, "file"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
fh.WriteString("howdy")
|
|
fh.Sync()
|
|
if _, err := fh.Seek(0, 0); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := os.Symlink("./no/such/path", filepath.Join(dir, "symlink")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := xattr.Set(dir, "user.test", []byte("directory")); err != nil {
|
|
t.Skip(fmt.Sprintf("skipping: %q does not support xattrs", dir))
|
|
}
|
|
if err := xattr.Set(filepath.Join(dir, "file"), "user.test", []byte("regular file")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
dirstat, err := os.Lstat(dir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Check the directory
|
|
kvs, err := xattrKeywordFunc(dir, dirstat, nil)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
if len(kvs) == 0 {
|
|
t.Errorf("expected a keyval; got none")
|
|
}
|
|
|
|
filestat, err := fh.Stat()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Check the regular file
|
|
kvs, err = xattrKeywordFunc(filepath.Join(dir, "file"), filestat, fh)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
if len(kvs) == 0 {
|
|
t.Errorf("expected a keyval; got none")
|
|
}
|
|
|
|
linkstat, err := os.Lstat(filepath.Join(dir, "symlink"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Check a broken symlink
|
|
_, err = xattrKeywordFunc(filepath.Join(dir, "symlink"), linkstat, nil)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|