vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

net/pxe: fix error condition

Browse source 
Test return value of grub_netbuff_reserve(), buf itself cannot be
NULL here.

Found by: Coverity scan.
This commit is contained in:
Andrei Borzenkov 2015-01-30 22:39:11 +03:00
parent 7aaed66455
commit 12abe75aa0
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
grub-core/net/drivers/i386/pc/pxe.c
View file

@ -218,8 +218,7 @@ grub_pxe_recv (struct grub_net_card *dev __attribute__ ((unused)))
return NULL; return NULL;
/* Reserve 2 bytes so that 2 + 14/18 bytes of ethernet header is divisible /* Reserve 2 bytes so that 2 + 14/18 bytes of ethernet header is divisible
by 4. So that IP header is aligned on 4 bytes. */ by 4. So that IP header is aligned on 4 bytes. */
grub_netbuff_reserve (buf, 2); if (grub_netbuff_reserve (buf, 2))
if (!buf)
{ {
grub_netbuff_free (buf); grub_netbuff_free (buf);
return NULL; return NULL;