vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

2009-09-04 Vladimir Serbinenko <phcoder@gmail.com>

Browse source 
* loader/i386/xnu.c (grub_cpu_xnu_fill_devicetree): Remove
	unnecessary calls to grub_error.
This commit is contained in:
phcoder 2009-09-04 13:16:07 +00:00
parent 70ba68ce82
commit 197f76c741
2 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2009-09-04 Vladimir Serbinenko <phcoder@gmail.com>
* loader/i386/xnu.c (grub_cpu_xnu_fill_devicetree): Remove
unnecessary calls to grub_error.
2009-09-04 Colin Watson <cjwatson@ubuntu.com> 2009-09-04 Colin Watson <cjwatson@ubuntu.com>
* NEWS: Mention `keystatus' and Unicode fonts. * NEWS: Mention `keystatus' and Unicode fonts.

15
loader/i386/xnu.c
View file

@ -247,7 +247,7 @@ grub_cpu_xnu_fill_devicetree (void)
curval->datasize = (SYSTEM_TABLE_SIZEOF (firmware_revision)); curval->datasize = (SYSTEM_TABLE_SIZEOF (firmware_revision));
curval->data = grub_malloc (curval->datasize); curval->data = grub_malloc (curval->datasize);
if (! curval->data) if (! curval->data)
return grub_error (GRUB_ERR_OUT_OF_MEMORY, "couldn't create device tree"); return grub_errno;
grub_memcpy (curval->data, (SYSTEM_TABLE_VAR(firmware_revision)), grub_memcpy (curval->data, (SYSTEM_TABLE_VAR(firmware_revision)),
curval->datasize); curval->datasize);
@ -268,7 +268,7 @@ grub_cpu_xnu_fill_devicetree (void)
curval->datasize = sizeof ("EFI32"); curval->datasize = sizeof ("EFI32");
curval->data = grub_malloc (curval->datasize); curval->data = grub_malloc (curval->datasize);
if (! curval->data) if (! curval->data)
return grub_error (GRUB_ERR_OUT_OF_MEMORY, "couldn't create device tree"); return grub_errno;
if (SIZEOF_OF_UINTN == 4) if (SIZEOF_OF_UINTN == 4)
grub_memcpy (curval->data, "EFI32", curval->datasize); grub_memcpy (curval->data, "EFI32", curval->datasize);
else else
@ -287,7 +287,7 @@ grub_cpu_xnu_fill_devicetree (void)
curval->datasize = sizeof (grub_uint64_t); curval->datasize = sizeof (grub_uint64_t);
curval->data = grub_malloc (curval->datasize); curval->data = grub_malloc (curval->datasize);
if (!curval->data) if (!curval->data)
return grub_error (GRUB_ERR_OUT_OF_MEMORY, "couldn't create device tree"); return grub_errno;
/* First see if user supplies the value. */ /* First see if user supplies the value. */
char *fsbvar = grub_env_get ("fsb"); char *fsbvar = grub_env_get ("fsb");
@ -373,8 +373,7 @@ grub_cpu_xnu_fill_devicetree (void)
curval->datasize = SIZEOF_OF_UINTN; curval->datasize = SIZEOF_OF_UINTN;
curval->data = grub_malloc (curval->datasize); curval->data = grub_malloc (curval->datasize);
if (! curval->data) if (! curval->data)
return grub_error (GRUB_ERR_OUT_OF_MEMORY, return grub_errno;
"couldn't create device tree");
if (SIZEOF_OF_UINTN == 4) if (SIZEOF_OF_UINTN == 4)
*((grub_uint32_t *)curval->data) = PTR_TO_UINT32 (ptr); *((grub_uint32_t *)curval->data) = PTR_TO_UINT32 (ptr);
else else
@ -392,8 +391,7 @@ grub_cpu_xnu_fill_devicetree (void)
curval->datasize = grub_strlen (table_aliases[j].name) + 1; curval->datasize = grub_strlen (table_aliases[j].name) + 1;
curval->data = grub_malloc (curval->datasize); curval->data = grub_malloc (curval->datasize);
if (!curval->data) if (!curval->data)
return grub_error (GRUB_ERR_OUT_OF_MEMORY, return grub_errno;
"couldn't create device tree");
grub_memcpy (curval->data, table_aliases[j].name, curval->datasize); grub_memcpy (curval->data, table_aliases[j].name, curval->datasize);
} }
} }
@ -409,8 +407,7 @@ grub_cpu_xnu_fill_devicetree (void)
curval->datasize = SIZEOF_OF_UINTN; curval->datasize = SIZEOF_OF_UINTN;
curval->data = grub_malloc (curval->datasize); curval->data = grub_malloc (curval->datasize);
if (! curval->data) if (! curval->data)
return grub_error (GRUB_ERR_OUT_OF_MEMORY, return grub_errno;
"couldn't create device tree");
if (SIZEOF_OF_UINTN == 4) if (SIZEOF_OF_UINTN == 4)
*((grub_uint32_t *) curval->data) *((grub_uint32_t *) curval->data)
= PTR_TO_UINT32 (SYSTEM_TABLE_PTR (runtime_services)); = PTR_TO_UINT32 (SYSTEM_TABLE_PTR (runtime_services));