gfxmenu: Fix double free in load_image()
self->bitmap should be zeroed after free. Otherwise, there is a chance to double free (USE_AFTER_FREE) it later in rescale_image(). Fixes: CID 292472 Signed-off-by: Alexey Makhalov <amakhalov@vmware.com> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
parent
89f3da1a3d
commit
26a8c19307
1 changed files with 4 additions and 1 deletions
|
@ -195,7 +195,10 @@ load_image (grub_gui_image_t self, const char *path)
|
||||||
return grub_errno;
|
return grub_errno;
|
||||||
|
|
||||||
if (self->bitmap && (self->bitmap != self->raw_bitmap))
|
if (self->bitmap && (self->bitmap != self->raw_bitmap))
|
||||||
|
{
|
||||||
grub_video_bitmap_destroy (self->bitmap);
|
grub_video_bitmap_destroy (self->bitmap);
|
||||||
|
self->bitmap = 0;
|
||||||
|
}
|
||||||
if (self->raw_bitmap)
|
if (self->raw_bitmap)
|
||||||
grub_video_bitmap_destroy (self->raw_bitmap);
|
grub_video_bitmap_destroy (self->raw_bitmap);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue