From 26dc1a3ff6854a865f3b4efbb64ce9ccb603cc3b Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Mon, 9 Jul 2018 19:49:06 +0100 Subject: [PATCH] i386: Don't include lib/i386/reset.c in EFI builds Commit 0ba90a7f0178 ("efi: Move grub_reboot() into kernel") broke the build on i386-efi - genmoddep.awk bails out with message grub_reboot in reboot is duplicated in kernel This is because both lib/i386/reset.c and kern/efi/efi.c now provide this function. Rather than explicitly list each i386 platform variant in Makefile.core.def, include the contents of lib/i386/reset.c only when GRUB_MACHINE_EFI is not set. Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper --- grub-core/lib/i386/reboot.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/grub-core/lib/i386/reboot.c b/grub-core/lib/i386/reboot.c index a234244dc..dce0b563d 100644 --- a/grub-core/lib/i386/reboot.c +++ b/grub-core/lib/i386/reboot.c @@ -16,6 +16,8 @@ * along with GRUB. If not, see . */ +#ifndef GRUB_MACHINE_EFI + #include #include #include @@ -58,3 +60,5 @@ grub_reboot (void) while (1); } + +#endif /* GRUB_MACHINE_EFI */