vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

grub-reboot: Warn when "for the next boot only" promise cannot be kept

Browse source 
The "for the next boot only" property of grub-reboot is dependent upon
GRUB being able to clear the next_entry variable in the environment
block. However, GRUB cannot write to devices using the diskfilter
and lvm abstractions.

Ref: https://lists.gnu.org/archive/html/grub-devel/2009-12/msg00276.html
Ref: https://bugs.launchpad.net/bugs/788298

Signed-off-by: dann frazier <dann.frazier@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
dann frazier 2018-08-17 17:33:44 -06:00 committed by Daniel Kiper
parent d2374cfb71
commit 478e54b738
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
util/grub-reboot.in
View file

@ -20,6 +20,7 @@
prefix=@prefix@ prefix=@prefix@
exec_prefix=@exec_prefix@ exec_prefix=@exec_prefix@
bindir=@bindir@ bindir=@bindir@
sbindir=@sbindir@
sysconfdir="@sysconfdir@" sysconfdir="@sysconfdir@"
PACKAGE_NAME=@PACKAGE_NAME@ PACKAGE_NAME=@PACKAGE_NAME@
PACKAGE_VERSION=@PACKAGE_VERSION@ PACKAGE_VERSION=@PACKAGE_VERSION@
@ -32,6 +33,7 @@ fi
self=`basename $0` self=`basename $0`
grub_editenv=${bindir}/@grub_editenv@ grub_editenv=${bindir}/@grub_editenv@
grub_probe=${sbindir}/@grub_probe@
rootdir= rootdir=
bootdir= bootdir=
grubdir=`echo "/@bootdirname@/@grubdirname@" | sed 's,//*,/,g'` grubdir=`echo "/@bootdirname@/@grubdirname@" | sed 's,//*,/,g'`
@ -56,6 +58,8 @@ submenus or sub-submenus require specifying the submenu components and then the
menu item component. The titles should be separated using the greater-than menu item component. The titles should be separated using the greater-than
character (>) with no extra spaces. Depending on your shell some characters including > may need escaping. More information about this is available character (>) with no extra spaces. Depending on your shell some characters including > may need escaping. More information about this is available
in the GRUB Manual in the section about the 'default' command. "; echo in the GRUB Manual in the section about the 'default' command. "; echo
echo
gettext "NOTE: In cases where GRUB cannot write to the environment block, such as when it is stored on an MDRAID or LVM device, the chosen boot menu entry will remain the default even after reboot. "; echo
echo echo
gettext "Report bugs to <bug-grub@gnu.org>."; echo gettext "Report bugs to <bug-grub@gnu.org>."; echo
} }
@ -131,6 +135,18 @@ fi
grubdir=`echo "${bootdir}/@grubdirname@" | sed 's,//*,/,g'` grubdir=`echo "${bootdir}/@grubdirname@" | sed 's,//*,/,g'`
abstractions=`$grub_probe --target=abstraction ${grubdir}/grubenv`
for abstraction in $abstractions; do
case "$abstraction" in
diskfilter | lvm)
gettext_printf "\nWARNING: Detected GRUB environment block on $abstraction device\n"
gettext_printf "%s will remain the default boot entry until manually cleared with:\n" "${entry}"
gettext_printf " grub-editenv ${grubdir}/grubenv unset next_entry\n\n"
break
;;
esac
done
# Restore saved_entry if it was set by previous version # Restore saved_entry if it was set by previous version
prev_saved_entry=`$grub_editenv ${grubdir}/grubenv list | sed -n 's/^prev_saved_entry=//p'` prev_saved_entry=`$grub_editenv ${grubdir}/grubenv list | sed -n 's/^prev_saved_entry=//p'`
if [ "$prev_saved_entry" ]; then if [ "$prev_saved_entry" ]; then