vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

hfsplus: Fix potential access to uninited memory on invalid FS

Browse source
This commit is contained in:
Vladimir Serbinenko 2015-03-06 22:33:20 +01:00
parent be41c1cf11
commit 5fe21c9968
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
grub-core/fs/hfsplus.c
View file

@ -336,6 +336,9 @@ grub_hfsplus_mount (grub_disk_t disk)
data->case_sensitive = ((magic == GRUB_HFSPLUSX_MAGIC) &&
(header.key_compare == GRUB_HFSPLUSX_BINARYCOMPARE));
if (data->catalog_tree.nodesize < 2)
goto fail;
if (grub_hfsplus_read_file (&data->extoverflow_tree.file, 0, 0,
sizeof (struct grub_hfsplus_btnode),
sizeof (header), (char *) &header) <= 0)
@ -350,6 +353,9 @@ grub_hfsplus_mount (grub_disk_t disk)
data->extoverflow_tree.root = grub_be_to_cpu32 (header.root);
data->extoverflow_tree.nodesize = grub_be_to_cpu16 (header.nodesize);
if (data->extoverflow_tree.nodesize < 2)
goto fail;
if (grub_hfsplus_read_file (&data->attr_tree.file, 0, 0,
sizeof (struct grub_hfsplus_btnode),
sizeof (header), (char *) &header) <= 0)