vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

menu_entry: Disable cursor during update_screen()

Browse source 
When running grub in a VGA console of a KVM pseries guest on PowerPC,
you can see the cursor sweeping over the whole line when entering a
character in editor mode. This is visible because grub always refreshes
the whole line when entering a character in editor mode, and drawing
characters is quite a slow operation with the firmware used for the
powerpc pseries guests (SLOF).
To avoid this ugliness, the cursor should be disabled when refreshing
the screen contents during update_screen().

Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Thomas Huth 2016-01-29 15:26:58 +01:00 • committed by Andrei Borzenkov
parent e3745f9087
commit 625934ec0f
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
grub-core/normal/menu_entry.c
View file

@ -254,6 +254,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen,
mode = ALL_LINES; mode = ALL_LINES;
} }
grub_term_setcursor (term_screen->term, 0);
if (mode != NO_LINE) if (mode != NO_LINE)
{ {
/* Draw lines. This code is tricky, because this must calculate logical /* Draw lines. This code is tricky, because this must calculate logical
@ -361,6 +363,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen,
} }
grub_term_setcursor (term_screen->term, 1);
grub_term_refresh (term_screen->term); grub_term_refresh (term_screen->term);
} }