vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Initialized initrd_ctx so we don't free a random pointer from the stack.

Browse source 
Currently, if "linux" fails, the "goto fail;" in grub_cmd_initrd sends us
into grub_initrd_close() without grub_initrd_init() being called, and thus
it never clears initrd_ctx->components.  grub_initrd_close() then frees that
address, which is stale data from the stack.  If the stack happens to have a
stale *address* there that matches a recent allocation, then you'll get a
double free later.

So initialize the memory up front.

Signed-off-by: Peter Jones <pjones@redhat.com>
This commit is contained in:
Peter Jones 2014-09-17 16:30:11 -04:00 • committed by Andrei Borzenkov
parent 60049a0e72
commit 631a820038
9 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
grub-core/loader/mips/linux.c
View file

@ -415,7 +415,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
void *initrd_src;
grub_addr_t initrd_dest;
grub_err_t err;
struct grub_linux_initrd_context initrd_ctx;
struct grub_linux_initrd_context initrd_ctx = { 0, };
if (argc == 0)
return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));