From 7195688f4780026179d97e2a58c1e018863097c9 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Wed, 17 Apr 2019 07:12:56 +0200 Subject: [PATCH] efi: Avoid NULL dereference if FilePath is NULL The UEFI specification allows LoadImage() to be called with a memory location only and without a device path. In this case FilePath will not be set in the EFI_LOADED_IMAGE_PROTOCOL. So in function grub_efi_get_filename() the device path argument may be NULL. As we cannot determine the device path in this case just return NULL from the function. Signed-off-by: Heinrich Schuchardt Reviewed-by: Leif Lindholm Reviewed-by: Daniel Kiper --- grub-core/kern/efi/efi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/efi/efi.c b/grub-core/kern/efi/efi.c index c8a9d8307..5ba34d7ed 100644 --- a/grub-core/kern/efi/efi.c +++ b/grub-core/kern/efi/efi.c @@ -355,6 +355,9 @@ grub_efi_get_filename (grub_efi_device_path_t *dp0) grub_size_t filesize = 0; grub_efi_device_path_t *dp; + if (!dp0) + return NULL; + dp = dp0; while (1)