From 73e8e268b7ac5daec77ee44a596afde07f0cd35b Mon Sep 17 00:00:00 2001 From: robertmh Date: Thu, 20 Nov 2008 19:22:20 +0000 Subject: [PATCH] * util/grub-mkconfig_lib.in (grub_warn): New function. (convert_system_path_to_grub_path): Use grub_warn() when issuing warnings, to obtain consistent formatting. * util/grub.d/00_header.in: Likewise. * util/update-grub_lib.in: Likewise. --- ChangeLog | 8 +++++++- util/grub-mkconfig_lib.in | 7 ++++++- util/grub.d/00_header.in | 2 +- util/update-grub_lib.in | 3 ++- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8009d8022..8517aed5a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,14 @@ -2008-11-19 Robert Millan +2008-11-20 Robert Millan * kern/i386/coreboot/init.c (grub_time_tics): Remove variable. (grub_get_rtc, grub_exit): Abort with grub_fatal() if called. + * util/grub-mkconfig_lib.in (grub_warn): New function. + (convert_system_path_to_grub_path): Use grub_warn() when issuing + warnings, to obtain consistent formatting. + * util/grub.d/00_header.in: Likewise. + * util/update-grub_lib.in: Likewise. + 2008-11-19 Robert Millan * loader/i386/pc/linux.c (grub_rescue_cmd_initrd): Fix a typo. diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in index 83eb3b8d7..fb842f2d4 100644 --- a/util/grub-mkconfig_lib.in +++ b/util/grub-mkconfig_lib.in @@ -25,6 +25,11 @@ pkgdatadir=${datadir}/`echo @PACKAGE_TARNAME@ | sed "${transform}"` grub_probe=${sbindir}/`echo grub-probe | sed ${transform}` +grub_warn () +{ + echo "Warning: $@" >&2 +} + make_system_path_relative_to_its_root () { path=$1 @@ -107,7 +112,7 @@ convert_system_path_to_grub_path () { path=$1 - echo "Warning: convert_system_path_to_grub_path() is deprecated. Use prepare_grub_to_access_device() instead." >&2 + grub_warn "convert_system_path_to_grub_path() is deprecated. Use prepare_grub_to_access_device() instead." # abort if GRUB can't access the path if is_path_readable_by_grub ${path} ; then : ; else diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in index fe17b6769..3d434d765 100644 --- a/util/grub.d/00_header.in +++ b/util/grub.d/00_header.in @@ -47,7 +47,7 @@ case ${GRUB_TERMINAL_INPUT}:${GRUB_TERMINAL_OUTPUT} in fi if [ "x${GRUB_SERIAL_COMMAND}" = "x" ] ; then - echo "Warning, requested serial terminal but GRUB_SERIAL_COMMAND is unspecified. Default parameters will be used." >&2 + grub_warn "Requested serial terminal but GRUB_SERIAL_COMMAND is unspecified. Default parameters will be used." GRUB_SERIAL_COMMAND=serial fi echo "${GRUB_SERIAL_COMMAND}" diff --git a/util/update-grub_lib.in b/util/update-grub_lib.in index 25311ce2b..998452e67 100644 --- a/util/update-grub_lib.in +++ b/util/update-grub_lib.in @@ -18,5 +18,6 @@ prefix=@prefix@ exec_prefix=@exec_prefix@ libdir=@libdir@ -echo "warning: update-grub_lib is deprecated, use grub-mkconfig_lib instead" >&2 . ${libdir}/grub/grub-mkconfig_lib + +grub_warn "update-grub_lib is deprecated, use grub-mkconfig_lib instead"