syntax check before overwriting

This commit is contained in:
bvk.groups@gmail.com 2010-09-07 11:18:53 +05:30
parent 4d69c7863b
commit 75d8c629fc

View file

@ -314,8 +314,15 @@ for i in ${grub_mkconfig_dir}/* ; do
done
if test "x${grub_cfg}" != "x" ; then
# none of the children aborted with error, install the new grub.cfg
mv -f ${grub_cfg}.new ${grub_cfg}
if ! grub-script-check ${grub_cfg}.new 2>/dev/null; then
echo "Syntax errors are detected in generated GRUB config file." >&2
echo "Ensure that there are no errors in /etc/default/grub" >&2
echo "and /etc/grub.d/* files or please file a bug report with" >&2
echo "${grub_cfg}.new file attached." >&2
else
# none of the children aborted with error, install the new grub.cfg
mv -f ${grub_cfg}.new ${grub_cfg}
fi
fi
echo "done" >&2