vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

f2fs: Disable gcc9 -Waddress-of-packed-member

Browse source 
Disable the -Wadress-of-packaed-member diagnostic for the grub_f2fs_label
function since the result is found to be false postive.

A pointer to the 'volume_name' member of 'struct grub_f2fs_superblock' is
guaranteed to be aligned as the offset of 'volume_name' within the struct
is dividable by the natural alignment on both 32- and 64-bit targets.

grub-core/fs/f2fs.c: In function ‘grub_f2fs_label’:
grub-core/fs/f2fs.c:1253:60: error: taking address of packed member of ‘struct grub_f2fs_superblock’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
 1253 |     *label = (char *) grub_f2fs_utf16_to_utf8 (data->sblock.volume_name);
      |                                                ~~~~~~~~~~~~^~~~~~~~~~~~
cc1: all warnings being treated as errors

Reported-by: Neil MacLeod <neil@nmacleod.com>
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Tested-by: Neil MacLeod <neil@nmacleod.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
John Paul Adrian Glaubitz 2019-05-29 08:34:55 +02:00 committed by Daniel Kiper
parent 53e70d30cf
commit 8e8723a6be
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
grub-core/fs/f2fs.c
View file

@ -1240,6 +1240,11 @@ grub_f2fs_utf16_to_utf8 (grub_uint16_t *in_buf_le)
return out_buf; return out_buf;
} }
#if __GNUC__ >= 9
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Waddress-of-packed-member"
#endif
static grub_err_t static grub_err_t
grub_f2fs_label (grub_device_t device, char **label) grub_f2fs_label (grub_device_t device, char **label)
{ {
@ -1260,6 +1265,10 @@ grub_f2fs_label (grub_device_t device, char **label)
return grub_errno; return grub_errno;
} }
#if __GNUC__ >= 9
#pragma GCC diagnostic pop
#endif
static grub_err_t static grub_err_t
grub_f2fs_uuid (grub_device_t device, char **uuid) grub_f2fs_uuid (grub_device_t device, char **uuid)
{ {