vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

ofnet: Initialize structs in bootpath parser

Browse source 
Code later on checks if variables inside the struct are
0 to see if they have been set, like if there were addresses
in the bootpath.

The variables were not initialized however, so the check
might succeed with uninitialized data, and a new interface
with random addresses and the same name is added. This causes
$net_default_mac to point to the random one, so, for example,
using that variable to load per-mac config files fails.

Bug-Ubuntu: https://bugs.launchpad.net/bugs/1785859

Signed-off-by: Julian Andres Klode <julian.klode@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Julian Andres Klode 2018-09-03 10:09:15 +02:00 committed by Daniel Kiper
parent 478e54b738
commit a661a321c3
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
grub-core/net/drivers/ieee1275/ofnet.c
View file

@ -153,8 +153,8 @@ grub_ieee1275_parse_bootpath (const char *devpath, char *bootpath,
char *comma_char = 0; char *comma_char = 0;
char *equal_char = 0; char *equal_char = 0;
grub_size_t field_counter = 0; grub_size_t field_counter = 0;
grub_net_network_level_address_t client_addr, gateway_addr, subnet_mask; grub_net_network_level_address_t client_addr = {}, gateway_addr = {}, subnet_mask = {};
grub_net_link_level_address_t hw_addr; grub_net_link_level_address_t hw_addr = {};
grub_net_interface_flags_t flags = 0; grub_net_interface_flags_t flags = 0;
struct grub_net_network_level_interface *inter = NULL; struct grub_net_network_level_interface *inter = NULL;
grub_uint16_t vlantag = 0; grub_uint16_t vlantag = 0;