vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

efi: Avoid NULL dereference if FilePath is NULL

Browse source 
The UEFI specification allows LoadImage() to be called with a memory
location only and without a device path. In this case FilePath will not be
set in the EFI_LOADED_IMAGE_PROTOCOL.

So in function grub_efi_get_filename() the device path argument may be
NULL. As we cannot determine the device path in this case just return NULL
from the function.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Heinrich Schuchardt 2019-04-17 07:12:56 +02:00 committed by Daniel Kiper
parent acc726f812
commit bc58fded50
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
grub-core/kern/efi/efi.c
View file

@ -327,6 +327,9 @@ grub_efi_get_filename (grub_efi_device_path_t *dp0)
grub_size_t filesize = 0;
grub_efi_device_path_t *dp;
if (!dp0)
return NULL;
dp = dp0;
while (1)