vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

util/setup: fix memory leak.

Browse source 
Found by: Coverity scan.
This commit is contained in:
Andrei Borzenkov 2015-01-26 22:44:45 +03:00
parent fe4efe0d50
commit bd196014ec
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
util/setup.c
View file

@ -670,15 +670,17 @@ unable_to_embed:
if (dest_dev->disk->id != root_dev->disk->id if (dest_dev->disk->id != root_dev->disk->id
|| dest_dev->disk->dev->id != root_dev->disk->dev->id) || dest_dev->disk->dev->id != root_dev->disk->dev->id)
{ {
const char *dest_ofpath; char *dest_ofpath;
dest_ofpath dest_ofpath
= grub_util_devname_to_ofpath (grub_util_biosdisk_get_osdev (root_dev->disk)); = grub_util_devname_to_ofpath (grub_util_biosdisk_get_osdev (root_dev->disk));
/* FIXME handle NULL result */
grub_util_info ("dest_ofpath is `%s'", dest_ofpath); grub_util_info ("dest_ofpath is `%s'", dest_ofpath);
strncpy (boot_devpath, dest_ofpath, strncpy (boot_devpath, dest_ofpath,
GRUB_BOOT_MACHINE_BOOT_DEVPATH_END GRUB_BOOT_MACHINE_BOOT_DEVPATH_END
- GRUB_BOOT_MACHINE_BOOT_DEVPATH - 1); - GRUB_BOOT_MACHINE_BOOT_DEVPATH - 1);
boot_devpath[GRUB_BOOT_MACHINE_BOOT_DEVPATH_END boot_devpath[GRUB_BOOT_MACHINE_BOOT_DEVPATH_END
- GRUB_BOOT_MACHINE_BOOT_DEVPATH - 1] = 0; - GRUB_BOOT_MACHINE_BOOT_DEVPATH - 1] = 0;
free (dest_ofpath);
} }
else else
{ {