From c2fc41990a77923c44a71d616561920ae186db56 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Tue, 27 Jan 2015 16:48:53 +0100 Subject: [PATCH] linux/hostdisk: Limit strcpy size to buffer size. Found by: Coverity scan. --- grub-core/osdep/linux/hostdisk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/hostdisk.c index c96427a56..75cb8f55d 100644 --- a/grub-core/osdep/linux/hostdisk.c +++ b/grub-core/osdep/linux/hostdisk.c @@ -376,7 +376,7 @@ grub_util_fd_open_device (const grub_disk_t disk, grub_disk_addr_t sector, int f part_start = grub_partition_get_start (disk->partition); - strcpy (dev, grub_util_biosdisk_get_osdev (disk)); + strlcpy (dev, grub_util_biosdisk_get_osdev (disk), sizeof (dev)); if (disk->partition && strncmp (dev, "/dev/", 5) == 0) { @@ -439,7 +439,7 @@ grub_util_fd_open_device (const grub_disk_t disk, grub_disk_addr_t sector, int f if (*max == 0) *max = ~0ULL; is_partition = 0; - strcpy (dev, grub_util_biosdisk_get_osdev (disk)); + strlcpy (dev, grub_util_biosdisk_get_osdev (disk), sizeof (dev)); goto reopen; } sector -= part_start;